Page MenuHomePhabricator

Remove the dashboard "template" workflow
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:06 PM.

Details

Summary

Depends on D20364. Ref T13272. When you create a dashboard, we currently give you a modal choice between an empty dashboard and a "simple template" dashboard.

Remove this choice, and create an empty dashboard in all cases instead.

I think this template dashboard flow isn't terribly useful, and is partly covering over other deficiencies in the workflow. I'm fixing many of those and suspect we can get away without this now. Users on this flow also may not really know what they want. This also contributes to having a lot of extra unmoored panels floating around.

If we did rebuild this, I'd like to address more specific use cases and probably build it as "Add a Template Panel..." or similar, as an action you can use to quickly update an existing workboard. This would be a lot more flexible than create-a-whole-template-board.

Test Plan

Created a new board, no more "template: yes or no?" gate.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 4:06 PM
epriestley requested review of this revision.Apr 2 2019, 4:08 PM
amckinley accepted this revision.Apr 3 2019, 6:43 PM
This revision is now accepted and ready to land.Apr 3 2019, 6:43 PM
This revision was automatically updated to reflect the committed changes.