Page MenuHomePhabricator

Fix some overlooked profile menu construction callsites
ClosedPublic

Authored by epriestley on Apr 9 2019, 9:24 PM.
Tags
None
Referenced Files
F19912553: D20385.id48646.diff
Thu, Apr 2, 7:50 PM
F19896825: D20385.id.diff
Sun, Mar 29, 5:12 AM
F19895382: D20385.id48647.diff
Sat, Mar 28, 8:37 PM
F19891936: D20385.id.diff
Fri, Mar 27, 7:39 PM
F19725442: D20385.id48647.diff
Feb 13 2026, 3:46 PM
F19652309: D20385.id48647.diff
Feb 6 2026, 1:27 PM
F19503821: D20385.id48646.diff
Jan 9 2026, 1:47 AM
F19491709: D20385.diff
Jan 8 2026, 7:33 AM
Subscribers
None

Details

Summary

Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.

Test Plan
  • Visited each controller, saw actual pages instead of menu construction fatals.
  • Grepped for getProfileMenu().

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable