Page MenuHomePhabricator
Differential D20385

Fix some overlooked profile menu construction callsites
ClosedPublic
Actions

Authored by epriestley on Apr 9 2019, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 7, 12:52 AM
Unknown Object (File)
Mon, May 5, 4:43 AM
Unknown Object (File)
Sat, May 3, 7:14 AM
Unknown Object (File)
Apr 23 2025, 11:45 PM
Unknown Object (File)
Apr 11 2025, 3:16 PM
Unknown Object (File)
Apr 11 2025, 2:56 PM
Unknown Object (File)
Apr 10 2025, 8:05 AM
Unknown Object (File)
Apr 9 2025, 10:05 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13275: Build Portals: a standalone menu page / dashboard of dashboards
Commits
rPfb193106314e: Fix some overlooked profile menu construction callsites
Summary

Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.

Test Plan
  • Visited each controller, saw actual pages instead of menu construction fatals.
  • Grepped for getProfileMenu().

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48647

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
Phabricator · Built by Phacility