Paths

Table of Contentst

Differential D20385

Fix some overlooked profile menu construction callsites
ClosedPublic
Actions

Authored by epriestley on Apr 9 2019, 9:24 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13275: Build Portals: a standalone menu page / dashboard of dashboards

Commits

rPfb193106314e: Fix some overlooked profile menu construction callsites

Summary

Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.

Test Plan

Visited each controller, saw actual pages instead of menu construction fatals.
Grepped for getProfileMenu().

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 9 2019, 9:24 PM

Harbormaster completed remote builds in B22521: Diff 48646.Apr 9 2019, 9:26 PM

epriestley requested review of this revision.Apr 9 2019, 9:26 PM

amckinley accepted this revision.Apr 9 2019, 9:40 PM

This revision is now accepted and ready to land.Apr 9 2019, 9:40 PM

Closed by commit rPfb193106314e: Fix some overlooked profile menu construction callsites (authored by epriestley). · Explain WhyApr 9 2019, 9:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileEditController.php

5 lines

PhabricatorPeopleProfilePictureController.php

5 lines

project/

controller/

PhabricatorProjectBoardBackgroundController.php

4 lines

PhabricatorProjectBoardManageController.php

4 lines

PhabricatorProjectColumnDetailController.php

4 lines

PhabricatorProjectEditPictureController.php

5 lines

Diff 48647

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

View Options

src/applications/project/controller/PhabricatorProjectBoardManageController.php

View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Fix some overlooked profile menu construction callsitesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48647

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

src/applications/project/controller/PhabricatorProjectBoardManageController.php

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Fix some overlooked profile menu construction callsites
ClosedPublic
Actions

Revision Contents
Changeset List