Page MenuHomePhabricator
Differential D20385

Fix some overlooked profile menu construction callsites
ClosedPublic
Actions

Authored by epriestley on Apr 9 2019, 9:24 PM.
Tags
None
Referenced Files
F18837203: D20385.diff
Mon, Oct 27, 4:39 AM
F18817466: D20385.id48646.diff
Oct 21 2025, 3:50 PM
F18683739: D20385.diff
Sep 26 2025, 8:16 AM
F18649829: D20385.diff
Sep 20 2025, 10:20 PM
F18628577: D20385.id48647.diff
Sep 16 2025, 6:38 AM
F18628401: D20385.id.diff
Sep 16 2025, 6:16 AM
F18590668: D20385.diff
Sep 12 2025, 6:44 AM
F18518688: D20385.diff
Sep 5 2025, 3:34 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13275: Build Portals: a standalone menu page / dashboard of dashboards
Commits
rPfb193106314e: Fix some overlooked profile menu construction callsites
Summary

Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.

Test Plan
  • Visited each controller, saw actual pages instead of menu construction fatals.
  • Grepped for getProfileMenu().

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48647

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
Phabricator · Built by Phacility