Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F13043138: D20374.diff
Wed, Apr 17, 2:16 PM
Unknown Object (File)
Thu, Apr 11, 7:14 AM
Unknown Object (File)
Sun, Mar 31, 3:59 PM
Unknown Object (File)
Thu, Mar 28, 3:29 PM
Unknown Object (File)
Wed, Mar 27, 9:39 PM
Unknown Object (File)
Jan 5 2024, 7:26 PM
Unknown Object (File)
Dec 27 2023, 12:16 PM
Unknown Object (File)
Dec 20 2023, 11:34 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable