Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus

Authored by epriestley on Apr 2 2019, 8:55 PM.



Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 8:55 PM
epriestley requested review of this revision.Apr 2 2019, 8:56 PM
amckinley accepted this revision.Apr 3 2019, 7:15 PM
This revision is now accepted and ready to land.Apr 3 2019, 7:15 PM
This revision was automatically updated to reflect the committed changes.