Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F15471365: D20374.diff
Sat, Apr 5, 4:41 AM
F15431353: D20374.id48640.diff
Mon, Mar 24, 11:52 AM
Unknown Object (File)
Feb 21 2025, 5:23 PM
Unknown Object (File)
Feb 12 2025, 11:48 AM
Unknown Object (File)
Feb 9 2025, 7:33 AM
Unknown Object (File)
Feb 9 2025, 7:33 AM
Unknown Object (File)
Feb 9 2025, 7:33 AM
Unknown Object (File)
Feb 9 2025, 7:33 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable