Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F18763276: D20374.id.diff
Mon, Oct 6, 11:34 PM
F18728515: D20374.diff
Tue, Sep 30, 9:35 AM
F18650121: D20374.diff
Sat, Sep 20, 11:32 PM
F18631498: D20374.id48599.diff
Tue, Sep 16, 3:33 PM
F18631493: D20374.id48599.diff
Tue, Sep 16, 3:32 PM
F18624924: D20374.id.diff
Mon, Sep 15, 9:26 PM
F18518647: D20374.diff
Sep 5 2025, 3:31 PM
F18461286: D20374.id48640.diff
Sep 1 2025, 8:15 PM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable