Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F15580997: D20374.id48640.diff
Wed, May 7, 9:07 AM
F15572747: D20374.id48599.diff
Mon, May 5, 5:30 PM
F15571531: D20374.diff
Mon, May 5, 6:46 AM
F15571127: D20374.diff
Mon, May 5, 4:26 AM
F15552399: D20374.id48599.diff
Sun, Apr 27, 8:43 PM
F15538331: D20374.diff
Thu, Apr 24, 6:39 PM
F15490326: D20374.id48599.diff
Fri, Apr 11, 4:11 PM
F15489975: D20374.id48640.diff
Fri, Apr 11, 1:57 PM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable