Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F18837187: D20374.id48640.diff
Mon, Oct 27, 4:37 AM
F18837185: D20374.id48599.diff
Mon, Oct 27, 4:37 AM
F18837184: D20374.id.diff
Mon, Oct 27, 4:37 AM
F18834149: D20374.diff
Sun, Oct 26, 6:58 AM
F18827214: D20374.diff
Fri, Oct 24, 8:30 AM
F18818879: D20374.diff
Wed, Oct 22, 2:51 AM
F18805080: D20374.diff
Sat, Oct 18, 1:39 PM
F18795521: D20374.id48599.diff
Fri, Oct 17, 2:07 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable