Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F19444955: D20374.id48640.diff
Mon, Dec 29, 9:47 AM
F19444954: D20374.id48599.diff
Mon, Dec 29, 9:47 AM
F19062434: D20374.diff
Nov 29 2025, 3:53 PM
F19022132: D20374.diff
Nov 23 2025, 8:20 PM
F18994499: D20374.diff
Nov 19 2025, 11:53 AM
F18837187: D20374.id48640.diff
Oct 27 2025, 4:37 AM
F18837185: D20374.id48599.diff
Oct 27 2025, 4:37 AM
F18837184: D20374.id.diff
Oct 27 2025, 4:37 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable