Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F18245377: D20374.diff
Thu, Aug 21, 9:39 AM
F18245204: D20374.diff
Thu, Aug 21, 9:13 AM
F18245149: D20374.diff
Thu, Aug 21, 9:06 AM
F18245128: D20374.diff
Thu, Aug 21, 9:00 AM
F18244925: D20374.diff
Thu, Aug 21, 8:40 AM
F18244583: D20374.diff
Thu, Aug 21, 7:28 AM
F18244547: D20374.diff
Thu, Aug 21, 7:22 AM
F18244518: D20374.diff
Thu, Aug 21, 7:13 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable