Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F22727615: D20374.id48599.diff
Sun, Oct 4, 4:03 AM
F22658933: D20374.id48640.diff
Thu, Oct 1, 7:16 AM
F22658931: D20374.id48599.diff
Thu, Oct 1, 7:16 AM
F22658929: D20374.id.diff
Thu, Oct 1, 7:16 AM
F22656305: D20374.diff
Thu, Oct 1, 3:53 AM
F22523328: D20374.id48640.diff
Sun, Sep 20, 9:00 PM
F22512376: D20374.diff
Sat, Sep 19, 4:18 AM
Unknown Object (File)
Sep 1 2026, 9:25 AM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable