Page MenuHomePhabricator

Make "Favorites" work more like other customizable menus
ClosedPublic

Authored by epriestley on Apr 2 2019, 8:55 PM.
Tags
None
Referenced Files
F17799388: D20374.diff
Fri, Jul 25, 4:58 AM
F17751952: D20374.id.diff
Tue, Jul 22, 6:17 AM
F17727133: D20374.id.diff
Sat, Jul 19, 12:37 AM
F17726699: D20374.id48640.diff
Fri, Jul 18, 4:26 PM
F17719242: D20374.diff
Fri, Jul 18, 3:31 AM
F17701297: D20374.id48599.diff
Tue, Jul 15, 9:29 PM
Unknown Object (File)
Jul 5 2025, 7:38 AM
Unknown Object (File)
Jun 15 2025, 11:52 PM
Subscribers
None

Details

Summary

Depends on D20373. Ref T13272. When you put Dashboards in Favorites, the render without a navigation menu, which is kind of weird.

Instead, make Favorites display a navigation menu. This effectively turns it into a weird cross between the home page and a portal, but so be it.

Also change the icon from "star" to "bookmark" since I think that a clearer hint about how it works.

Test Plan

Viewed dashboards in favorites, got a navigation menu. Edited items from portals, home, favorites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable