Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F14061799: D20360.diff
Mon, Nov 18, 8:38 AM
F14046045: D20360.diff
Wed, Nov 13, 5:28 PM
F14037364: D20360.diff
Sun, Nov 10, 3:27 PM
F14036295: D20360.diff
Sun, Nov 10, 9:35 AM
F14019593: D20360.diff
Tue, Nov 5, 10:52 PM
F13999211: D20360.id48580.diff
Thu, Oct 24, 1:28 PM
F13985963: D20360.id48611.diff
Sun, Oct 20, 11:51 PM
F13977504: D20360.id48611.diff
Oct 18 2024, 6:54 PM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable