Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F19528841: D20360.diff
Mon, Jan 19, 12:11 PM
F19506043: D20360.diff
Fri, Jan 9, 4:18 PM
F19458850: D20360.diff
Fri, Jan 2, 3:49 PM
F19304508: D20360.diff
Wed, Dec 24, 12:05 PM
F19067145: D20360.diff
Nov 30 2025, 7:05 AM
F19061933: D20360.id48611.diff
Nov 29 2025, 2:04 PM
F19061932: D20360.id48580.diff
Nov 29 2025, 2:04 PM
F19061768: D20360.diff
Nov 29 2025, 1:26 PM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable