Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Sun, Mar 31, 9:28 PM.

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sun, Mar 31, 9:28 PM
epriestley requested review of this revision.Sun, Mar 31, 9:30 PM
amckinley accepted this revision.Mon, Apr 1, 6:11 PM
This revision is now accepted and ready to land.Mon, Apr 1, 6:11 PM
This revision was automatically updated to reflect the committed changes.