Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F15509758: D20360.diff
Wed, Apr 16, 3:54 PM
F15490803: D20360.id48611.diff
Fri, Apr 11, 8:40 PM
F15490618: D20360.id48580.diff
Fri, Apr 11, 6:58 PM
F15488287: D20360.id.diff
Thu, Apr 10, 8:58 PM
F15482708: D20360.diff
Wed, Apr 9, 7:27 AM
F15454881: D20360.diff
Sat, Mar 29, 9:00 PM
F15449939: D20360.id.diff
Fri, Mar 28, 1:03 PM
F15411951: D20360.id48611.diff
Mar 19 2025, 10:29 AM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable