Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F18518615: D20360.diff
Fri, Sep 5, 3:26 PM
F18459847: D20360.diff
Mon, Sep 1, 6:08 PM
F18424322: D20360.id.diff
Sat, Aug 30, 8:48 PM
F18390329: D20360.diff
Fri, Aug 29, 6:49 AM
F18245482: D20360.diff
Thu, Aug 21, 9:57 AM
F18245452: D20360.diff
Thu, Aug 21, 9:52 AM
F18245323: D20360.diff
Thu, Aug 21, 9:30 AM
F18245288: D20360.diff
Thu, Aug 21, 9:26 AM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable