Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F15411951: D20360.id48611.diff
Wed, Mar 19, 10:29 AM
F15391677: D20360.diff
Sat, Mar 15, 11:02 AM
F15340632: D20360.diff
Sun, Mar 9, 3:56 PM
Unknown Object (File)
Sun, Mar 2, 6:54 AM
Unknown Object (File)
Feb 15 2025, 6:45 PM
Unknown Object (File)
Feb 15 2025, 2:36 AM
Unknown Object (File)
Feb 15 2025, 2:36 AM
Unknown Object (File)
Feb 14 2025, 5:43 PM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable