Page MenuHomePhabricator

Make Portals reachable without knowing the URI
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:52 PM.

Details

Summary

Depends on D20360. Ref T13275. This makes the "Dashboards" application start on a Drydock-like console page where you pick portals, dashboards, or panels.

Probably the "Dashboards" application should either be renamed to "IntelliknowledgePro" or Portals should be split off into a separate application eventually, but let's see how things go like this for now, since restructuring probably breaks some URIs at least a little bit so I'd like more confidence that we're headed in the right direction before we do it.

Test Plan
  • Visited Dashboards via typeahead, got options for Dashboards/Portals/Panels.
  • Visited Portals pages, got simplified crumbs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 31 2019, 9:52 PM
epriestley requested review of this revision.Mar 31 2019, 9:54 PM
epriestley edited the summary of this revision. (Show Details)Mar 31 2019, 9:54 PM
amckinley accepted this revision.Apr 2 2019, 9:02 PM
amckinley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php
26–28

needz moar flav0r

This revision is now accepted and ready to land.Apr 2 2019, 9:02 PM
This revision was automatically updated to reflect the committed changes.