Page MenuHomePhabricator

When a dropdown menu would render in a way that hides it offscreen, try a different alignment
ClosedPublic

Authored by epriestley on Mon, Apr 8, 5:31 PM.

Details

Summary

Depends on D20382. Ref T13272. When something near the edge of the screen has a dropdown menu, we currently may render the menu offscreen.

Instead, keep the menu onscreen.

(This is happening because I'm adding dropdown menus to tab query panels.)

Test Plan

Before:

After:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Apr 8, 5:31 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Apr 8, 5:33 PM
Harbormaster failed remote builds in B22503: Diff 48628!
epriestley updated this revision to Diff 48629.Tue, Apr 9, 7:36 PM
  • Fix Celerity map.
epriestley requested review of this revision.Tue, Apr 9, 7:38 PM
amckinley accepted this revision.Tue, Apr 9, 7:49 PM
This revision is now accepted and ready to land.Tue, Apr 9, 7:49 PM
This revision was automatically updated to reflect the committed changes.