Differential D20383

When a dropdown menu would render in a way that hides it offscreen, try a different alignment
ClosedPublic
Actions

Authored by epriestley on Apr 8 2019, 5:31 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPe4524d470711: When a dropdown menu would render in a way that hides it offscreen, try a…

Summary

Depends on D20382. Ref T13272. When something near the edge of the screen has a dropdown menu, we currently may render the menu offscreen.

Instead, keep the menu onscreen.

(This is happening because I'm adding dropdown menus to tab query panels.)

Test Plan

Before:

Screen Shot 2019-04-08 at 10.29.37 AM.png (267×389 px, 22 KB)

After:

Screen Shot 2019-04-08 at 10.29.19 AM.png (279×383 px, 28 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 8 2019, 5:31 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 8 2019, 5:33 PM

Harbormaster failed remote builds in B22503: Diff 48628!

Fix Celerity map.

Harbormaster completed remote builds in B22504: Diff 48629.Apr 9 2019, 7:38 PM

epriestley requested review of this revision.Apr 9 2019, 7:38 PM

amckinley accepted this revision.Apr 9 2019, 7:49 PM

This revision is now accepted and ready to land.Apr 9 2019, 7:49 PM

epriestley added a child revision: D20384: Rebuild Dashboards on EditEngine: v1 Major Jank Edition.Apr 9 2019, 8:02 PM

Closed by commit rPe4524d470711: When a dropdown menu would render in a way that hides it offscreen, try a… (authored by epriestley). · Explain WhyApr 9 2019, 9:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

phuix/

PHUIXDropdownMenu.js

30 lines

Diff 48645

View Options

resources/celerity/map.php