Page MenuHomePhabricator

When a dropdown menu would render in a way that hides it offscreen, try a different alignment

Authored by epriestley on Apr 8 2019, 5:31 PM.



Depends on D20382. Ref T13272. When something near the edge of the screen has a dropdown menu, we currently may render the menu offscreen.

Instead, keep the menu onscreen.

(This is happening because I'm adding dropdown menus to tab query panels.)

Test Plan



Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 8 2019, 5:31 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 8 2019, 5:33 PM
Harbormaster failed remote builds in B22503: Diff 48628!
epriestley updated this revision to Diff 48629.Apr 9 2019, 7:36 PM
  • Fix Celerity map.
epriestley requested review of this revision.Apr 9 2019, 7:38 PM
amckinley accepted this revision.Apr 9 2019, 7:49 PM
This revision is now accepted and ready to land.Apr 9 2019, 7:49 PM
This revision was automatically updated to reflect the committed changes.