Page MenuHomePhabricator

Allow Portals to be edited, and improve empty/blank states
ClosedPublic

Authored by epriestley on Mar 29 2019, 10:13 PM.
Tags
None
Referenced Files
F18765853: D20349.id.diff
Tue, Oct 7, 1:25 PM
F18597885: D20349.diff
Sat, Sep 13, 3:53 AM
F18518587: D20349.diff
Sep 5 2025, 3:23 PM
F18245372: D20349.diff
Aug 21 2025, 9:38 AM
F18245289: D20349.diff
Aug 21 2025, 9:26 AM
F18245240: D20349.diff
Aug 21 2025, 9:19 AM
F18245153: D20349.diff
Aug 21 2025, 9:06 AM
F18245110: D20349.diff
Aug 21 2025, 8:57 AM
Subscribers
None

Details

Summary

Depends on D20348. Ref T13275. Portals are mostly just a "ProfileMenuEngine" menu, and that code is already relatively modular/flexible, so set that up to start with.

The stuff it gets wrong right now is mostly around empty/no-permission states, since the original use cases (project menus) didn't have any of these states: it's not possible to have a project menu with no content.

Let the engine render an "empty" state (when there are no items that can render a content page) and try to make some of the empty behavior a little more user-friendly.

This mostly makes portals work, more or less.

Test Plan

Screen Shot 2019-03-29 at 3.03.39 PM.png (910×1 px, 288 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable