Page MenuHomePhabricator

Allow Portals to be edited, and improve empty/blank states
ClosedPublic

Authored by epriestley on Mar 29 2019, 10:13 PM.
Tags
None
Referenced Files
F15419930: D20349.id48603.diff
Fri, Mar 21, 9:57 AM
F15383762: D20349.id.diff
Fri, Mar 14, 5:51 PM
F15335119: D20349.id48603.diff
Sat, Mar 8, 2:23 PM
F15284884: D20349.diff
Tue, Mar 4, 10:52 AM
Unknown Object (File)
Mon, Feb 24, 2:34 AM
Unknown Object (File)
Sat, Feb 22, 3:56 PM
Unknown Object (File)
Feb 14 2025, 10:48 PM
Unknown Object (File)
Feb 14 2025, 10:48 PM
Subscribers
None

Details

Summary

Depends on D20348. Ref T13275. Portals are mostly just a "ProfileMenuEngine" menu, and that code is already relatively modular/flexible, so set that up to start with.

The stuff it gets wrong right now is mostly around empty/no-permission states, since the original use cases (project menus) didn't have any of these states: it's not possible to have a project menu with no content.

Let the engine render an "empty" state (when there are no items that can render a content page) and try to make some of the empty behavior a little more user-friendly.

This mostly makes portals work, more or less.

Test Plan

Screen Shot 2019-03-29 at 3.03.39 PM.png (910×1 px, 288 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable