Page MenuHomePhabricator

Allow Portals to be edited, and improve empty/blank states
ClosedPublic

Authored by epriestley on Mar 29 2019, 10:13 PM.

Details

Summary

Depends on D20348. Ref T13275. Portals are mostly just a "ProfileMenuEngine" menu, and that code is already relatively modular/flexible, so set that up to start with.

The stuff it gets wrong right now is mostly around empty/no-permission states, since the original use cases (project menus) didn't have any of these states: it's not possible to have a project menu with no content.

Let the engine render an "empty" state (when there are no items that can render a content page) and try to make some of the empty behavior a little more user-friendly.

This mostly makes portals work, more or less.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 29 2019, 10:13 PM
epriestley requested review of this revision.Mar 29 2019, 10:14 PM
amckinley accepted this revision.Apr 1 2019, 5:50 PM
This revision is now accepted and ready to land.Apr 1 2019, 5:50 PM
This revision was automatically updated to reflect the committed changes.