Page MenuHomePhabricator

Allow Portals to be edited, and improve empty/blank states
ClosedPublic

Authored by epriestley on Mar 29 2019, 10:13 PM.
Tags
None
Referenced Files
F19597912: D20349.id48565.diff
Mon, Feb 2, 10:01 PM
F19515948: D20349.diff
Wed, Jan 14, 5:44 PM
F19515946: D20349.diff
Wed, Jan 14, 5:42 PM
F19515942: D20349.diff
Wed, Jan 14, 5:38 PM
F19515941: D20349.diff
Wed, Jan 14, 5:38 PM
F19515939: D20349.diff
Wed, Jan 14, 5:36 PM
F19515913: D20349.diff
Wed, Jan 14, 5:32 PM
F19515908: D20349.diff
Wed, Jan 14, 5:26 PM
Subscribers
None

Details

Summary

Depends on D20348. Ref T13275. Portals are mostly just a "ProfileMenuEngine" menu, and that code is already relatively modular/flexible, so set that up to start with.

The stuff it gets wrong right now is mostly around empty/no-permission states, since the original use cases (project menus) didn't have any of these states: it's not possible to have a project menu with no content.

Let the engine render an "empty" state (when there are no items that can render a content page) and try to make some of the empty behavior a little more user-friendly.

This mostly makes portals work, more or less.

Test Plan

Screen Shot 2019-03-29 at 3.03.39 PM.png (910×1 px, 288 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable