Page MenuHomePhabricator

In ProfileMenu, put more structure between "stored/configured items" and "display items"
ClosedPublic

Authored by epriestley on Sun, Mar 31, 7:05 PM.

Details

Summary

Depends on D20356. Ref T13275. See also T12871 and T12949.

Currently, the whole "ProfileMenu" API operates around stored items. However, stored items are allowed to produce zero or more display items, and we sometimes want to highlight display item X but render stored item Y (as is the case with "Link" items pointing at ?filter=xyz on Workboards).

For the most part, this either: doesn't work; or works by chance; or is kind of glued together with hope and prayer (as in D20353).

Put an actual structural layer in place between "stored/configured item" and "display item" that can link them together more clearly. Now:

  • The list of ItemConfiguration objects (stored/configured items) is used to build an ItemViewList.
  • This handles the selection/highlighting/default state, and knows which display items are related to which stored items.
  • When we're all done figuring out what we're going to select and what we're going to highlight, it pops out an actual View which can build the HTML.

This requires API changes which are not included in this change, see next change.

This doesn't really do anything on its own, but builds toward a more satisfying fix for T12871. I'd hoped to avoid doing this for now, but wasn't able to get a patch I felt good about for T12871 built without fixing this first.

Test Plan

See next change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sun, Mar 31, 7:05 PM
epriestley requested review of this revision.Sun, Mar 31, 7:06 PM
amckinley accepted this revision.Mon, Apr 1, 10:05 PM
This revision is now accepted and ready to land.Mon, Apr 1, 10:05 PM
This revision was automatically updated to reflect the committed changes.