Page MenuHomePhabricator

Put "workflow" on Dashboard edit links when they're disabled
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:12 PM.
Tags
None
Referenced Files
F15579812: D20368.diff
Wed, May 7, 1:46 AM
F15524482: D20368.diff
Mon, Apr 21, 8:16 AM
F15487824: D20368.id.diff
Thu, Apr 10, 5:08 PM
F15483208: D20368.diff
Apr 9 2025, 10:43 AM
F15471362: D20368.diff
Apr 5 2025, 4:41 AM
F15460733: D20368.id.diff
Apr 1 2025, 1:38 AM
F15421469: D20368.diff
Mar 22 2025, 12:03 AM
F15393158: D20368.id48593.diff
Mar 15 2025, 8:07 PM
Subscribers
None

Details

Summary

Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.

These actions are implemented in a nonstandard way; standardize them.

Test Plan

Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable