Page MenuHomePhabricator

Put "workflow" on Dashboard edit links when they're disabled
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:12 PM.

Details

Summary

Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.

These actions are implemented in a nonstandard way; standardize them.

Test Plan

Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 4:12 PM
epriestley requested review of this revision.Apr 2 2019, 4:13 PM
amckinley accepted this revision.Apr 3 2019, 6:44 PM
This revision is now accepted and ready to land.Apr 3 2019, 6:44 PM
This revision was automatically updated to reflect the committed changes.