Differential D20368

Put "workflow" on Dashboard edit links when they're disabled
ClosedPublic
Actions

Authored by epriestley on Apr 2 2019, 4:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPf504f40ee581: Put "workflow" on Dashboard edit links when they're disabled

Summary

Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.

These actions are implemented in a nonstandard way; standardize them.

Test Plan

Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 4:12 PM

Harbormaster completed remote builds in B22467: Diff 48593.Apr 2 2019, 4:13 PM

epriestley requested review of this revision.Apr 2 2019, 4:13 PM

epriestley added a child revision: D20369: Move Dashboard panel controllers into a "panel/" subdirectory.Apr 2 2019, 4:17 PM

amckinley accepted this revision.Apr 3 2019, 6:44 PM

This revision is now accepted and ready to land.Apr 3 2019, 6:44 PM

Closed by commit rPf504f40ee581: Put "workflow" on Dashboard edit links when they're disabled (authored by epriestley). · Explain WhyApr 9 2019, 8:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48593	cda9a72		Apr 2 2019, 4:12 PM	★	★
Diff 2	48634	5b38d21	rPf504f40ee581389c295ae2bb17c865346663d67b	Apr 9 2019, 8:35 PM	★	★

Status	Author	Revision
Closed	epriestley	D20385 Fix some overlooked profile menu construction callsites
Closed	epriestley	D20384 Rebuild Dashboards on EditEngine: v1 Major Jank Edition
Closed	epriestley	D20383 When a dropdown menu would render in a way that hides it offscreen, try a different alignment
Closed	epriestley	D20382 Rebuild query panels on top of EditEngine
Closed	epriestley	D20377 When a dashboard has inconsistent panel policies: keep doing nothing
Closed	epriestley	D20376 On Dashboards, distinguish between invalid panels and restricted panels
Closed	epriestley	D20374 Make "Favorites" work more like other customizable menus
Closed	epriestley	D20373 Make the Dashboard dropshadow a little lighter and turn panel management into a menu
Closed	epriestley	D20372 Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
Closed	epriestley	D20371 Mostly replace the old panel "Edit" controller with the new "Editpro" controller
Closed	epriestley	D20370 Modularize Dashboard Panel transactionns
Closed	epriestley	D20369 Move Dashboard panel controllers into a "panel/" subdirectory
Closed	epriestley	D20368 Put "workflow" on Dashboard edit links when they're disabled
Closed	epriestley	D20367 Remove the dashboard "template" workflow
Closed	epriestley	D20364 Make the "Install Dashboard" flow smoother
Closed	epriestley	D20362 Combine the "View", "Arrange", and "Manage" modes of Dashboards into a single mode
Closed	epriestley	D20361 Make Portals reachable without knowing the URI
Closed	epriestley	D20360 Fix the incorrect link target for "Create Revision" as a Menu Item
Closed	epriestley	D20359 When picking a default menu item to render, don't pick disabled items
Closed	epriestley	D20358 Update all existing ProfileMenuItems for the more-structured API
Closed	epriestley	D20357 In ProfileMenu, put more structure between "stored/configured items" and "display items"
Closed	epriestley	D20356 Automatically build mobile menus from navigation, and clean up external ProfileMenu API
Closed	epriestley	D20355 Allow profile menu items to be locked to the top or bottom of the menu
Closed	epriestley	D20353 When a ProfileMenu has a link item that adds URI parameters, highlight it when clicked
Closed	epriestley	D20352 On portals, make the "selected" / "default" logic more straightforward
Closed	epriestley	D20349 Allow Portals to be edited, and improve empty/blank states
Closed	epriestley	D20348 Add skeleton for Portals, a collection of dashboards and other resources

Diff 48634

View Options

src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php

Put "workflow" on Dashboard edit links when they're disabledClosedPublicActions