Differential D20368

Put "workflow" on Dashboard edit links when they're disabled
ClosedPublic
Actions

Authored by epriestley on Apr 2 2019, 4:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPf504f40ee581: Put "workflow" on Dashboard edit links when they're disabled

Summary

Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.

These actions are implemented in a nonstandard way; standardize them.

Test Plan

Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 4:12 PM

Harbormaster completed remote builds in B22467: Diff 48593.Apr 2 2019, 4:13 PM

epriestley requested review of this revision.Apr 2 2019, 4:13 PM

epriestley added a child revision: D20369: Move Dashboard panel controllers into a "panel/" subdirectory.Apr 2 2019, 4:17 PM

amckinley accepted this revision.Apr 3 2019, 6:44 PM

This revision is now accepted and ready to land.Apr 3 2019, 6:44 PM

Closed by commit rPf504f40ee581: Put "workflow" on Dashboard edit links when they're disabled (authored by epriestley). · Explain WhyApr 9 2019, 8:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

dashboard/

PhabricatorDashboardViewController.php

7 lines

Diff 48634

View Options

src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php

Put "workflow" on Dashboard edit links when they're disabledClosedPublicActions