Page MenuHomePhabricator

Put "workflow" on Dashboard edit links when they're disabled
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:12 PM.
Tags
None
Referenced Files
F18840979: D20368.id48634.diff
Tue, Oct 28, 5:37 AM
F18837167: D20368.id48634.diff
Mon, Oct 27, 4:36 AM
F18837165: D20368.id48593.diff
Mon, Oct 27, 4:35 AM
F18837164: D20368.id.diff
Mon, Oct 27, 4:35 AM
F18834139: D20368.diff
Sun, Oct 26, 6:57 AM
F18824690: D20368.id.diff
Thu, Oct 23, 5:23 PM
F18820157: D20368.diff
Wed, Oct 22, 12:53 PM
F18816101: D20368.id48634.diff
Tue, Oct 21, 4:56 AM
Subscribers
None

Details

Summary

Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.

These actions are implemented in a nonstandard way; standardize them.

Test Plan

Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable