Paths

Table of Contentst

Differential D20356

Automatically build mobile menus from navigation, and clean up external ProfileMenu API
ClosedPublic
Actions

Authored by epriestley on Mar 31 2019, 6:54 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13247: Mobile "Hamburger Menus" require explicit setup and are easy to get wrong by mistake
T13275: Build Portals: a standalone menu page / dashboard of dashboards

Commits

rP971a272bf679: Automatically build mobile menus from navigation, and clean up external…

Summary

Depends on D20355. Ref T13275. Ref T13247. Currently, "Hamburger" menus are not automatically built from navigation menus. However, this is (I'm almost completely sure?) a reasonable and appropriate default behavior, and saves us some code around profile menus.

With this rule in place, we can remove setApplicationMenu() and getApplicationMenu() from StandardPageView, since they have no callers.

This also updates a lot of profile menu callsites to a new API which is added in the next change.

Test Plan

See the next two changes.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 31 2019, 6:54 PM

Harbormaster completed remote builds in B22446: Diff 48573.Mar 31 2019, 6:56 PM

epriestley requested review of this revision.Mar 31 2019, 6:56 PM

Slightly cleaner diff.

Harbormaster completed remote builds in B22447: Diff 48574.Mar 31 2019, 6:58 PM

epriestley added a child revision: D20357: In ProfileMenu, put more structure between "stored/configured items" and "display items".Mar 31 2019, 7:05 PM

amckinley accepted this revision.Apr 1 2019, 9:04 PM

This revision is now accepted and ready to land.Apr 1 2019, 9:04 PM

Closed by commit rP971a272bf679: Automatically build mobile menus from navigation, and clean up external… (authored by epriestley). · Explain WhyApr 2 2019, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

favorites/

engineextension/

PhabricatorFavoritesMainMenuBarExtension.php

5 lines

home/

controller/

PhabricatorHomeController.php

44 lines

people/

controller/

PhabricatorPeopleProfileBadgesController.php

5 lines

PhabricatorPeopleProfileCommitsController.php

5 lines

PhabricatorPeopleProfileController.php

49 lines

PhabricatorPeopleProfileManageController.php

5 lines

PhabricatorPeopleProfileRevisionsController.php

5 lines

PhabricatorPeopleProfileTasksController.php

5 lines

PhabricatorPeopleProfileViewController.php

7 lines

project/

controller/

PhabricatorProjectBoardViewController.php

19 lines

PhabricatorProjectController.php

43 lines

PhabricatorProjectManageController.php

5 lines

PhabricatorProjectMembersViewController.php

5 lines

PhabricatorProjectProfileController.php

5 lines

PhabricatorProjectSubprojectsController.php

5 lines

PhabricatorProjectViewController.php

2 lines

search/

controller/

PhabricatorApplicationSearchController.php

2 lines

view/

page/

PhabricatorStandardPageView.php

29 lines

Diff 48607

src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php

Loading...

src/applications/home/controller/PhabricatorHomeController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileTasksController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectController.php

Loading...

src/applications/project/controller/PhabricatorProjectManageController.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...

src/applications/project/controller/PhabricatorProjectViewController.php

Loading...

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...

src/view/page/PhabricatorStandardPageView.php

Loading...