Page MenuHomePhabricator

Automatically build mobile menus from navigation, and clean up external ProfileMenu API
ClosedPublic

Authored by epriestley on Mar 31 2019, 6:54 PM.

Details

Summary

Depends on D20355. Ref T13275. Ref T13247. Currently, "Hamburger" menus are not automatically built from navigation menus. However, this is (I'm almost completely sure?) a reasonable and appropriate default behavior, and saves us some code around profile menus.

With this rule in place, we can remove setApplicationMenu() and getApplicationMenu() from StandardPageView, since they have no callers.

This also updates a lot of profile menu callsites to a new API which is added in the next change.

Test Plan

See the next two changes.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 31 2019, 6:54 PM
epriestley requested review of this revision.Mar 31 2019, 6:56 PM
epriestley updated this revision to Diff 48574.Mar 31 2019, 6:56 PM
  • Slightly cleaner diff.
amckinley accepted this revision.Apr 1 2019, 9:04 PM
This revision is now accepted and ready to land.Apr 1 2019, 9:04 PM
This revision was automatically updated to reflect the committed changes.