Differential D20356

Automatically build mobile menus from navigation, and clean up external ProfileMenu API
ClosedPublic
Actions

Authored by epriestley on Mar 31 2019, 6:54 PM.

Details

Reviewers

Maniphest Tasks

T13247: Mobile "Hamburger Menus" require explicit setup and are easy to get wrong by mistake
T13275: Build Portals: a standalone menu page / dashboard of dashboards

Commits

rP971a272bf679: Automatically build mobile menus from navigation, and clean up external…

Summary

Depends on D20355. Ref T13275. Ref T13247. Currently, "Hamburger" menus are not automatically built from navigation menus. However, this is (I'm almost completely sure?) a reasonable and appropriate default behavior, and saves us some code around profile menus.

With this rule in place, we can remove setApplicationMenu() and getApplicationMenu() from StandardPageView, since they have no callers.

This also updates a lot of profile menu callsites to a new API which is added in the next change.

Test Plan

See the next two changes.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 31 2019, 6:54 PM

Harbormaster completed remote builds in B22446: Diff 48573.Mar 31 2019, 6:56 PM

epriestley requested review of this revision.Mar 31 2019, 6:56 PM

Slightly cleaner diff.

Harbormaster completed remote builds in B22447: Diff 48574.Mar 31 2019, 6:58 PM

epriestley added a child revision: D20357: In ProfileMenu, put more structure between "stored/configured items" and "display items".Mar 31 2019, 7:05 PM

amckinley accepted this revision.Apr 1 2019, 9:04 PM

This revision is now accepted and ready to land.Apr 1 2019, 9:04 PM

Closed by commit rP971a272bf679: Automatically build mobile menus from navigation, and clean up external… (authored by epriestley). · Explain WhyApr 2 2019, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php (5 lines)
M			src/applications/home/controller/PhabricatorHomeController.php (44 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php (5 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php (5 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileController.php (49 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileManageController.php (5 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php (5 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileTasksController.php (5 lines)
M			src/applications/people/controller/PhabricatorPeopleProfileViewController.php (7 lines)
M			src/applications/project/controller/PhabricatorProjectBoardViewController.php (19 lines)
M			src/applications/project/controller/PhabricatorProjectController.php (43 lines)
M			src/applications/project/controller/PhabricatorProjectManageController.php (5 lines)
M			src/applications/project/controller/PhabricatorProjectMembersViewController.php (5 lines)
M			src/applications/project/controller/PhabricatorProjectProfileController.php (5 lines)
M			src/applications/project/controller/PhabricatorProjectSubprojectsController.php (5 lines)
M			src/applications/project/controller/PhabricatorProjectViewController.php (2 lines)
M			src/applications/search/controller/PhabricatorApplicationSearchController.php (2 lines)
M			src/view/page/PhabricatorStandardPageView.php (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48573	f52adf9		Mar 31 2019, 6:54 PM	★	★
Diff 2	48574	f52adf9	- Slightly cleaner diff.	Mar 31 2019, 6:56 PM	★	★
Diff 3	48607	47bf382	rP971a272bf679979ef9cc638c3113c98d2fefb186	Apr 2 2019, 10:17 PM	★	★

Status	Author	Revision
Closed	epriestley	D20385 Fix some overlooked profile menu construction callsites
Closed	epriestley	D20384 Rebuild Dashboards on EditEngine: v1 Major Jank Edition
Closed	epriestley	D20383 When a dropdown menu would render in a way that hides it offscreen, try a different alignment
Closed	epriestley	D20382 Rebuild query panels on top of EditEngine
Closed	epriestley	D20377 When a dashboard has inconsistent panel policies: keep doing nothing
Closed	epriestley	D20376 On Dashboards, distinguish between invalid panels and restricted panels
Closed	epriestley	D20374 Make "Favorites" work more like other customizable menus
Closed	epriestley	D20373 Make the Dashboard dropshadow a little lighter and turn panel management into a menu
Closed	epriestley	D20372 Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
Closed	epriestley	D20371 Mostly replace the old panel "Edit" controller with the new "Editpro" controller
Closed	epriestley	D20370 Modularize Dashboard Panel transactionns
Closed	epriestley	D20369 Move Dashboard panel controllers into a "panel/" subdirectory
Closed	epriestley	D20368 Put "workflow" on Dashboard edit links when they're disabled
Closed	epriestley	D20367 Remove the dashboard "template" workflow
Closed	epriestley	D20364 Make the "Install Dashboard" flow smoother
Closed	epriestley	D20362 Combine the "View", "Arrange", and "Manage" modes of Dashboards into a single mode
Closed	epriestley	D20361 Make Portals reachable without knowing the URI
Closed	epriestley	D20360 Fix the incorrect link target for "Create Revision" as a Menu Item
Closed	epriestley	D20359 When picking a default menu item to render, don't pick disabled items
Closed	epriestley	D20358 Update all existing ProfileMenuItems for the more-structured API
Closed	epriestley	D20357 In ProfileMenu, put more structure between "stored/configured items" and "display items"
Closed	epriestley	D20356 Automatically build mobile menus from navigation, and clean up external ProfileMenu API
Closed	epriestley	D20355 Allow profile menu items to be locked to the top or bottom of the menu
Closed	epriestley	D20353 When a ProfileMenu has a link item that adds URI parameters, highlight it when clicked
Closed	epriestley	D20352 On portals, make the "selected" / "default" logic more straightforward
Closed	epriestley	D20349 Allow Portals to be edited, and improve empty/blank states
Closed	epriestley	D20348 Add skeleton for Portals, a collection of dashboards and other resources

Automatically build mobile menus from navigation, and clean up external ProfileMenu APIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48607

src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php

src/applications/home/controller/PhabricatorHomeController.php

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php

src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php

src/applications/people/controller/PhabricatorPeopleProfileController.php

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

src/applications/people/controller/PhabricatorPeopleProfileTasksController.php

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

src/applications/project/controller/PhabricatorProjectBoardViewController.php

src/applications/project/controller/PhabricatorProjectController.php

src/applications/project/controller/PhabricatorProjectManageController.php

src/applications/project/controller/PhabricatorProjectMembersViewController.php

src/applications/project/controller/PhabricatorProjectProfileController.php

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

src/applications/project/controller/PhabricatorProjectViewController.php

src/applications/search/controller/PhabricatorApplicationSearchController.php

src/view/page/PhabricatorStandardPageView.php

Automatically build mobile menus from navigation, and clean up external ProfileMenu API
ClosedPublic
Actions

Revision Contents
Changeset List