Page MenuHomePhabricator

Automatically build mobile menus from navigation, and clean up external ProfileMenu API
ClosedPublic

Authored by epriestley on Mar 31 2019, 6:54 PM.
Tags
None
Referenced Files
F17803445: D20356.id.diff
Fri, Jul 25, 10:12 AM
F17800385: D20356.id48607.diff
Fri, Jul 25, 6:25 AM
F17763059: D20356.diff
Tue, Jul 22, 10:56 PM
F17745644: D20356.id48574.diff
Mon, Jul 21, 6:34 PM
F17712013: D20356.diff
Thu, Jul 17, 9:22 AM
Unknown Object (File)
Sun, Jun 29, 5:25 AM
Unknown Object (File)
Jun 19 2025, 3:27 AM
Unknown Object (File)
Jun 17 2025, 10:14 AM
Subscribers
None

Details

Summary

Depends on D20355. Ref T13275. Ref T13247. Currently, "Hamburger" menus are not automatically built from navigation menus. However, this is (I'm almost completely sure?) a reasonable and appropriate default behavior, and saves us some code around profile menus.

With this rule in place, we can remove setApplicationMenu() and getApplicationMenu() from StandardPageView, since they have no callers.

This also updates a lot of profile menu callsites to a new API which is added in the next change.

Test Plan

See the next two changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable