Page MenuHomePhabricator

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
ClosedPublic

Authored by epriestley on Apr 2 2019, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 3:41 AM
Unknown Object (File)
Sun, Dec 29, 8:01 AM
Unknown Object (File)
Sat, Dec 28, 3:25 PM
Unknown Object (File)
Dec 17 2024, 10:21 AM
Unknown Object (File)
Dec 12 2024, 6:21 PM
Unknown Object (File)
Dec 11 2024, 9:24 AM
Unknown Object (File)
Nov 28 2024, 3:50 AM
Unknown Object (File)
Nov 20 2024, 8:37 AM
Subscribers
None

Details

Summary

Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan

Created and edited a "text" panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable