Page MenuHomePhabricator

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
ClosedPublic

Authored by epriestley on Apr 2 2019, 6:59 PM.
Tags
None
Referenced Files
F18623599: D20372.diff
Mon, Sep 15, 4:33 PM
F18612681: D20372.diff
Sun, Sep 14, 9:42 AM
F18518643: D20372.diff
Sep 5 2025, 3:30 PM
F18334715: D20372.id48638.diff
Aug 25 2025, 5:30 AM
F18331699: D20372.diff
Aug 25 2025, 2:29 AM
F18329186: D20372.id48597.diff
Aug 25 2025, 12:11 AM
F18328481: D20372.diff
Aug 24 2025, 11:37 PM
F18245448: D20372.diff
Aug 21 2025, 9:49 AM
Subscribers
None

Details

Summary

Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan

Created and edited a "text" panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable