Page MenuHomePhabricator

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
ClosedPublic

Authored by epriestley on Apr 2 2019, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 25 2022, 8:18 AM
Unknown Object (File)
Dec 19 2022, 8:28 AM
Unknown Object (File)
Dec 6 2022, 6:38 PM
Unknown Object (File)
Dec 6 2022, 6:38 PM
Unknown Object (File)
Dec 6 2022, 6:37 PM
Unknown Object (File)
Nov 20 2022, 7:32 AM
Unknown Object (File)
Nov 14 2022, 6:55 AM
Unknown Object (File)
Nov 14 2022, 4:50 AM
Subscribers
None

Details

Summary

Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan

Created and edited a "text" panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable