Page MenuHomePhabricator

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior
ClosedPublic

Authored by epriestley on Tue, Apr 2, 6:59 PM.

Details

Summary

Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan

Created and edited a "text" panel.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.