Differential D20382

Rebuild query panels on top of EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 8 2019, 5:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP41afc7c7e612: Rebuild query panels on top of EditEngine

Summary

Depends on D20377. Ref T13272. In D20372, I temporarily removed the controls for actually editing Query panels. Restore them.

Test Plan

Viewed existing Query panels, saw them working like they did before.
Created and edited Query panels.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 8 2019, 5:12 PM

Harbormaster completed remote builds in B22502: Diff 48627.Apr 8 2019, 5:13 PM

epriestley requested review of this revision.Apr 8 2019, 5:13 PM

epriestley added a child revision: D20383: When a dropdown menu would render in a way that hides it offscreen, try a different alignment.Apr 8 2019, 5:31 PM

amckinley accepted this revision.Apr 9 2019, 7:49 PM

This revision is now accepted and ready to land.Apr 9 2019, 7:49 PM

Closed by commit rP41afc7c7e612: Rebuild query panels on top of EditEngine (authored by epriestley). · Explain WhyApr 9 2019, 9:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

dashboard/

editfield/

PhabricatorDashboardQueryPanelApplicationEditField.php

59 lines

PhabricatorDashboardQueryPanelQueryEditField.php

77 lines

paneltype/

PhabricatorDashboardQueryPanelType.php

25 lines

xaction/

panel/

PhabricatorDashboardQueryPanelApplicationTransaction.php

12 lines

PhabricatorDashboardQueryPanelQueryTransaction.php

12 lines

Diff 48644

View Options

src/__phutil_library_map__.php

View Options

src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelApplicationEditField.php

View Options

src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelQueryTransaction.php

Rebuild query panels on top of EditEngineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48644

src/__phutil_library_map__.php

src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelApplicationEditField.php

src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelQueryTransaction.php

Rebuild query panels on top of EditEngine
ClosedPublic
Actions

Revision Contents
Changeset List