Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F14838598: D20360.id48580.diff
Fri, Jan 31, 4:58 PM
Unknown Object (File)
Tue, Jan 28, 5:06 AM
Unknown Object (File)
Tue, Jan 28, 5:06 AM
Unknown Object (File)
Tue, Jan 28, 5:06 AM
Unknown Object (File)
Sun, Jan 26, 6:32 PM
Unknown Object (File)
Sat, Jan 25, 4:24 PM
Unknown Object (File)
Sat, Jan 25, 4:33 AM
Unknown Object (File)
Sat, Jan 25, 4:33 AM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable