Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 5, 8:54 AM
Unknown Object (File)
Thu, Jun 19, 12:50 AM
Unknown Object (File)
Wed, Jun 18, 7:38 PM
Unknown Object (File)
Wed, Jun 18, 4:39 AM
Unknown Object (File)
Wed, Jun 18, 4:39 AM
Unknown Object (File)
Jun 16 2025, 7:55 AM
Unknown Object (File)
May 9 2025, 1:48 PM
Unknown Object (File)
May 9 2025, 4:47 AM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable