Page MenuHomePhabricator

Fix the incorrect link target for "Create Revision" as a Menu Item
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:28 PM.
Tags
None
Referenced Files
F13050691: D20360.diff
Fri, Apr 19, 3:07 AM
Unknown Object (File)
Wed, Apr 17, 3:18 PM
Unknown Object (File)
Wed, Apr 17, 3:08 PM
Unknown Object (File)
Thu, Apr 11, 7:18 AM
Unknown Object (File)
Sun, Apr 7, 9:43 AM
Unknown Object (File)
Mon, Apr 1, 11:08 AM
Unknown Object (File)
Sun, Mar 31, 8:13 PM
Unknown Object (File)
Mon, Mar 25, 7:48 AM
Subscribers
None

Details

Summary

Depends on D20359. Fixes T12098. When you add a new "Form" item and pick "Create Revision", you currently get a bad link. This is because Differential is kind of special and the form isn't usable directly, even though Differential does use EditEngine.

Allow EditEngine to specify a different create URI, then specify the web UI paste-a-diff flow to fix this.

Test Plan
  • Added "Create Revision" to a portal, clicked it, was sensibly put on the diff flow.
  • Grepped for getCreateURI(), the only other real use case is to render the "Create X" dropdowns in the upper right.
    • Clicked one of those, still worked great.

Diff Detail

Repository
rP Phabricator
Branch
portal10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22453
Build 30735: Run Core Tests
Build 30734: arc lint + arc unit