Paths

Table of Contentst

Differential D20364

Make the "Install Dashboard" flow smoother
ClosedPublic
Actions

Authored by epriestley on Apr 1 2019, 8:10 PM.

Tags

None

Referenced Files

	F13253977: D20364.diff
	Sat, May 25, 3:04 AM

	F13232421: D20364.diff
	Tue, May 21, 1:16 AM

	F13216140: D20364.id48619.diff
	Fri, May 17, 10:34 PM

	F13187186: D20364.diff
	Sat, May 11, 4:23 AM

	F13183242: D20364.id48632.diff
	Fri, May 10, 7:45 AM

	Unknown Object (File)
	Tue, May 7, 7:29 AM

	Unknown Object (File)
	Sun, May 5, 7:46 PM

	Unknown Object (File)
	Fri, May 3, 6:22 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP12b922438746: Make the "Install Dashboard" flow smoother

Summary

Depends on D20362. Ref T13272. Currently, Dashboards have an "Install Dashboard" flow which is pretty janky and only allows you to install things to the home page.

Instead, allow users to install things to any valid target (home, favorites, portals, projects). This also provides URIs like dashboard/install/1/home/personal/ which allow you to link users to an "install a dashboard" page; this may or may not get used.

Test Plan

Installed dashboards on home, favorites, projects, and portals.

Diff Detail

Repository

Branch

portal13

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/dashboard/typeahead/PhabricatorDashboardPortalDatasource.php:30	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 22457
Build 30743: Run Core Tests
Build 30742: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 1 2019, 8:10 PM

Harbormaster completed remote builds in B22457: Diff 48584.Apr 1 2019, 8:12 PM

epriestley requested review of this revision.Apr 1 2019, 8:12 PM

Screen Shot 2019-04-01 at 1.02.50 PM.png (980×1 px, 250 KB)

epriestley added a child revision: D20367: Remove the dashboard "template" workflow.Apr 2 2019, 4:06 PM

amckinley accepted this revision.Apr 3 2019, 6:37 PM

amckinley added inline comments.

src/applications/search/menuitem/PhabricatorProfileMenuItem.php
91–92	Debugging code.

This revision is now accepted and ready to land.Apr 3 2019, 6:37 PM

Remove debugging code.

Harbormaster completed remote builds in B22494: Diff 48619.Apr 4 2019, 2:42 PM

Closed by commit rP12b922438746: Make the "Install Dashboard" flow smoother (authored by epriestley). · Explain WhyApr 9 2019, 8:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

__phutil_library_map__.php

applications/

dashboard/

application/

PhabricatorDashboardApplication.php

5 lines

controller/

dashboard/

PhabricatorDashboardInstallController.php

159 lines

PhabricatorDashboardViewController.php

2 lines

install/

PhabricatorDashboardApplicationInstallWorkflow.php

58 lines

PhabricatorDashboardFavoritesInstallWorkflow.php

85 lines

PhabricatorDashboardHomeInstallWorkflow.php

83 lines

PhabricatorDashboardInstallWorkflow.php

143 lines

PhabricatorDashboardObjectInstallWorkflow.php

99 lines

PhabricatorDashboardPortalInstallWorkflow.php

62 lines

PhabricatorDashboardProjectInstallWorkflow.php

63 lines

typeahead/

PhabricatorDashboardPortalDatasource.php

47 lines

project/

menuitem/

PhabricatorProjectPointsProfileMenuItem.php

5 lines

search/

menuitem/

PhabricatorProfileMenuItem.php

8 lines

view/

phui/

PHUIObjectItemView.php

2 lines

webroot/

rsrc/

css/

phui/

object-item/

phui-oi-big-ui.css

20 lines

Diff 48584

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/application/PhabricatorDashboardApplication.php

Loading...

src/applications/dashboard/controller/dashboard/PhabricatorDashboardInstallController.php

Loading...

src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardApplicationInstallWorkflow.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardFavoritesInstallWorkflow.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardHomeInstallWorkflow.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardInstallWorkflow.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardPortalInstallWorkflow.php

Loading...

src/applications/dashboard/install/PhabricatorDashboardProjectInstallWorkflow.php

Loading...

src/applications/dashboard/typeahead/PhabricatorDashboardPortalDatasource.php

Loading...

src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorProfileMenuItem.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

webroot/rsrc/css/phui/object-item/phui-oi-big-ui.css

Loading...