Page MenuHomePhabricator

Make the "Install Dashboard" flow smoother
ClosedPublic

Authored by epriestley on Apr 1 2019, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 19, 11:24 AM
Unknown Object (File)
Thu, Jun 19, 8:23 AM
Unknown Object (File)
Tue, Jun 17, 10:26 AM
Unknown Object (File)
Mon, Jun 16, 5:59 PM
Unknown Object (File)
Sun, Jun 15, 11:30 PM
Unknown Object (File)
May 31 2025, 9:03 PM
Unknown Object (File)
May 8 2025, 4:15 AM
Unknown Object (File)
May 7 2025, 3:14 AM
Subscribers
None

Details

Summary

Depends on D20362. Ref T13272. Currently, Dashboards have an "Install Dashboard" flow which is pretty janky and only allows you to install things to the home page.

Instead, allow users to install things to any valid target (home, favorites, portals, projects). This also provides URIs like dashboard/install/1/home/personal/ which allow you to link users to an "install a dashboard" page; this may or may not get used.

Test Plan

Installed dashboards on home, favorites, projects, and portals.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/search/menuitem/PhabricatorProfileMenuItem.php
91–92

Debugging code.

This revision is now accepted and ready to land.Apr 3 2019, 6:37 PM
This revision was automatically updated to reflect the committed changes.