Page MenuHomePhabricator

Make the "Install Dashboard" flow smoother
ClosedPublic

Authored by epriestley on Apr 1 2019, 8:10 PM.

Details

Summary

Depends on D20362. Ref T13272. Currently, Dashboards have an "Install Dashboard" flow which is pretty janky and only allows you to install things to the home page.

Instead, allow users to install things to any valid target (home, favorites, portals, projects). This also provides URIs like dashboard/install/1/home/personal/ which allow you to link users to an "install a dashboard" page; this may or may not get used.

Test Plan

Installed dashboards on home, favorites, projects, and portals.

Diff Detail

Repository
rP Phabricator
Branch
portal13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22494
Build 30796: Run Core Tests
Build 30795: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/search/menuitem/PhabricatorProfileMenuItem.php
91–92

Debugging code.

This revision is now accepted and ready to land.Apr 3 2019, 6:37 PM
This revision was automatically updated to reflect the committed changes.