Page MenuHomePhabricator

Put "workflow" on Dashboard edit links when they're disabled
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 11:33 AM
Unknown Object (File)
Nov 30 2023, 3:23 AM
Unknown Object (File)
Nov 16 2023, 9:07 AM
Unknown Object (File)
Nov 13 2023, 5:37 PM
Unknown Object (File)
Nov 3 2023, 10:42 PM
Unknown Object (File)
Oct 25 2023, 6:41 PM
Unknown Object (File)
Oct 18 2023, 11:47 AM
Unknown Object (File)
Oct 10 2023, 3:20 AM
Subscribers
None

Details

Summary

Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.

These actions are implemented in a nonstandard way; standardize them.

Test Plan

Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).

Diff Detail

Repository
rP Phabricator
Branch
portal15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22467
Build 30757: Run Core Tests
Build 30756: arc lint + arc unit