Page MenuHomePhabricator

Remove the dashboard "template" workflow
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:06 PM.
Tags
None
Referenced Files
F13051721: D20367.diff
Fri, Apr 19, 4:15 AM
F13050695: D20367.diff
Fri, Apr 19, 3:07 AM
Unknown Object (File)
Fri, Mar 22, 2:47 AM
Unknown Object (File)
Thu, Mar 21, 1:30 AM
Unknown Object (File)
Mar 5 2024, 1:14 AM
Unknown Object (File)
Feb 24 2024, 4:59 PM
Unknown Object (File)
Dec 20 2023, 11:34 AM
Unknown Object (File)
Nov 30 2023, 3:22 AM
Subscribers
None

Details

Summary

Depends on D20364. Ref T13272. When you create a dashboard, we currently give you a modal choice between an empty dashboard and a "simple template" dashboard.

Remove this choice, and create an empty dashboard in all cases instead.

I think this template dashboard flow isn't terribly useful, and is partly covering over other deficiencies in the workflow. I'm fixing many of those and suspect we can get away without this now. Users on this flow also may not really know what they want. This also contributes to having a lot of extra unmoored panels floating around.

If we did rebuild this, I'd like to address more specific use cases and probably build it as "Add a Template Panel..." or similar, as an action you can use to quickly update an existing workboard. This would be a lot more flexible than create-a-whole-template-board.

Test Plan

Created a new board, no more "template: yes or no?" gate.

Diff Detail

Repository
rP Phabricator
Branch
portal14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22466
Build 30755: Run Core Tests
Build 30754: arc lint + arc unit