Page MenuHomePhabricator
Feed All Stories

May 9 2017

cxzzero created T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.
May 9 2017, 8:33 PM · Bug Report
cguenther added a comment to T7930: Let Calendar provide date services to other applications.
In T7930#215278, @isfs wrote:

Something that would be useful to us would be the ability to create, or probably better, assign a task, as it nears a due date. E.g. we may set up a task due in a year's time, and anticipate working on it two months before it is due. It would be great to be able to schedule the task to be assigned on a particular date, and perhaps moved on a workboard. I don't think this would need to be any more complicated than a Herald action that runs at a particular date/time rather than in response to some other action. I'm not familiar with what Calendar can already do, as we don't have prototype applications turned on for our install, so apologies if this is already possible. I just thought I would mention this use case here for future reference.

The recurring and due date use cases in the previous comment would also be useful to us. I would prefer something more natural for the formulation, though, e.g. for tasks:

  • when [Father Time] [reaches] value in [Due Date] (or other selected field), [Assign to] [ben].
  • when [Father Time] [is one week before] value in [Due Date] AND [Status] is [any open status], [Set priority] to [High].
  • when [Father Time] is [one month after] value in [Creation Date] AND [Status] is [any open status], [Send email notification] to [manager].

It would be great if task Due Dates (or other date fields, conceivably creation date could also be useful) could (optionally) appear on a calendar.

May 9 2017, 7:35 PM · Calendar
saifelse updated the task description for T12694: Allow user to submit unsubmitted comments via `arc diff`.
May 9 2017, 6:35 PM · Feature Request
epriestley added a comment to T12616: Modernize display code for inline comments.

I'm having a tough time picking pieces apart here so that the transition is gradual -- many of the remaining behaviors are highly connected to one another and hard to tease apart. Things feel fine up to D17846, but even D17859 breaks enough stuff that I don't feel great about it, and doesn't seem to have pushed me through things enough to emerge on the other side.

May 9 2017, 6:15 PM · Inline Comments
saifelse updated the task description for T12694: Allow user to submit unsubmitted comments via `arc diff`.
May 9 2017, 6:03 PM · Feature Request
saifelse updated the task description for T12694: Allow user to submit unsubmitted comments via `arc diff`.
May 9 2017, 6:02 PM · Feature Request
saifelse created T12694: Allow user to submit unsubmitted comments via `arc diff`.
May 9 2017, 6:02 PM · Feature Request
avivey added a comment to T12690: phpcs linter report No such linter standard.

arc linters phpcs shows both standard and phpcs.standard configuration options. Have you tried both?

May 9 2017, 5:56 PM
epriestley closed T5301: Inline Remarkup escaping as Wontfix.
  • If you want to implement backslashes or thunderclouds as escape characters, feel free to do so locally. I don't plan to bring these changes upstream.
  • If you want to strip zero-width spaces or escape literals, feel free to do so locally. I don't plan to bring these changes upstream.
  • I do not plan to implement any sort of generalized inline escape character, sequence, or block in upstream Remarkup at this time.
May 9 2017, 5:55 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

Yes, it would be very easy! Feel free to implement such a rule locally.

May 9 2017, 5:51 PM · Remarkup
chad updated the task description for T12685: Modular Transactions Migrations Errata.
May 9 2017, 5:49 PM · Transactions
DemiMarie added a comment to T5301: Inline Remarkup escaping.

Would it be possible for reMarkup to strip all zero-width non-breaking
spaces from its output, unless there was more than one in a row (in which
case the number would be decreased by 1)? That would solve the problem.

May 9 2017, 5:47 PM · Remarkup
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 9 2017, 5:42 PM · Transactions
em added a comment to T5301: Inline Remarkup escaping.

Heh, zero-width spaces are an option, yes. A bit too subtle in my eyes, but fair enough.

May 9 2017, 5:22 PM · Remarkup
chad revoked Phabricator Gold from recipient: fosskevin.
May 9 2017, 5:09 PM
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 9 2017, 5:07 PM · Inline Comments
chad closed I1 Test Initiative.
May 9 2017, 5:06 PM · Fund, Phortune
chad set the image for Fund to F4947958: fa-flag-checkered-indigo.png.
May 9 2017, 5:06 PM
chad set the icon for Fund to Goal.
May 9 2017, 5:06 PM
chad created T12693: Design a remarkup widget for initiatives.
May 9 2017, 5:04 PM · Design, Fund
chad created T12692: Allow setting of a fund goal.
May 9 2017, 5:03 PM · Fund
chad created T12691: Allow recurring Fund donations.
May 9 2017, 5:02 PM · Fund
epriestley added a comment to T5301: Inline Remarkup escaping.

Okay: H3

May 9 2017, 4:32 PM · Remarkup
em added a comment to T5301: Inline Remarkup escaping.

I didn't mention backslashes on purpose, as I'm not specifically interested in any kind of escape characters. I just would like to have a specific occurrence of H3 to not be hyperlinked: any mechanism to do so would be fine, be it an escape character, an escape sequence, an inline version of the literal block, or something else entirely like an emoji. :) Thanks!

May 9 2017, 4:29 PM · Remarkup
epriestley added a comment to T12689: Mail is still received after resigning from a revision.

You can't explicitly subscribe to a revision you're a reviewer for because being a reviewer makes you an automatic subscriber (and, due to a similar bug to the one here, probably can't subscribe even if you've resigned, today), so you'd need to resign, then explicitly subscribe. Also, I'm not sure we handle the other way (explicitly unsubscribe, then later become a reviewer) correctly. These are tractable.

May 9 2017, 4:11 PM · Mail, Differential, Bug Report
chad updated the task description for T12685: Modular Transactions Migrations Errata.
May 9 2017, 4:03 PM · Transactions
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 9 2017, 4:02 PM · Transactions
epriestley added a comment to T5301: Inline Remarkup escaping.

Perfectly clear.

May 9 2017, 3:35 PM · Remarkup
em added a comment to T5301: Inline Remarkup escaping.

@epriestley, @chad, is the use-case in T5301#218589 clear enough?

May 9 2017, 2:30 PM · Remarkup
luismigueldope added a comment to T3993: Build a global menu item showing the current Phrequent stack.

Adding a input box to the top so wherever you are you can just type in the task number you want to switch to, would be a plus.

May 9 2017, 8:27 AM · Phrequent
tomheng removed a project from T12690: phpcs linter report No such linter standard: Bug Report.
May 9 2017, 6:41 AM
tomheng created T12690: phpcs linter report No such linter standard.
May 9 2017, 3:32 AM
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 9 2017, 2:49 AM · Transactions
gregprice added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Staring a bit more at the data I just posted, it occurs to me that it seems kind of sluggish for an UPDATE like those -- one row, indexed by what I assume is the PRIMARY KEY -- to take 1-4ms or so, as these are. There's probably a DB (or network-to-DB?) performance issue there that we'd benefit broadly from addressing.

May 9 2017, 2:38 AM · Restricted Project, Workboards
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 9 2017, 2:35 AM · Transactions
gregprice added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

We're still seeing this issue pretty severely, on our shiny upgraded 2017 Week 17 version on our shiny new Phabricator host. So I took a look just now with DarkConsole.

May 9 2017, 2:30 AM · Restricted Project, Workboards
chad added a comment to T8588: One instance has a severe, global performance issue.

spacecat

May 9 2017, 2:15 AM · Restricted Project
gregprice changed the status of T8588: One instance has a severe, global performance issue from Wontfix to Resolved.

This issue is in fact actually fixed 🎊 ! Most recently, moving to a new host with a newer PHP (and everything else, running Ubuntu 16.04 rather than 12.04) made a big difference; we've also made a lot of improvements to our Phabricator setup over the past year or so, some of which likely helped too.

May 9 2017, 2:14 AM · Restricted Project
gregprice changed the status of T8588: One instance has a severe, global performance issue, a subtask of T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error), from Wontfix to Resolved.
May 9 2017, 2:14 AM · Restricted Project, Workboards
gregprice changed the status of T8588: One instance has a severe, global performance issue, a subtask of T8444: Increase typeahead speed, from Wontfix to Resolved.
May 9 2017, 2:14 AM · Typeahead, PHUI, Restricted Project

May 8 2017

joshuaspence added a comment to T12689: Mail is still received after resigning from a revision.

(But what if you meant "I'm not going to review this but still want to keep an eye on it" instead of "I'm not going to review this and don't care about it at all"?)

May 8 2017, 11:58 PM · Mail, Differential, Bug Report
chad updated the task description for T12685: Modular Transactions Migrations Errata.
May 8 2017, 11:30 PM · Transactions
epriestley added a comment to T12689: Mail is still received after resigning from a revision.
  • There's probably one fairly narrow bug bug here: DifferentialTransactionEditor->getMailTo() likely includes resigned users but should not.
  • Beyond that, when you've resigned, we should probably exclude you from getting indirect mail via a project/package? Maybe? (But what if you meant "I'm not going to review this but still want to keep an eye on it" instead of "I'm not going to review this and don't care about it at all"?)
May 8 2017, 11:00 PM · Mail, Differential, Bug Report
joshuaspence added a comment to T12689: Mail is still received after resigning from a revision.

rPbcd87e0e3f3756970d26d5e9c4a60e4be73ef6a6
rARC3c4735795a2963c5ddff6dceaf60122d01ca3dc0
rPHUa900d7b63e954e221efe140f0f33d3d701524aae

May 8 2017, 10:37 PM · Mail, Differential, Bug Report
chad added a comment to T12689: Mail is still received after resigning from a revision.

Need version information, please.

May 8 2017, 10:36 PM · Mail, Differential, Bug Report
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 8 2017, 10:30 PM · Transactions
joshuaspence created T12689: Mail is still received after resigning from a revision.
May 8 2017, 10:21 PM · Mail, Differential, Bug Report
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 8 2017, 10:06 PM · Transactions
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 8 2017, 9:54 PM · Transactions
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 8 2017, 9:02 PM · Transactions
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 8 2017, 8:36 PM · Inline Comments
chad added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 8 2017, 8:36 PM · Transactions
epriestley updated the task description for T12616: Modernize display code for inline comments.
May 8 2017, 8:31 PM · Inline Comments
epriestley added a revision to T12685: Modular Transactions Migrations Errata: Unknown Object (Differential Revision).
May 8 2017, 8:31 PM · Transactions
chad added a comment to T12685: Modular Transactions Migrations Errata.

time well spent!

May 8 2017, 8:28 PM · Transactions
epriestley added a comment to T12685: Modular Transactions Migrations Errata.

(It looks like I wrote this string myself, in D7159.)

May 8 2017, 8:27 PM · Transactions
epriestley added a comment to T12685: Modular Transactions Migrations Errata.

Oh, the error just wasn't clear to me. I thought it meant "You must upload audio." in the sense of "you did not upload anything, but needed to". It actually means "You uploaded a file, but the file isn't a valid audio file as far as Phabricator is concerned.".

May 8 2017, 8:26 PM · Transactions
epriestley added a comment to T12685: Modular Transactions Migrations Errata.

I'll poke at it.

May 8 2017, 8:24 PM · Transactions
chad added a comment to T12685: Modular Transactions Migrations Errata.

Yeah I tried wav and mp3, safari and chrome, can't get an error here.

May 8 2017, 8:23 PM · Transactions
epriestley added a comment to T12685: Modular Transactions Migrations Errata.

Here's what I'm seeing locally in Safari:

May 8 2017, 8:17 PM · Transactions
chad added a comment to T12685: Modular Transactions Migrations Errata.

I can't reproduce "Attaching audio to a macro does not appear to work at all: always "You must upload audio.""... any ideas ?

May 8 2017, 8:12 PM · Transactions
cxzzero added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

Thanks, let me check that task and I tell you.

May 8 2017, 7:18 PM · Windows, Bug Report (Needs Information)
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 8 2017, 6:28 PM · Inline Comments
20after4 added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

phabricator trading cards ftw.

May 8 2017, 6:21 PM · Guides, Phacility
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

Just noting that this cat is perfect and DOES NOT need any design improvement:

May 8 2017, 6:14 PM · Design, Differential, Inline Comments
epriestley added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

We might eventually support a trade/resale market -- one advantage is that we could give contributors something with slightly more valuable than stickers/flair/badges, but less complicated for us than doing fulfillment on schwag or dealing with taxes for actual money.

May 8 2017, 6:10 PM · Guides, Phacility
avivey added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

This might be a variant of T2465. There's some workaround described there that might help.

May 8 2017, 5:59 PM · Windows, Bug Report (Needs Information)
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 8 2017, 5:56 PM · Inline Comments
avivey added a project to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows: Windows.
May 8 2017, 5:56 PM · Windows, Bug Report (Needs Information)
cspeckmim added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

I was fully expecting a black market for mana points to be available.

May 8 2017, 5:56 PM · Guides, Phacility
20after4 added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

I think that @epriestley just made capitalism and socialism obsolete by re-imagining everything in terms of Mana points. You sir, have won the internet.

May 8 2017, 5:52 PM · Guides, Phacility
cxzzero added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.
  • Windows version is Windows 7 with latest updates,
  • PHP version 5.6.13,
  • svn, version 1.9.4 (r1740329), compiled Apr 24 2016, 15:40:35 on x86-microsoft-windows
  • arcanist version mentioned above
May 8 2017, 5:47 PM · Windows, Bug Report (Needs Information)
20after4 awarded T8236: `arc weld` should do something a Pirate Logo token.
May 8 2017, 5:46 PM · Contributor Onboarding, Arcanist
20after4 added a comment to T8236: `arc weld` should do something.

This should clearly be priority: Unbreak now!

May 8 2017, 5:45 PM · Contributor Onboarding, Arcanist
chad added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

This is a little light on reproduction steps. Can you give us more information such as the version information on Windows, SVN, local arcanist, if you attempted reproduction against a clean Phacility instance or against SVNTest here?

May 8 2017, 5:38 PM · Windows, Bug Report (Needs Information)
chad edited projects for T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows, added: Bug Report (Needs Information); removed Bug Report.
May 8 2017, 5:36 PM · Windows, Bug Report (Needs Information)
chad added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

There were no commits between friday and today, so I'm not following what you're trying to tell us.

May 8 2017, 5:35 PM · Windows, Bug Report (Needs Information)
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

hqdefault.jpg (360×480 px, 11 KB)

May 8 2017, 5:33 PM · Design, Differential, Inline Comments
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

catroomguardian.jpg (564×600 px, 35 KB)

May 8 2017, 5:33 PM · Design, Differential, Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

Everyone loves Opportunities For Improvement!

May 8 2017, 5:33 PM · Design, Differential, Inline Comments
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

This stuff is probably going to churn for a bit but I'm pretty sure I'll forget about that thing if I don't write it down somewhere.

May 8 2017, 5:32 PM · Design, Differential, Inline Comments
chad added a comment to T12688: Inline Comment Design Opportunities for Improvement.

esyh8.jpg (360×480 px, 12 KB)

May 8 2017, 5:32 PM · Design, Differential, Inline Comments
epriestley added projects to T12688: Inline Comment Design Opportunities for Improvement: Differential, Design.
May 8 2017, 5:32 PM · Design, Differential, Inline Comments
epriestley triaged T12688: Inline Comment Design Opportunities for Improvement as Wishlist priority.

In View Options → Collapse File, we get into this sort of oldschool state:

May 8 2017, 5:32 PM · Design, Differential, Inline Comments
epriestley created T12688: Inline Comment Design Opportunities for Improvement.
May 8 2017, 5:30 PM · Design, Differential, Inline Comments
chad added a revision to T12671: Update Maniphest for modular transactions: Unknown Object (Differential Revision).
May 8 2017, 5:28 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad added a comment to T10541: Maniphest report by project not showing proper results.

Just merging this over to Facts, I don't anticipate allocating any resources to Maniphest reports before Facts ships.

May 8 2017, 5:26 PM · Maniphest, Bug Report
chad merged T10541: Maniphest report by project not showing proper results into T1562: Build "Facts", an ETL pipeline and charting application.
May 8 2017, 5:25 PM · Restricted Project, Wikimedia, Facts
chad merged task T10541: Maniphest report by project not showing proper results into T1562: Build "Facts", an ETL pipeline and charting application.
May 8 2017, 5:25 PM · Maniphest, Bug Report
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 8 2017, 5:06 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 8 2017, 4:53 PM · Inline Comments
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 8 2017, 4:41 PM · Inline Comments
epriestley added a revision to T11093: DifferentialInlineCommentEditor retains state across Quicksand requests: Unknown Object (Differential Revision).
May 8 2017, 4:01 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: Unknown Object (Differential Revision).
May 8 2017, 4:01 PM · Inline Comments, Quicksand
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 8 2017, 4:01 PM · Inline Comments
epriestley added a comment to T12676: Dialog box closes with ESC key even when there's unsaved change.

T10469 is vaguely related.

May 8 2017, 2:38 PM · Bug Report
cxzzero renamed T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows from When submitting an arc diff, svn diff or updating a revision a Parse Error ocurrs in Windows to When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.
May 8 2017, 2:28 PM · Windows, Bug Report (Needs Information)
cxzzero renamed T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows from When submitting a svn diff or updating a revision a Parse Error ocurrs in Windows to When submitting an arc diff, svn diff or updating a revision a Parse Error ocurrs in Windows.
May 8 2017, 2:27 PM · Windows, Bug Report (Needs Information)
cxzzero created T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.
May 8 2017, 2:26 PM · Windows, Bug Report (Needs Information)
epriestley moved T9303: Improve Phacility Onboarding/NUX from Do After Launch to Onboarding/NUX on the Phacility board.
May 8 2017, 1:15 PM · Phacility