Page MenuHomePhabricator
Feed All Stories

May 14 2017

epriestley closed T12679: Fix trivial errors in various View controllers as Resolved by committing Restricted Diffusion Commit.
May 14 2017, 8:28 PM · Differential, Audit, Restricted Project, Customer Impact
benwick added a comment to T12708: Editing of Dashboard Tab Panels can delete Tabs.

Yeah, these two bugs are probably connected. But the reproductions steps in my setup are surely more common 😄 When I tried to setup the main dashboard for our install, we changed the tabs a lot of times to find the right way to present the important infos for our users. This swallowing of tabs was pretty frustrating...

May 14 2017, 8:26 PM · Bug Report
eliaspro added a comment to T12708: Editing of Dashboard Tab Panels can delete Tabs.

Duplicate of T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned

May 14 2017, 8:18 PM · Bug Report
benwick created T12708: Editing of Dashboard Tab Panels can delete Tabs.
May 14 2017, 7:36 PM · Bug Report
chad added a revision to T12707: Add "watching" to Project ApplicationSearch: Unknown Object (Differential Revision).
May 14 2017, 4:15 PM · Projects
chad added a comment to T9412: Annotate all the reasons that a user is included on the recipient list for mail.

Filed T12707 to follow up.

May 14 2017, 4:03 PM · llvm, Restricted Project, Mail
chad created T12707: Add "watching" to Project ApplicationSearch.
May 14 2017, 4:02 PM · Projects
chad added a comment to T9412: Annotate all the reasons that a user is included on the recipient list for mail.

I don't expect watchers to be on profile, but we should provide a search for it in /projects/

May 14 2017, 3:54 PM · llvm, Restricted Project, Mail
aklapper added a comment to T9412: Annotate all the reasons that a user is included on the recipient list for mail.

Another anecdote explaining that the current situation is confusing:
As a user who has not been active in Phabricator for a while and as my interests in projects might have shifted, I am trying to find out why I receive email notifications about certain tasks and how to disable these specific notifications to reduce the amount of uninteresting mail. But:

  • My "Profile" user page does not list any "Projects".
  • The email headers do not tell me either why I received an email.

After some thinking I realized that the reason was that I was a watcher (but not a member) of an associated project tag of a task.
I'd expect my "Profile" user page to not only list "Projects" (actually means: Member) but also projects that I only watch. Currently I need to go to one of the tasks that I received an email about, click all associated projects, and go to the "Members and Watchers" page of each project to find out that I once added myself as a "watcher" and remove myself.
However, that might still not explain why I received a specific email: If I have "Settings > Email > Email Preferences > Maniphest Tasks > One of a task's subtasks changes status" enabled, I also need to check all subtasks' projects whether I watch one of them.

May 14 2017, 3:47 PM · llvm, Restricted Project, Mail
maxie asked Q616: Export for Tasks in Text Format?.
May 14 2017, 7:03 AM · Maniphest
zjturner added a comment to T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.

Not sure if I should make a separate issue for this or just mention it here, but it would be nice if you could parse the "signature" of a patch generated with git format-patch. Currently patches generated with git format-patch cannot even be uploaded to Phabricator unless you set git config format.signature=""

May 14 2017, 3:58 AM · Arcanist, Differential
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

BTW, the original patch was generated using git format-patch, not git diff

May 14 2017, 1:39 AM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

The original patch which causes this problem is attached. It was generated using git version 2.10.1.windows.1. git am 0001-Move-lld-Parallel-algorithms-to-llvm.patch will successfully apply the patch, but after uploading it to phabricator and then redownloading the raw diff, it no longer applies. The original patch contains text like this:

May 14 2017, 1:37 AM · Bug Report

May 13 2017

epriestley added a comment to T12706: Add feature to "diff against" comments in Differential.

I don't think this is about inline comments, since @ajklen says "comment dropdown menu" and inline comments don't have one. I believe they want this, in the existing dropdown menu of (non-inline) comments:

May 13 2017, 6:01 PM · Feature Request
ajklen added a comment to T12706: Add feature to "diff against" comments in Differential.

Sorry, to clarify, I'm just asking for a convenience feature in the UI. I'm aware of the History tab, but I find that I often specifically want to see changes made since a certain comment (e.g. to check if/how the issue was addressed). In other code review software I've used, this workflow only takes a single click.

May 13 2017, 3:44 PM · Feature Request
joshuaspence added a comment to T12706: Add feature to "diff against" comments in Differential.

I think the author is essentially asking for an easy way to map inline comments to the diff that they were originally made upon.

May 13 2017, 3:52 AM · Feature Request
epriestley added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

No. It's not that the builds can access credentials on the build hosts -- that part is a general problem -- it's that the Phabricator application hosts can be made to divulge their credentials (which are necessarily the same as the S3 credentials, because the same hosts must access S3) by instructing them to run builds that use 169.254.169.254 as a "build server".

May 13 2017, 1:18 AM · Files
joshuaspence added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

As a general note here, we've been vulnerable to credential theft from the local service throughout this discussion, and still are until T12701 resolves: attackers can create a Harbormaster build plan which sends requests to 169.254.169.254, then read credentials from the output of the "failed build".

May 13 2017, 12:44 AM · Files
chad added a comment to T12706: Add feature to "diff against" comments in Differential.

(We don't take UI feedback as feature requests, for the record).

May 13 2017, 12:08 AM · Feature Request
chad added a comment to T12706: Add feature to "diff against" comments in Differential.

Are you referring to this table here, which already exists or is there another problem you're trying to solve. It's unclear if you just have a question on how to use Phabricator or are asking for that workflow to be more efficient.

May 13 2017, 12:08 AM · Feature Request

May 12 2017

chad added a comment to Q468: Create task from emails.

Go to Applications and click configure next to maniphest. You can assign an email to catch bugs@

May 12 2017, 7:24 PM · Mail
• Ondrej updated subscribers of Q468: Create task from emails.

Hi @maxie, do you know how to setup Phabricator to create tasks sent to bugs@domain.ltd? I have finished everything as described in the manual, but I receive this:

May 12 2017, 6:50 PM · Mail
ajklen created T12706: Add feature to "diff against" comments in Differential.
May 12 2017, 6:41 PM · Feature Request
epriestley added a revision to T12679: Fix trivial errors in various View controllers: Unknown Object (Differential Revision).
May 12 2017, 6:07 PM · Differential, Audit, Restricted Project, Customer Impact
epriestley claimed T12679: Fix trivial errors in various View controllers.
May 12 2017, 5:57 PM · Differential, Audit, Restricted Project, Customer Impact
epriestley added a comment to T12694: Allow user to submit unsubmitted comments via `arc diff`.

I think this is generally reasonable, but probably on the far side of T12010 since it implies API changes.

May 12 2017, 5:57 PM · Feature Request
epriestley added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

Users can also currently add http://169.254.169.254/ as a Git repository, although I'm not certain if they can actually capture credentials by doing this.

May 12 2017, 5:52 PM · Files
epriestley added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

As a general note here, we've been vulnerable to credential theft from the local service throughout this discussion, and still are until T12701 resolves: attackers can create a Harbormaster build plan which sends requests to 169.254.169.254, then read credentials from the output of the "failed build".

May 12 2017, 5:51 PM · Files
epriestley triaged T12701: Harbormaster does not ignore additional whitespace in HTTP URLs, making invalid HTTP requests as Low priority.

T11632 is vaguely related.

May 12 2017, 5:49 PM · Security, Harbormaster, Bug Report
epriestley added a comment to T12702: Unable to apply raw diff when files are moved.

Oh, no problem -- we likely won't look into this for a while anyway (T12664 is a big mess of related issues that we'll probably try to fix all at once).

May 12 2017, 5:48 PM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

Sorry, I've been slacking on getting you this information. Been swamped at
work. I'll try to get it to you this weekend.

May 12 2017, 5:47 PM · Bug Report
epriestley closed T12705: Set visibility through arc diff as Invalid.

See Contributing Feature Requests, but also note that we're likely to restrict this channel soon because no one reads that document (see T12134#212579).

May 12 2017, 5:40 PM · Bug Report
epriestley added a comment to T12702: Unable to apply raw diff when files are moved.

(We probably won't look at this until T12664 moves forward, but when it does it would definitely be helpful to have a specific set of steps we can take to reproduce the issue locally in a clean repository.)

May 12 2017, 5:39 PM · Bug Report
franziskus created T12705: Set visibility through arc diff.
May 12 2017, 5:38 PM · Bug Report
epriestley added a parent task for T12702: Unable to apply raw diff when files are moved: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 12 2017, 5:37 PM · Bug Report
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T12702: Unable to apply raw diff when files are moved.
May 12 2017, 5:37 PM · Arcanist, Differential
epriestley renamed T12703: When integrated, CircleCI and Harbormaster can send redundant notifications from CircleCI notifications are spammy to When integrated, CircleCI and Harbormaster can send redundant notifications.
May 12 2017, 5:35 PM · Feature Request, Harbormaster
epriestley triaged T12703: When integrated, CircleCI and Harbormaster can send redundant notifications as Wishlist priority.
May 12 2017, 5:35 PM · Feature Request, Harbormaster
epriestley edited projects for T12703: When integrated, CircleCI and Harbormaster can send redundant notifications, added: Feature Request; removed Bug Report.

I don't think this is a bug: both systems are behaving as designed.

May 12 2017, 5:35 PM · Feature Request, Harbormaster
stephane.chazelas added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

Isn't that a dup of T8611?

May 12 2017, 1:43 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
asherkin closed T12704: test as Invalid.

This is not a demo or test install. Please don't make a mess! You can launch a demo install on Phacility if you want to poke around and try things out.

May 12 2017, 12:23 PM · Bug Report
zjkyz8 added a comment to T6653: Script and regex linter could use some examples.

Hey guys,

May 12 2017, 11:31 AM · Lint, Documentation, Arcanist
rabahmeradi updated the task description for T7759: A feed search for "include users" also embeds other users who just gave tokens.
May 12 2017, 11:27 AM · Tokens, Feed
SlimedGooch added a watcher for Community: SlimedGooch.
May 12 2017, 11:01 AM
• thirupu.somu updated the task description for T7759: A feed search for "include users" also embeds other users who just gave tokens.
May 12 2017, 10:56 AM · Tokens, Feed
• thirupu.somu created T12704: test.
May 12 2017, 10:45 AM · Bug Report
michaelfoley added a comment to P2050 HHVM config.
# cat /etc/hhvm/php.ini 
; php options
session.save_handler = files
session.save_path = /var/lib/php5
session.gc_maxlifetime = 1440
May 12 2017, 2:00 AM
michaelfoley added a comment to P2050 HHVM config.
# cp /etc/hhvm/config.hdf /etc/hhvm/config.hbf
May 12 2017, 1:44 AM
mirage315 closed Q614: Does notification server has some ring tone when message pop up? as resolved.
May 12 2017, 1:43 AM · Notifications
mirage315 asked Q615: Does Conduit API support close task as 'Resolved"?.
May 12 2017, 1:43 AM · Conduit
michaelfoley edited P2050 HHVM config.
May 12 2017, 1:36 AM
michaelfoley edited P2050 HHVM config.
May 12 2017, 1:36 AM
michaelfoley created P2050 HHVM config.
May 12 2017, 1:35 AM

May 11 2017

chad created Image Macro "itsalive".
May 11 2017, 9:54 PM
nfirmani awarded T12694: Allow user to submit unsubmitted comments via `arc diff` a Like token.
May 11 2017, 8:04 PM · Feature Request
avivey added a project to T12703: When integrated, CircleCI and Harbormaster can send redundant notifications: Harbormaster.
May 11 2017, 7:20 PM · Feature Request, Harbormaster
ry created T12703: When integrated, CircleCI and Harbormaster can send redundant notifications.
May 11 2017, 5:49 PM · Feature Request, Harbormaster
chad updated the image for Conpherence from F1064793: profile to F4952509: profile.
May 11 2017, 5:46 PM
chad updated the image for Bug Report from Unknown Object (File) to F4952490: fa-bug-yellow.png.
May 11 2017, 5:28 PM
• david.lebert.60 removed a watcher for Windows: • david.lebert.60.
May 11 2017, 2:53 PM
• david.lebert.60 added a watcher for Windows: • david.lebert.60.
May 11 2017, 2:52 PM
arcadien added a comment to T5149: Allow to add and edit Phrequent entries manually.

Thanks for link, i know that page already. This feature is the one missing for us to switch from another well-known system which have more and more performance and billing problems.
That means we can finish the development of this one : that's why i asked for a status, rather than a boring "will it be ready next week" :)

May 11 2017, 2:14 PM · Phrequent
epriestley added a comment to T5149: Allow to add and edit Phrequent entries manually.

See Planning.

May 11 2017, 12:58 PM · Phrequent
joshuaspence awarded T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats a Pirate Logo token.
May 11 2017, 12:29 PM · Arcanist, Differential
arcadien added a comment to T5149: Allow to add and edit Phrequent entries manually.

I just applied the patch (roughly) and the "edit" pen appeared in Phrequent. By the way, clicking on it lead to a 404 Not Found error page.

May 11 2017, 11:42 AM · Phrequent
arcadien added a comment to T5149: Allow to add and edit Phrequent entries manually.

any news here? the implementation seemed on a good way but there was no update since July 2015

May 11 2017, 9:40 AM · Phrequent
arcadien awarded T5149: Allow to add and edit Phrequent entries manually a Like token.
May 11 2017, 9:37 AM · Phrequent

May 10 2017

avivey edited P1998 git-files-commits-table.py.
May 10 2017, 9:08 PM
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

This is rather strange. I don't have the original patch used to create the revision anymore, but I tried it again using the same command I always use to generate patches, and when I upload this new patch, I do not see the same issue. In the first (broken) one, some of the files are marked with V, but in the new (working) one, none of the files are marked as V. This is even though git status shows that they are renames:

May 10 2017, 8:13 PM · Bug Report
avivey added a comment to T12702: Unable to apply raw diff when files are moved.

Which version of git was used? Can you upload the original patch file used to create the diff?
Which version of git is the server using?

May 10 2017, 7:52 PM · Bug Report
avivey closed T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok as Wontfix.
May 10 2017, 7:41 PM · Bug Report
cxzzero moved T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok from Backlog to Fishing Expeditions on the Bug Report board.
May 10 2017, 5:24 PM · Bug Report
zjturner added a comment to T12702: Unable to apply raw diff when files are moved.

Note that a workaround is to do the following:

May 10 2017, 4:53 PM · Bug Report
zjturner updated subscribers of T12702: Unable to apply raw diff when files are moved.
May 10 2017, 4:47 PM · Bug Report
zjturner created T12702: Unable to apply raw diff when files are moved.
May 10 2017, 4:46 PM · Bug Report
chad disabled the audio for Image Macro "derpdog".
May 10 2017, 4:35 PM
epriestley removed a reviewer for D17863: <<TEST>: Blessed Reviewers.
May 10 2017, 3:25 PM
cxzzero added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

Excellent! Thanks @avivey.
This ticket could be closed.

May 10 2017, 12:48 PM · Bug Report
mormegil created T12701: Harbormaster does not ignore additional whitespace in HTTP URLs, making invalid HTTP requests.
May 10 2017, 10:17 AM · Security, Harbormaster, Bug Report
• saupant created D17863: <<TEST>.
May 10 2017, 5:52 AM
chad merged T12700: Bring back diff results from the user page into T12423: Bring MenuItem customization options to User Profiles.
May 10 2017, 2:34 AM · Dashboards, Restricted Project, Profile
chad merged task T12700: Bring back diff results from the user page into T12423: Bring MenuItem customization options to User Profiles.
May 10 2017, 2:34 AM · Restricted Project, Feature Request
alexmv added a project to T12700: Bring back diff results from the user page: Restricted Project.
May 10 2017, 2:18 AM · Restricted Project, Feature Request
alexmv created T12700: Bring back diff results from the user page.
May 10 2017, 2:18 AM · Restricted Project, Feature Request

May 9 2017

jeffprouty added a comment to T12696: broadcast_main has weird behavior with RC channel for sprayer config.

@epriestley Whoops! So embarrassed. Thanks :)

May 9 2017, 10:35 PM · Bug Report
epriestley closed T12699: MP does not respect MavFrame in .waypoints file. as Invalid.

You're on the wrong install by mistake.

May 9 2017, 10:33 PM · Bug Report
epriestley closed T12698: Spray is on when returning to land! as Invalid.

You're on the wrong install by mistake.

May 9 2017, 10:33 PM · Bug Report
epriestley closed T12697: Altitude for TakeOff should match waypoint altitudes for spray mission as Invalid.

You're on the wrong install by mistake.

May 9 2017, 10:33 PM · Bug Report
jeffprouty created T12699: MP does not respect MavFrame in .waypoints file..
May 9 2017, 10:32 PM · Bug Report
jeffprouty created T12698: Spray is on when returning to land!.
May 9 2017, 10:31 PM · Bug Report
epriestley closed T12696: broadcast_main has weird behavior with RC channel for sprayer config as Invalid.

I think you've filed this against the wrong install by mistake.

May 9 2017, 10:30 PM · Bug Report
jeffprouty created T12697: Altitude for TakeOff should match waypoint altitudes for spray mission.
May 9 2017, 10:30 PM · Bug Report
jeffprouty created T12696: broadcast_main has weird behavior with RC channel for sprayer config.
May 9 2017, 10:29 PM · Bug Report
avivey added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

It saves it to a directory called arc in your repository meta-directory. If you're using git, it would be in .git/arc/.

May 9 2017, 9:28 PM · Bug Report
cxzzero added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

Thanks for your reply.

May 9 2017, 9:22 PM · Bug Report
epriestley added a revision to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000: Unknown Object (Differential Revision).
May 9 2017, 9:01 PM · Inline Comments, Differential, Bug Report
epriestley added a revision to T12616: Modernize display code for inline comments: Unknown Object (Differential Revision).
May 9 2017, 9:01 PM · Inline Comments
avivey added a comment to T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.

You can user arc set-config --local to set a configuration value in a file that is in the repository but is not committed.

May 9 2017, 8:51 PM · Bug Report
avivey updated the task description for T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.
May 9 2017, 8:43 PM · Bug Report
cxzzero updated the task description for T12695: Getting error "Undefined index: Repository UUID" while doing arc diff --preview command, although diff is generated ok.
May 9 2017, 8:35 PM · Bug Report