Page MenuHomePhabricator
Feed All Stories

May 16 2016

epriestley added a comment to T10939: Support for OWNERS files.

The default home page (and homepage sidebar notification count) are also still doing the old grouping / counts. We should probably fix that but it's not a strict dependency here and there's adjacent work (T3583).

May 16 2016, 11:41 PM · Prioritized, Restricted Project, Owners
epriestley closed T10972: changing repo keys doesn't update "Used by" on them as Resolved by committing Restricted Diffusion Commit.
May 16 2016, 11:39 PM · Bug Report
epriestley added a revision to T10972: changing repo keys doesn't update "Used by" on them: Unknown Object (Differential Revision).
May 16 2016, 11:38 PM · Bug Report
chad updated the task description for T10973: Allow users to edit story points via batch (bulk) edits.
May 16 2016, 11:37 PM · Maniphest, Feature Request
epriestley added a comment to T10939: Support for OWNERS files.

Yes, since it would really mean exact(current-viewer) without additional work. Are you using it for something (dashboards?)

May 16 2016, 11:31 PM · Prioritized, Restricted Project, Owners
Luke081515.2 created T10973: Allow users to edit story points via batch (bulk) edits.
May 16 2016, 10:24 PM · Maniphest, Feature Request
joshuaspence added a comment to T10939: Support for OWNERS files.

I'm no longer able to search for "Responsible Users: (Current Viewer)". Is that expected?

May 16 2016, 10:23 PM · Prioritized, Restricted Project, Owners
allixsenos updated the task description for T10972: changing repo keys doesn't update "Used by" on them.
May 16 2016, 9:46 PM · Bug Report
allixsenos created T10972: changing repo keys doesn't update "Used by" on them.
May 16 2016, 9:46 PM · Bug Report
avivey renamed T10971: php lint: catch `"${var}"` vs `"{$var}"` from php lint: catch `"${var}"` vs `"{$var}" to php lint: catch `"${var}"` vs `"{$var}"`.
May 16 2016, 8:23 PM · XHPAST, Lint, Feature Request
avivey created T10971: php lint: catch `"${var}"` vs `"{$var}"`.
May 16 2016, 8:22 PM · XHPAST, Lint, Feature Request
epriestley added a member for Community: allixsenos.
May 16 2016, 8:01 PM
epriestley added a member for Blessed Committers: allixsenos.
May 16 2016, 8:01 PM
epriestley edited this Badge.
May 16 2016, 8:01 PM
epriestley added a comment to T10939: Support for OWNERS files.

Bucketing is now controlled by a "Bucket: ..." option in the search query controls instead of hardcoded as a behavior of the "Active Revisions" filter. This means that you can apply bucketing to other queries. You can also extend DifferentialRevisionResultBucket to implement your own bucketing algorithms (but: here be dragons).

May 16 2016, 7:55 PM · Prioritized, Restricted Project, Owners
epriestley merged T9372: Plan the future of "Bucketing" Query UIs into T10939: Support for OWNERS files.
May 16 2016, 7:24 PM · Prioritized, Restricted Project, Owners
epriestley merged task T9372: Plan the future of "Bucketing" Query UIs into T10939: Support for OWNERS files.
May 16 2016, 7:24 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley added a comment to T9372: Plan the future of "Bucketing" Query UIs.

I'm going to merge this into T10939, which answers this question in practice if not in theory.

May 16 2016, 7:23 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley closed T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist as Resolved.

There are now six buckets which are more action oriented (Must Review, Ready to Review, Ready to Land, Ready to Update, Waiting on Review, Waiting on Authors) and bucketing is more flexible.

May 16 2016, 7:21 PM · Restricted Project, Differential
epriestley added a comment to T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer.

(The slightly more intuitive "Reviewers: SomeProjectName" will also work.)

May 16 2016, 7:15 PM · Restricted Project, Differential, Restricted Project
epriestley added a comment to T4055: Accepted diffs with not-accepted depends-on diffs should not appear under "Action Required".

D15930 adds an icon hint for this that looks like this:

May 16 2016, 7:11 PM · Differential
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 7:03 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

(You can create an oldest-first dashboard yourself now if you prefer the old ordering, and can probably force it on all users after T4103 if you really want.)

May 16 2016, 6:41 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

This also indirectly flipped the ordering from oldest-first to newest-first. I'm inclined to retain that ordering, since it's consistent with every other application. The "oldest-first" ordering was a sort of paternalistic attempt to force users to review stuff, but I think we've generally moved the software away from that a bit and it doesn't feel very much at home to me any more.

May 16 2016, 6:40 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 6:37 PM · Prioritized, Restricted Project, Owners
webrender awarded T3975: Add the ability to show Google Docs in Remarkup a Like token.
May 16 2016, 6:23 PM · Remarkup
webrender added a comment to T3975: Add the ability to show Google Docs in Remarkup.

+1 for iframe syntax - don't need google docs but we've been wishing that we could embed iframes into our phab diff summaries.

May 16 2016, 6:22 PM · Remarkup
BYK awarded T3975: Add the ability to show Google Docs in Remarkup a Like token.
May 16 2016, 6:19 PM · Remarkup
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 6:04 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

I pushed that stuff live but bucketing has some bugs, looking into it.

May 16 2016, 5:59 PM · Prioritized, Restricted Project, Owners
epriestley closed T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer as Resolved by committing Restricted Diffusion Commit.
May 16 2016, 5:46 PM · Restricted Project, Differential, Restricted Project
chad closed T10959: Hard-coded diff line height interacts poorly with large custom font sizes as Resolved by committing Restricted Diffusion Commit.
May 16 2016, 5:21 PM · Differential
devd added a comment to T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer.

thanks! Will try it out when we update here. @angie can you ping me once we update to this version on our side?

May 16 2016, 5:19 PM · Restricted Project, Differential, Restricted Project
michaeljs1990 added a comment to T10969: Incorrect Phriction link in email.

Not sure if this should be another bug report but the / that is added at the end causes issue when using anchor tags i.e if [[ ../2016.19#gotolocation ]] was the markup the link would also be broken by adding a / at the end.

May 16 2016, 5:08 PM · Phriction, Bug Report
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 4:48 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 4:39 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer.

(The slightly more intuitive "Reviewers: SomeProjectName" will also work.)

May 16 2016, 4:06 PM · Restricted Project, Differential, Restricted Project
epriestley added a comment to T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer.

I have marked D15925 as fixing this. T10939 has some broader discussion. This isn't an exact fix for the original request, but I suspect it may be close enough to be satisfactory.

May 16 2016, 4:05 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist: Unknown Object (Differential Revision).
May 16 2016, 3:59 PM · Restricted Project, Differential
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 3:59 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer: Unknown Object (Differential Revision).
May 16 2016, 3:59 PM · Restricted Project, Differential, Restricted Project
epriestley added a revision to T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist: Unknown Object (Differential Revision).
May 16 2016, 3:17 PM · Restricted Project, Differential
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 3:17 PM · Prioritized, Restricted Project, Owners
eadler closed T6635: The `arc which` command triggers notices as Resolved by committing Restricted Diffusion Commit.
May 16 2016, 12:54 PM · Subversion, Arcanist
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 16 2016, 12:45 PM · Prioritized, Restricted Project, Owners
epriestley edited the content of Phacility Cluster Devices.
May 16 2016, 12:42 PM
epriestley edited the content of Adding Hardware.
May 16 2016, 12:42 PM
epriestley edited the content of Phacility Cluster Devices.
May 16 2016, 12:41 PM
richardvanvelzen added a comment to T10936: arc feature error while creating a new feature branch.

This is almost definitely T8298, because % can't be properly escaped on Windows right now.

May 16 2016, 10:49 AM · Windows, Arcanist, Bug Report
eadler removed a project from T406: Support "Oncall" Users: Restricted Project.
May 16 2016, 10:38 AM · Nuance, Facebook, Oncall Tool
eadler added a revision to T6635: The `arc which` command triggers notices: Unknown Object (Differential Revision).
May 16 2016, 10:23 AM · Subversion, Arcanist
rencris awarded T8442: Build Space switching UI a Like token.
May 16 2016, 9:54 AM · Restricted Project, Spaces, Wikimedia, Policy
rencris awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
May 16 2016, 9:54 AM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
rencris added a comment to T10936: arc feature error while creating a new feature branch.

This specific issue also happens on my computer, which is running Windows 7 SP1 with PHP 5.6.20

May 16 2016, 9:53 AM · Windows, Arcanist, Bug Report

May 15 2016

chad closed Q389: ssh setup problem as invalid.
May 15 2016, 6:13 PM
cos added Q389: ssh setup problem (Answer 379).
May 15 2016, 5:43 PM
epriestley added a revision to T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist: Unknown Object (Differential Revision).
May 15 2016, 5:37 PM · Restricted Project, Differential
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 15 2016, 5:37 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Collecting some additional dashboard cases from stuff merged into T4144:

May 15 2016, 4:36 PM · Prioritized, Restricted Project, Owners
hach-que placed T5822: Implement garbage collection / automatic archiving for Harbormaster logs up for grabs.
May 15 2016, 5:49 AM · Harbormaster, Restricted Project
hach-que placed T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster up for grabs.
May 15 2016, 5:45 AM · Restricted Project, Harbormaster (v3)
hach-que closed T8922: Clarify csharp linter requirements as Wontfix.

cslint is deprecated, see T8978.

May 15 2016, 5:45 AM · Lint, Documentation, Arcanist
hach-que closed T5981: Make Drydock resources create a known_hosts file for connecting to hosts as Wontfix.

Closing this because beyond diagnosing initial configuration, there isn't much value in making things this much more complicated.

May 15 2016, 5:42 AM · Harbormaster
chad added Q389: ssh setup problem (Answer 378).
May 15 2016, 5:41 AM
hach-que closed T4483: ArcanistCSharpLinter not reporting linter warnings as Wontfix.

cslint is deprecated, see T8978 for more information.

May 15 2016, 5:40 AM · Lint, Arcanist
hach-que placed T5976: Handle the awful CLIXML output from Powershell on Windows up for grabs.
May 15 2016, 5:37 AM · libphutil, Harbormaster
hach-que placed T5516: Implement support for NuGet (.NET) repositories up for grabs.
May 15 2016, 5:37 AM · Phragment
hach-que placed T4684: Asynchronously calculate or pre-calculate patches for Phragment files up for grabs.
May 15 2016, 5:37 AM · Phragment
hach-que closed T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock as Wontfix.

We're no longer (at work) planning or intending on continuing use for EC2 blueprints. If there's anyone else out there that wants this functionality, feel free to re-open this task.

May 15 2016, 5:36 AM · Drydock
hach-que closed T5544: Implement EC2 blueprint for Drydock, a subtask of T2015: Implement Drydock, as Wontfix.
May 15 2016, 5:36 AM · Drydock
hach-que closed T5544: Implement EC2 blueprint for Drydock as Wontfix.

We're no longer (at work) planning or intending on continuing use for EC2 blueprints. If there's anyone else out there that wants this functionality, feel free to re-open this task.

May 15 2016, 5:36 AM · Drydock
hach-que added a comment to T10969: Incorrect Phriction link in email.

It's not email client dependent - Phabricator is writing out the wrong URL when sending email.

May 15 2016, 5:26 AM · Phriction, Bug Report
cos updated Q389: ssh setup problem from to ssh setup problem.
May 15 2016, 3:14 AM
avivey updated the task description for T10922: Upgrading: New Repository UI, APIs, and URI management.
May 15 2016, 12:15 AM · Diffusion (v3), Installing & Upgrading

May 14 2016

• Sara added a watcher for Blessed Reviewers: • Sara.
May 14 2016, 10:22 PM
aklapper added a comment to T10969: Incorrect Phriction link in email.

Which email client is this about?

May 14 2016, 6:27 PM · Phriction, Bug Report
epriestley merged T10970: Merge Task As Duplicate into T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
May 14 2016, 12:30 PM · Restricted Project, User Delight, Maniphest
epriestley merged task T10970: Merge Task As Duplicate into T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
May 14 2016, 12:30 PM · Feature Request
• Azgard created T10970: Merge Task As Duplicate.
May 14 2016, 8:53 AM · Feature Request
chad deleted 2016.19.
May 14 2016, 2:53 AM
• pemup02 created 2016.19.
May 14 2016, 2:32 AM
epriestley added a comment to T10939: Support for OWNERS files.

Packages can now be reviewers. They work very similarly to project reviewers. They can be added via the web UI or Herald. They can also be added via the CLI (by typing O123 as a reviewer or subscriber) but this isn't very convenient and I don't expect users to manually add them very often / ever.

May 14 2016, 1:02 AM · Prioritized, Restricted Project, Owners
epriestley closed T9491: When packages are archived, packages shouldn't be listed as auditor as Resolved.

Archived packages are no longer added as auditors to new commits after D15907 by the "Auditing Enabled" setting.

May 14 2016, 12:36 AM · Restricted Project, Owners
epriestley closed T1258: Add an "Automatically CC Owners on Differential Revisions" checkbox to Owners as Resolved.
May 14 2016, 12:32 AM · Restricted Project, Owners
epriestley changed the status of T8887: Allow owners packages to add blocking reviewers from Duplicate to Resolved by committing Restricted Diffusion Commit.
May 14 2016, 12:22 AM · Haskell.org, Restricted Project, Owners
epriestley closed T7834: Package owners doesn't get mail after a commit triggers an audit as Resolved by committing Restricted Diffusion Commit.
May 14 2016, 12:19 AM · Restricted Project, Audit, Herald
hach-que added a comment to T10966: Let Herald move objects between Spaces.

I run into this problem a lot because workboards doesn't support custom forms yet :(

May 14 2016, 12:18 AM · Herald, Feature Request
hach-que awarded T10966: Let Herald move objects between Spaces a Like token.
May 14 2016, 12:17 AM · Herald, Feature Request
hach-que added a comment to T10969: Incorrect Phriction link in email.

Beat me to it :P

May 14 2016, 12:15 AM · Phriction, Bug Report

May 13 2016

joshuaspence created T10969: Incorrect Phriction link in email.
May 13 2016, 11:12 PM · Phriction, Bug Report
epriestley edited the content of Changelog.
May 13 2016, 10:54 PM
epriestley created 2016 Week 20 (Mid May).
May 13 2016, 10:54 PM
epriestley created T10968: File write failure during daemon operations caused daemons to populate a few too many diffs.
May 13 2016, 10:29 PM · Files, Differential, Diffusion, Daemons
csilvers added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

Oh, I see I already made that suggestion! I am nothing if not consistent.

May 13 2016, 10:18 PM · Files
csilvers added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

In the meantime, we could maybe do the following:

May 13 2016, 10:18 PM · Files
thoughtpolice moved T6483: Diffusion doesn't recognize commit landing w/ `Signed-off-by:` line from Backlog to Details on the Haskell.org board.
May 13 2016, 10:05 PM · Haskell.org, Diffusion
thoughtpolice moved T10635: Loading differential revision slow when lots of unit test messages exist from Backlog to Details on the Haskell.org board.
May 13 2016, 10:05 PM · Restricted Project, Haskell.org, Harbormaster, Performance
thoughtpolice moved T8656: Parse ANSI-style color strings in build output from Backlog to Details on the Haskell.org board.
May 13 2016, 10:04 PM · Haskell.org, Restricted Project, Harbormaster
thoughtpolice added projects to T10635: Loading differential revision slow when lots of unit test messages exist: Harbormaster, Haskell.org.
May 13 2016, 10:03 PM · Restricted Project, Haskell.org, Harbormaster, Performance
thoughtpolice added a project to T8656: Parse ANSI-style color strings in build output: Haskell.org.
May 13 2016, 10:00 PM · Haskell.org, Restricted Project, Harbormaster