Accepted diffs with not-accepted depends-on diffs should not appear under "Action Required"
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	jimbru
	Nov 5 2013, 1:14 AM

Description

Imagine there are two diffs, D1 and D2. D2 is marked "depends on" D1. D2 is accepted but D1 is not.

Currently D2 appears under "Action Required." It should, however, appear under "Waiting On Others," since there is not actually any action that I, the author, can take until D1 is also accepted.

Related Objects

Mentioned In: rPbf5437212cc8: When a revision is accepted but has open dependencies, show a note in the…
D15930: When a revision is accepted but has open dependencies, show a note in the list UI
T10939: Support for OWNERS files
T9372: Plan the future of "Bucketing" Query UIs
Mentioned Here: T10939: Support for OWNERS files
D15930: When a revision is accepted but has open dependencies, show a note in the list UI

Event Timeline

jimbru created this task.Nov 5 2013, 1:14 AM

jimbru raised the priority of this task from to Needs Triage.

jimbru updated the task description. (Show Details)

jimbru added a project: Differential.

jimbru added subscribers: jimbru, brent.

Known Issue, but not sure if we have a separate task for it exactly. You can read along here:

https://secure.phabricator.com/T1279#85 (Specifically Dashboard Bucketing).

chad edited this Maniphest Task.Nov 5 2013, 3:14 AM

chad edited this Maniphest Task.

This isn't quite the same as T1279. The situation in T1279 is:

A revision has reviewers alincoln, #security. #security is a blocking reviewer.
alincoln accepts, but #security has not yet.
alincoln views his dashboard.
The revision appears under "Blocking Others", but should appear under "Waiting on Others".