Page MenuHomePhabricator
Create Task
Maniphest T10959

Hard-coded diff line height interacts poorly with large custom font sizes
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Set Settings → Display Preferences → Monospaced Font to "24px Impact".
  • View a diff.
  • If necessary, reduce window width so that lines softwrap.

Result:

Screen Shot 2016-05-12 at 4.27.34 PM.png (365×1 px, 74 KB)

If the .differential-diff td rule line-height: 16px; is removed, this preferable rendering is produced instead:

Screen Shot 2016-05-12 at 4.30.13 PM.png (347×1 px, 68 KB)

It looks like this rule first appears in rPe284d5b5dc7d, several months before Phabricator was open sourced. Simply removing it causes some immediate obvious damage where intraline highlights have an improper baseline:

Screen Shot 2016-05-12 at 4.34.19 PM.png (51×1 px, 22 KB)

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

epriestley created this task.May 12 2016, 11:35 PM
Herald added a subscriber: eadler. · View Herald TranscriptMay 12 2016, 11:35 PM
epriestley added a revision: Restricted Differential Revision.May 12 2016, 11:42 PM
epriestley added a revision: Restricted Differential Revision.May 13 2016, 12:03 AM
epriestley added a commit: Restricted Diffusion Commit.May 13 2016, 12:10 PM
chad closed this task as Resolved by committing Restricted Diffusion Commit.May 16 2016, 5:21 PM
chad added a commit: Restricted Diffusion Commit.
epriestley mentioned this in T11236: Regression: side-by-side diffs: very long lines overflow in diffusion.Jun 30 2016, 1:20 AM
Phabricator · Built by Phacility