To reproduce:
- Set Settings → Display Preferences → Monospaced Font to "24px Impact".
- View a diff.
- If necessary, reduce window width so that lines softwrap.
Result:
If the .differential-diff td rule line-height: 16px; is removed, this preferable rendering is produced instead:
It looks like this rule first appears in rPe284d5b5dc7d, several months before Phabricator was open sourced. Simply removing it causes some immediate obvious damage where intraline highlights have an improper baseline:
