Page MenuHomePhabricator
Feed All Stories

Jun 10 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: D21346: Add an explicit "uri" to the "harbormaster.buildable.search" results.
Jun 10 2020, 5:12 PM · Arcanist
epriestley requested review of D21345: Realign "arc land" closed/published warning around more modern language.
Jun 10 2020, 4:19 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21345: Realign "arc land" closed/published warning around more modern language.
Jun 10 2020, 4:19 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The real Pandora's box this opens is that now that arc is exposed to whatever issues arise with the raw Python/Mercurial API, there's a much weaker argument against not writing more extensions.

Jun 10 2020, 3:49 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I put the extension in phabricator/ earlier by accident, but that was just me goofing my local paths. The extension is purely client side: hg can do ls-remote just fine (it's just "do hg pull, but stop half way through"), there's just no UI command for it.

Jun 10 2020, 3:42 PM · Mercurial, Arcanist
cspeckmim added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

Would the use of an extension make additional setup necessary for observed repositories vs. hosted repositories, or are observed repositories out of scope for these set of changes?

Jun 10 2020, 3:35 PM · Mercurial, Arcanist
epriestley requested review of D21344: In "arc land" in Mercurial, show a tidier "ls-remote" command.
Jun 10 2020, 3:31 PM
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21344: In "arc land" in Mercurial, show a tidier "ls-remote" command.
Jun 10 2020, 3:30 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21344: In "arc land" in Mercurial, show a tidier "ls-remote" command.
Jun 10 2020, 3:30 PM · Arcanist

Jun 9 2020

epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I am considering reviving the command server since I don't remember it having any critical failures, but offhand:

Jun 9 2020, 5:44 PM · Mercurial, Arcanist
epriestley requested review of D21343: Disambiguate various types of Mercurial remote markers with "hg arc-ls-remote".
Jun 9 2020, 5:27 PM
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21343: Disambiguate various types of Mercurial remote markers with "hg arc-ls-remote".
Jun 9 2020, 5:27 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21343: Disambiguate various types of Mercurial remote markers with "hg arc-ls-remote".
Jun 9 2020, 5:27 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I'm going to try writing a Mercurial extension instead.

Jun 9 2020, 4:23 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I believe this is roughly the form we end up with, which is completely ridiculous and extremely difficult to test or have any confidence in:

Jun 9 2020, 3:27 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

As a tool developer, this kind of thing is infuriating:

Jun 9 2020, 3:14 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

This is also made more complicated because Mercurial branches and bookmarks are all in a single shared namespace to some degree. I'm not sure what happens if you try to fetch a bookmark that conflicts with a local branch name (presumably: it renames it as "divergent"?) or try to fetch a branch which conflicts with a local bookmark name (presumably: fails in a way that's hard to detect?).

Jun 9 2020, 2:14 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

When the user specifies arc land --onto marker, I'd like to identify whether marker is a bookmark or branch.

Jun 9 2020, 1:58 PM · Mercurial, Arcanist
epriestley requested review of D21342: Verify remotes ("paths") in Mercurial during "arc land".
Jun 9 2020, 1:36 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21342: Verify remotes ("paths") in Mercurial during "arc land".
Jun 9 2020, 1:35 PM · Arcanist
epriestley moved T13214: When there is no remote Mercurial URI, `hg paths default` exits with an error code from Backlog to arc land on the Arcanist board.
Jun 9 2020, 1:07 PM · Mercurial, Arcanist
epriestley moved T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark" from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Guides, Arcanist
epriestley moved T13545: Upgrading: Mid 2020 Changes to "arc diff" from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist, Guides
epriestley moved T13544: Modernize the "arc diff" workflow from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist
epriestley moved T13490: Upgrade all "classic" Arcanist workflows to Toolsets from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist
epriestley closed T13488: Upgrading: Early 2020 Changes to Arcanist as Resolved.

See T13545, T13547, T13548, for the next round.

Jun 9 2020, 2:09 AM · Arcanist, Installing & Upgrading
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`, as Resolved.
Jun 9 2020, 12:32 AM · Prioritized, Restricted Project, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked, as Resolved.
Jun 9 2020, 12:32 AM · Differential, Arcanist, Feature Request
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T6072: Improve usability of `arc diff`, as Resolved.
Jun 9 2020, 12:32 AM · Restricted Project, Documentation, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist as Resolved.

This approximately exists now via T11968.

Jun 9 2020, 12:32 AM · Restricted Project, Prioritized, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`, as Resolved.
Jun 9 2020, 12:32 AM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley closed T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote as Resolved.

I'm not 100% sure I got this, but all of these seem to work now:

Jun 9 2020, 12:29 AM · Arcanist

Jun 8 2020

epriestley committed rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch (authored by epriestley).
Refine "arc land" behavior when pushing "onto" a new branch
Jun 8 2020, 11:56 PM
epriestley closed D21341: Refine "arc land" behavior when pushing "onto" a new branch.
Jun 8 2020, 11:56 PM
epriestley requested review of D21341: Refine "arc land" behavior when pushing "onto" a new branch.
Jun 8 2020, 11:56 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21341: Refine "arc land" behavior when pushing "onto" a new branch.
Jun 8 2020, 11:56 PM · Arcanist
epriestley committed rARCab70626c1226: Support "arc land --pick" to pick specific changes out of a sequence (authored by epriestley).
Support "arc land --pick" to pick specific changes out of a sequence
Jun 8 2020, 11:31 PM
epriestley closed D21340: Support "arc land --pick" to pick specific changes out of a sequence.
Jun 8 2020, 11:30 PM
epriestley committed rARC7ddaed9aba1a: Improve "arc land" behavior in the presence of merge conflicts and change… (authored by epriestley).
Improve "arc land" behavior in the presence of merge conflicts and change…
Jun 8 2020, 11:30 PM
epriestley closed D21339: Improve "arc land" behavior in the presence of merge conflicts and change sequences.
Jun 8 2020, 11:30 PM
epriestley committed rARCb003cf93102c: Remove "arc feature", "arc branch", "arc bookmark", and significant chunks of… (authored by epriestley).
Remove "arc feature", "arc branch", "arc bookmark", and significant chunks of…
Jun 8 2020, 11:27 PM
epriestley committed rARC3d64140ff31c: Implement "arc work", to replace "arc feature" (authored by epriestley).
Implement "arc work", to replace "arc feature"
Jun 8 2020, 11:27 PM
epriestley closed D21337: Remove "arc feature", "arc branch", "arc bookmark", and significant chunks of obsolete marker code.
Jun 8 2020, 11:27 PM
epriestley committed rARC5abf0b96c8d9: Use MarkerRefs to resolve landing symbols in Mercurial (authored by epriestley).
Use MarkerRefs to resolve landing symbols in Mercurial
Jun 8 2020, 11:27 PM
epriestley closed D21336: Implement "arc work", to replace "arc feature".
Jun 8 2020, 11:27 PM
epriestley closed D21335: Use MarkerRefs to resolve landing symbols in Mercurial.
Jun 8 2020, 11:27 PM
epriestley committed rARC599ba0f999fd: Provide a more powerful query mechanism for "markers" (branches/bookmarks) (authored by epriestley).
Provide a more powerful query mechanism for "markers" (branches/bookmarks)
Jun 8 2020, 11:27 PM
epriestley closed D21333: Provide a more powerful query mechanism for "markers" (branches/bookmarks).
Jun 8 2020, 11:27 PM
epriestley committed rARCe8c3cc32897e: Allow "arc" to accept any prefix of a command as that command (authored by epriestley).
Allow "arc" to accept any prefix of a command as that command
Jun 8 2020, 11:27 PM
epriestley closed D21338: Allow "arc" to accept any prefix of a command as that command.
Jun 8 2020, 11:27 PM
epriestley committed rARC31d08f9a8faf: Remove old Mercurial code testing for rebase and phase support (authored by epriestley).
Remove old Mercurial code testing for rebase and phase support
Jun 8 2020, 11:26 PM
epriestley closed D21334: Remove old Mercurial code testing for rebase and phase support.
Jun 8 2020, 11:26 PM
epriestley committed rARC78e9cc9c0129: Add a check for ambiguous merge strategies after the "history.immutable"… (authored by epriestley).
Add a check for ambiguous merge strategies after the "history.immutable"…
Jun 8 2020, 11:26 PM
epriestley committed rARCc5192bde3445: Allow users to save prompt responses in "arc" workflows (authored by epriestley).
Allow users to save prompt responses in "arc" workflows
Jun 8 2020, 11:26 PM
epriestley committed rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD (authored by epriestley).
Format "arc land" passthru commands more nicely, and execute them from CWD
Jun 8 2020, 11:26 PM
epriestley closed D21332: Add a check for ambiguous merge strategies after the "history.immutable" behavioral change.
Jun 8 2020, 11:26 PM
epriestley closed D21330: Format "arc land" passthru commands more nicely, and execute them from CWD.
Jun 8 2020, 11:26 PM
epriestley closed D21331: Allow users to save prompt responses in "arc" workflows.
Jun 8 2020, 11:26 PM
epriestley closed T13380: `git push` fatals when CWD does not exist as Resolved by committing rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD.
Jun 8 2020, 11:26 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

Screen Shot 2020-06-08 at 4.23.04 PM.png (1×1 px, 932 KB)

Jun 8 2020, 11:24 PM · Arcanist
epriestley committed rARCb62919f7e48a: Show some "arc" help pages through a configurable pager, like "less" (authored by epriestley).
Show some "arc" help pages through a configurable pager, like "less"
Jun 8 2020, 11:23 PM
epriestley committed rARC4d61c005310e: Improve final messages under "arc land --hold" (authored by epriestley).
Improve final messages under "arc land --hold"
Jun 8 2020, 11:23 PM
epriestley committed rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"… (authored by epriestley).
Improve the logic for identifying ambiguous commits and applying "--revision"…
Jun 8 2020, 11:23 PM
epriestley committed rARCa30378a34ab1: Update "arc help land" (authored by epriestley).
Update "arc help land"
Jun 8 2020, 11:23 PM
epriestley committed rARC0bf4da60f6d6: Make Mercurial use "hg shelve" and "hg unshelve" in dirty working copies in… (authored by epriestley).
Make Mercurial use "hg shelve" and "hg unshelve" in dirty working copies in…
Jun 8 2020, 11:23 PM
epriestley closed D21329: Make Mercurial use "hg shelve" and "hg unshelve" in dirty working copies in "arc land".
Jun 8 2020, 11:22 PM
epriestley closed D21327: Show some "arc" help pages through a configurable pager, like "less".
Jun 8 2020, 11:22 PM
epriestley closed D21328: Improve final messages under "arc land --hold".
Jun 8 2020, 11:22 PM
epriestley closed T5420: Pipe output to a pager as Resolved by committing rARCb62919f7e48a: Show some "arc" help pages through a configurable pager, like "less".
Jun 8 2020, 11:22 PM · Arcanist, libphutil
epriestley closed D21326: Update "arc help land".
Jun 8 2020, 11:22 PM
epriestley closed D21325: Improve the logic for identifying ambiguous commits and applying "--revision" to them.
Jun 8 2020, 11:22 PM
epriestley committed rARC8a53b5a4517d: When landing changes in an empty repository, merge cleanly in Git (authored by epriestley).
When landing changes in an empty repository, merge cleanly in Git
Jun 8 2020, 11:20 PM
epriestley closed D21324: When landing changes in an empty repository, merge cleanly in Git.
Jun 8 2020, 11:20 PM
epriestley committed rARC94f78cf87c78: Provide more information about merge progress in "arc land" under Git (authored by epriestley).
Provide more information about merge progress in "arc land" under Git
Jun 8 2020, 11:20 PM
epriestley closed T12876: Improve initial arc land experience when destination repo is empty as Resolved by committing rARC8a53b5a4517d: When landing changes in an empty repository, merge cleanly in Git.
Jun 8 2020, 11:20 PM · Arcanist
epriestley committed rARC57d0d690cc76: Modernize output when pruning branches in Git during "arc land" (authored by epriestley).
Modernize output when pruning branches in Git during "arc land"
Jun 8 2020, 11:20 PM
epriestley closed D21318: Provide more information about merge progress in "arc land" under Git.
Jun 8 2020, 11:20 PM
epriestley closed D21319: Modernize output when pruning branches in Git during "arc land".
Jun 8 2020, 11:20 PM
epriestley committed rARC1552397c8695: Sometimes discard already-closed revisions in "arc land" (authored by epriestley).
Sometimes discard already-closed revisions in "arc land"
Jun 8 2020, 11:17 PM
epriestley committed rARC68f28a171888: Substantially modernize the "arc land" workflow (authored by epriestley).
Substantially modernize the "arc land" workflow
Jun 8 2020, 11:17 PM
epriestley committed rARC6fb84e5164cc: Add a synopsis and example for "arc help land" (authored by epriestley).
Add a synopsis and example for "arc help land"
Jun 8 2020, 11:17 PM
epriestley committed rARC25afb93f7ad4: In "arc land", rebase branches in natural order (authored by epriestley).
In "arc land", rebase branches in natural order
Jun 8 2020, 11:17 PM
epriestley closed D21322: Sometimes discard already-closed revisions in "arc land".
Jun 8 2020, 11:17 PM
epriestley closed D21321: Add a synopsis and example for "arc help land".
Jun 8 2020, 11:17 PM
epriestley closed D21320: In "arc land", rebase branches in natural order.
Jun 8 2020, 11:17 PM
epriestley closed D21315: Substantially modernize the "arc land" workflow.
Jun 8 2020, 11:17 PM
epriestley requested review of D21340: Support "arc land --pick" to pick specific changes out of a sequence.
Jun 8 2020, 11:17 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21340: Support "arc land --pick" to pick specific changes out of a sequence.
Jun 8 2020, 11:16 PM · Arcanist
epriestley committed rARC7d615a97e240: In "arc branch" output, sort branches updated in the same second by name (authored by epriestley).
In "arc branch" output, sort branches updated in the same second by name
Jun 8 2020, 11:04 PM
epriestley closed D21316: In "arc branch" output, sort branches updated in the same second by name.
Jun 8 2020, 11:04 PM
epriestley committed rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff" (authored by epriestley).
Remove "--ignore-unsound-tests" from "arc diff"
Jun 8 2020, 10:58 PM
epriestley closed D21303: Remove "--ignore-unsound-tests" from "arc diff".
Jun 8 2020, 10:58 PM
epriestley committed rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt… (authored by epriestley).
When "arc" receives SIGWINCH or other signals during display of a prompt…
Jun 8 2020, 10:57 PM
epriestley closed D21317: When "arc" receives SIGWINCH or other signals during display of a prompt, recover.
Jun 8 2020, 10:57 PM
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 8 2020, 10:54 PM · Guides, Arcanist
epriestley requested review of D21339: Improve "arc land" behavior in the presence of merge conflicts and change sequences.
Jun 8 2020, 10:43 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21339: Improve "arc land" behavior in the presence of merge conflicts and change sequences.
Jun 8 2020, 10:42 PM · Arcanist
epriestley committed rARC7ac3b791b05a: Provide modern config options for "arc land" configuration (authored by epriestley).
Provide modern config options for "arc land" configuration
Jun 8 2020, 10:40 PM
epriestley committed rARC0da395ffe4c9: Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy… (authored by epriestley).
Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy…
Jun 8 2020, 10:40 PM
epriestley closed D21313: Provide modern config options for "arc land" configuration.
Jun 8 2020, 10:40 PM