Allow "arc" to accept any prefix of a command as that command
ClosedPublic
Actions

Authored by epriestley on Jun 8 2020, 9:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 7:37 PM

	Unknown Object (File)
	Tue, Dec 17, 9:58 PM

	Unknown Object (File)
	Fri, Dec 13, 6:30 AM

	Unknown Object (File)
	Thu, Dec 12, 10:33 PM

	Unknown Object (File)
	Thu, Dec 12, 12:25 AM

	Unknown Object (File)
	Tue, Dec 10, 1:33 AM

	Unknown Object (File)
	Sun, Dec 8, 6:32 AM

	Unknown Object (File)
	Sun, Dec 8, 5:37 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARCe8c3cc32897e: Allow "arc" to accept any prefix of a command as that command

Summary

Ref T13546. Practically, this allows "arc branch" to run "arc branches".

(This risks overcorrection to some degree, but command correction only occurs if stdout is a TTY so the risk seems limited.)

Test Plan

Ran "arc branch", got "arc branches" as a correction.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 8 2020, 9:53 PM

Harbormaster completed remote builds in B24592: Diff 50771.Jun 8 2020, 9:53 PM

epriestley requested review of this revision.Jun 8 2020, 9:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:27 PM

Closed by commit rARCe8c3cc32897e: Allow "arc" to accept any prefix of a command as that command (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe8c3cc32897e: Allow "arc" to accept any prefix of a command as that command.

Revision Contents
Changeset List

Path

Size

src/

parser/

argument/

PhutilArgumentSpellingCorrector.php

15 lines

Diff 50797

View Options

src/parser/argument/PhutilArgumentSpellingCorrector.php

Allow "arc" to accept any prefix of a command as that commandClosedPublicActions