Page MenuHomePhabricator

Improve the logic for identifying ambiguous commits and applying "--revision" to them
ClosedPublic

Authored by epriestley on Jun 7 2020, 3:53 PM.
Tags
None
Referenced Files
F19045404: D21325.id50755.diff
Thu, Nov 27, 7:26 AM
F19045335: D21325.id50755.diff
Thu, Nov 27, 7:09 AM
F19010081: D21325.diff
Sat, Nov 22, 1:55 AM
F18998646: D21325.id.diff
Thu, Nov 20, 7:21 PM
F18994002: D21325.diff
Wed, Nov 19, 9:36 AM
F18978215: D21325.diff
Sun, Nov 16, 7:30 PM
F18952849: D21325.id50755.diff
Wed, Nov 12, 6:37 AM
F18902481: D21325.id50789.diff
Sat, Nov 8, 1:30 AM
Subscribers
None

Details

Summary

Ref T13546. This is mostly minor cleanup that improves behavior under "--revision".

Test Plan

Ran arc land --into-empty and arc land --into-empty --revision 123 with ambiguous revisions in history to hit both the force and non-force outcomes.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM
This revision was automatically updated to reflect the committed changes.