Improve the logic for identifying ambiguous commits and applying "--revision" to them
ClosedPublic
Actions

Authored by epriestley on Jun 7 2020, 3:53 PM.

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"…

Summary

Ref T13546. This is mostly minor cleanup that improves behavior under "--revision".

Test Plan

Ran arc land --into-empty and arc land --into-empty --revision 123 with ambiguous revisions in history to hit both the force and non-force outcomes.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 7 2020, 3:53 PM

Harbormaster completed remote builds in B24577: Diff 50755.Jun 7 2020, 3:53 PM

epriestley requested review of this revision.Jun 7 2020, 3:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM

Closed by commit rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC709c9cb6fbe8: Improve the logic for identifying ambiguous commits and applying "--revision"….

Revision Contents
Changeset List

Path

Size

src/

land/

ArcanistLandCommit.php

10 lines

engine/

ArcanistLandEngine.php

179 lines

Diff 50789

View Options

src/land/ArcanistLandCommit.php