Page MenuHomePhabricator

Improve the logic for identifying ambiguous commits and applying "--revision" to them
ClosedPublic

Authored by epriestley on Jun 7 2020, 3:53 PM.

Details

Summary

Ref T13546. This is mostly minor cleanup that improves behavior under "--revision".

Test Plan

Ran arc land --into-empty and arc land --into-empty --revision 123 with ambiguous revisions in history to hit both the force and non-force outcomes.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 7 2020, 3:53 PM
epriestley requested review of this revision.Jun 7 2020, 3:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM
This revision was automatically updated to reflect the committed changes.