Page MenuHomePhabricator

In "arc land" in Mercurial, show a tidier "ls-remote" command
ClosedPublic

Authored by epriestley on Jun 10 2020, 3:30 PM.

Details

Summary

Ref T9948. Ref T13546. We must passthru "hg ls-remote" because it might prompt the user for credentials.

Since "ls-remote" is implemented as an exension and we can't rely on using stdout beacuse of passthru, the actual command we execute is:

$ hg --config extensions.arc-hg=<huge long path to extension> arc-ls-remote --output <huge long path to temporary file> -- remote

This is meaningless and distracting; show the intent of the command we're executing instead. Users can see the raw command in "--trace" if they're actually debugging behavior.

Test Plan

Ran "arc land" in a Mercurial repository, got a tidier command output.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 10 2020, 3:30 PM
epriestley requested review of this revision.Jun 10 2020, 3:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.