Page MenuHomePhabricator

Refine "arc land" behavior when pushing "onto" a new branch
ClosedPublic

Authored by epriestley on Jun 8 2020, 11:56 PM.
Tags
None
Referenced Files
F15435789: D21341.id.diff
Tue, Mar 25, 10:12 AM
F15430202: D21341.diff
Mon, Mar 24, 6:26 AM
F15407477: D21341.id50804.diff
Tue, Mar 18, 5:42 PM
F15400886: D21341.diff
Mon, Mar 17, 2:30 PM
F15377232: D21341.id50805.diff
Thu, Mar 13, 8:26 AM
Unknown Object (File)
Tue, Feb 25, 3:01 AM
Unknown Object (File)
Feb 18 2025, 11:11 AM
Unknown Object (File)
Feb 16 2025, 4:49 PM
Subscribers
None

Details

Summary

Ref T13546. If the "onto" branch doesn't exist yet and has a "/" in it, we need to preface it with "refs/heads" explicitly.

Fix a "false/null" issue with argument validation.

Possibly, "arc land" should prompt you before creating branches in the remote.

Test Plan

Ran "arc land --onto does-not-exist/1.1" and created a branch.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:56 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.