Page MenuHomePhabricator

Refine "arc land" behavior when pushing "onto" a new branch
ClosedPublic

Authored by epriestley on Jun 8 2020, 11:56 PM.
Tags
None
Referenced Files
F15377232: D21341.id50805.diff
Thu, Mar 13, 8:26 AM
Unknown Object (File)
Tue, Feb 25, 3:01 AM
Unknown Object (File)
Tue, Feb 18, 11:11 AM
Unknown Object (File)
Sun, Feb 16, 4:49 PM
Unknown Object (File)
Wed, Feb 12, 2:42 AM
Unknown Object (File)
Feb 9 2025, 9:36 AM
Unknown Object (File)
Feb 9 2025, 9:35 AM
Unknown Object (File)
Feb 9 2025, 9:35 AM
Subscribers
None

Details

Summary

Ref T13546. If the "onto" branch doesn't exist yet and has a "/" in it, we need to preface it with "refs/heads" explicitly.

Fix a "false/null" issue with argument validation.

Possibly, "arc land" should prompt you before creating branches in the remote.

Test Plan

Ran "arc land --onto does-not-exist/1.1" and created a branch.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:56 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.