Page MenuHomePhabricator

Refine "arc land" behavior when pushing "onto" a new branch

Authored by epriestley on Jun 8 2020, 11:56 PM.



Ref T13546. If the "onto" branch doesn't exist yet and has a "/" in it, we need to preface it with "refs/heads" explicitly.

Fix a "false/null" issue with argument validation.

Possibly, "arc land" should prompt you before creating branches in the remote.

Test Plan

Ran "arc land --onto does-not-exist/1.1" and created a branch.

Diff Detail

rARC Arcanist
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 8 2020, 11:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:56 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.