Page MenuHomePhabricator

Refine "arc land" behavior when pushing "onto" a new branch
ClosedPublic

Authored by epriestley on Jun 8 2020, 11:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 30, 3:39 AM
Unknown Object (File)
Wed, Nov 29, 8:47 AM
Unknown Object (File)
Sat, Nov 25, 11:44 PM
Unknown Object (File)
Thu, Nov 16, 3:04 PM
Unknown Object (File)
Oct 25 2023, 6:09 AM
Unknown Object (File)
Oct 22 2023, 7:31 AM
Unknown Object (File)
Sep 7 2023, 7:04 AM
Unknown Object (File)
Sep 7 2023, 2:31 AM
Subscribers
None

Details

Summary

Ref T13546. If the "onto" branch doesn't exist yet and has a "/" in it, we need to preface it with "refs/heads" explicitly.

Fix a "false/null" issue with argument validation.

Possibly, "arc land" should prompt you before creating branches in the remote.

Test Plan

Ran "arc land --onto does-not-exist/1.1" and created a branch.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:56 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.