Refine "arc land" behavior when pushing "onto" a new branch
ClosedPublic
Actions

Authored by epriestley on Jun 8 2020, 11:56 PM.

Tags

None

Referenced Files

	F15524836: D21341.id50805.diff
	Mon, Apr 21, 10:41 AM

	F15497352: D21341.diff
	Sun, Apr 13, 10:21 AM

	F15494298: D21341.diff
	Sat, Apr 12, 11:10 PM

	F15490228: D21341.id50805.diff
	Fri, Apr 11, 3:24 PM

	F15485250: D21341.diff
	Wed, Apr 9, 10:53 PM

	F15470935: D21341.id50805.diff
	Sat, Apr 5, 2:15 AM

	F15459784: D21341.id50805.diff
	Mon, Mar 31, 4:13 PM

	F15445946: D21341.id50804.diff
	Thu, Mar 27, 4:41 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch

Summary

Ref T13546. If the "onto" branch doesn't exist yet and has a "/" in it, we need to preface it with "refs/heads" explicitly.

Fix a "false/null" issue with argument validation.

Possibly, "arc land" should prompt you before creating branches in the remote.

Test Plan

Ran "arc land --onto does-not-exist/1.1" and created a branch.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 8 2020, 11:56 PM

Harbormaster completed remote builds in B24625: Diff 50804.Jun 8 2020, 11:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:56 PM

epriestley requested review of this revision.

Closed by commit rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch.

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistGitLandEngine.php

7 lines

ArcanistLandEngine.php

2 lines

Diff 50805

View Options

src/land/engine/ArcanistGitLandEngine.php