Page MenuHomePhabricator

When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic

Authored by epriestley on Jun 5 2020, 11:07 PM.

Details

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 5 2020, 11:07 PM
epriestley requested review of this revision.Jun 5 2020, 11:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.