Page MenuHomePhabricator

When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic

Authored by epriestley on Jun 5 2020, 11:07 PM.
Tags
None
Referenced Files
F18198669: D21317.diff
Mon, Aug 18, 1:09 AM
F18101153: D21317.id.diff
Sat, Aug 9, 12:21 PM
F18086872: D21317.id50777.diff
Wed, Aug 6, 12:50 AM
F18052771: D21317.id.diff
Mon, Aug 4, 3:24 AM
F18050520: D21317.diff
Sun, Aug 3, 8:13 PM
F17746920: D21317.diff
Jul 21 2025, 9:06 PM
F17744119: D21317.id50745.diff
Jul 21 2025, 3:17 PM
Unknown Object (File)
Jun 5 2025, 4:57 PM
Subscribers
None

Details

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.