When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic
Actions

Authored by epriestley on Jun 5 2020, 11:07 PM.

Tags

None

Referenced Files

	F15497306: D21317.diff
	Sun, Apr 13, 10:17 AM

	F15469366: D21317.diff
	Fri, Apr 4, 12:27 PM

	F15460503: D21317.id50777.diff
	Mon, Mar 31, 11:22 PM

	F15455585: D21317.id.diff
	Sun, Mar 30, 3:24 AM

	F15454094: D21317.diff
	Sat, Mar 29, 4:17 PM

	F15424089: D21317.diff
	Sat, Mar 22, 8:07 PM

	F15407768: D21317.id.diff
	Tue, Mar 18, 7:27 PM

	F15390439: D21317.id50745.diff
	Mar 15 2025, 6:12 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt…

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 5 2020, 11:07 PM

Harbormaster completed remote builds in B24567: Diff 50745.Jun 5 2020, 11:07 PM

epriestley requested review of this revision.Jun 5 2020, 11:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM

Closed by commit rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC3ed81d35a23a: When "arc" receives SIGWINCH or other signals during display of a prompt….

Revision Contents
Changeset List

Path

Size

src/

toolset/

ArcanistPrompt.php

26 lines

Diff 50777

View Options

src/toolset/ArcanistPrompt.php

When "arc" receives SIGWINCH or other signals during display of a prompt, recoverClosedPublicActions