Page MenuHomePhabricator

When "arc" receives SIGWINCH or other signals during display of a prompt, recover
ClosedPublic

Authored by epriestley on Jun 5 2020, 11:07 PM.
Tags
None
Referenced Files
F18763162: D21317.diff
Mon, Oct 6, 10:59 PM
F18758491: D21317.id50777.diff
Sun, Oct 5, 10:33 PM
F18740321: D21317.id.diff
Thu, Oct 2, 2:05 AM
F18738267: D21317.diff
Wed, Oct 1, 2:56 PM
F18460028: D21317.id50777.diff
Sep 1 2025, 6:30 PM
F18440880: D21317.diff
Aug 31 2025, 4:05 PM
F18198669: D21317.diff
Aug 18 2025, 1:09 AM
F18101153: D21317.id.diff
Aug 9 2025, 12:21 PM
Subscribers
None

Details

Summary

Ref T13546. Resizing the terminal window to send SIGWINCH, or other signals, may interrupt "stream_select()" with an error which upgrades to a RuntimeException.

When "stream_select()" fails, continue and test the stream itself.

Test Plan

Waited for a prompt, resized the window. Before patch: SIGWINCH interruption. After patch: undisturbed prompt.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.