Page MenuHomePhabricator
Feed All Stories

Apr 29 2016

epriestley added a revision to T10905: Cannot triple-click to select task title in phabricator (due to icon in the title): Unknown Object (Differential Revision).
Apr 29 2016, 11:40 PM · Bug Report
epriestley added a comment to T10906: Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color.

Can you point us at where in the UI these are used, exactly? Just want to make sure we're fixing the right thing.

Apr 29 2016, 11:32 PM · Bug Report
getaaron created T10906: Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color.
Apr 29 2016, 11:31 PM · Bug Report
cspeckmim added a comment to T10890: Less chatty Maniphest feed rendering.

@fooishbar - would something like a "collapsed" or "comments-only" view be what you're thinking of? In the example comments you listed there was a 6-month time-span between the two comments. Having ~30 events listed seems natural for a popular task. If it was a few days to a week that would be more frustrating/difficult to read, but I also imagine far less common.

Apr 29 2016, 11:23 PM · Maniphest, Feature Request
Danny_B added a member for Wikimedia: Danny_B.
Apr 29 2016, 11:15 PM
avivey closed T10904: qa as Wontfix.
Apr 29 2016, 10:50 PM · Feature Request
Twilight added a member for Wikimedia: Twilight.
Apr 29 2016, 10:22 PM
Twilight added a watcher for Wikimedia: Twilight.
Apr 29 2016, 10:22 PM
quiddity created T10905: Cannot triple-click to select task title in phabricator (due to icon in the title).
Apr 29 2016, 10:12 PM · Bug Report
• percenuage created T10904: qa.
Apr 29 2016, 10:07 PM · Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 29 2016, 9:25 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 29 2016, 8:38 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
gurrinder awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Apr 29 2016, 8:01 PM · Workboards (v3), Restricted Project
rfreebern added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

Oh, one problem with that script: when you move all the subprojects or milestones out from under a parent, it doesn't set the parent's hasMilestones or hasSubprojects fields to 0 for you. That'll have to be done by hand in the database.

Apr 29 2016, 7:25 PM · Projects (v3)
rfreebern added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

I'm in the position where I need to re-parent an existing hierarchy of projects, which isn't supported by @epriestley's move_beneath.php above. Rather than attempt to figure out everything involved in doing that (which I think is mostly messing with the various projects' path, pathKey, and depth fields, in case anyone wants to try) I threw this script together to move an existing subproject or milestone to root level, where it can then be moved using move_beneath.php.

Apr 29 2016, 7:09 PM · Projects (v3)
rftfaria added a comment to T9213: Unable to set up a GIT hosted repository.

@storrgie, since it was a test environment, I disabled it

Apr 29 2016, 6:22 PM · Diffusion
monsdar awarded T5051: Burn down charts for Milestones a Like token.
Apr 29 2016, 6:03 PM · Restricted Project, Wikimedia, Projects
chad updated the task description for T4947: SELinux / AppArmor ruin everything all the time.
Apr 29 2016, 5:29 PM · Setup
epriestley created T10903: Customize "open in new window" link behavior for RemarkupEngine.
Apr 29 2016, 5:26 PM · Phacility, Remarkup
epriestley added a project to T10901: Support title art for Phame blogs: Phacility.
Apr 29 2016, 5:21 PM · Phacility, Phame
epriestley created T10902: Support third-party package definitions in Celerity, or remember how it works if I already built it.
Apr 29 2016, 5:20 PM · Phacility, Celerity
chad added a comment to T10901: Support title art for Phame blogs.

plustwo

Apr 29 2016, 5:14 PM · Phacility, Phame
epriestley created T10901: Support title art for Phame blogs.
Apr 29 2016, 5:13 PM · Phacility, Phame
frederic.marbach created T10900: Repository content search with `hg grep` returns matches found in old versions of files.
Apr 29 2016, 5:08 PM · Mercurial, Diffusion
eadler closed T10892: Recommend pip instead of easy_install for Python linters as Resolved by committing Restricted Diffusion Commit.
Apr 29 2016, 3:45 PM · Lint, Arcanist, Feature Request
chad added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

We can clean this up for phortune a bit better.

Apr 29 2016, 3:39 PM · Design, Bug Report
epriestley added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

This is the expected method.

Apr 29 2016, 3:11 PM · Design, Bug Report
jparise added a comment to T10622: Auto add reviewers based on custom logic.

For reference, the Chromium project has a formal definition of their OWNERS files, including parsing code (in Python).

Apr 29 2016, 3:10 PM · Restricted Project, Arcanist, Feature Request
swisspol added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

BTW is the print action the expected method to get an "invoice" for my records? Or can you download a formal invoice from somewhere?

Apr 29 2016, 3:08 PM · Design, Bug Report
epriestley renamed T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts from "Printable version" does not appear to have any effect on order page in Phortune / Phacility to Print CSS does not fold/hide curtains for object pages like Phortune carts.
Apr 29 2016, 3:06 PM · Design, Bug Report
epriestley added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

It has the visible effect of removing the page header and footer.

Apr 29 2016, 3:06 PM · Design, Bug Report
epriestley closed T10896: Changing repository from hosted to fetched fails as Resolved.
Apr 29 2016, 3:04 PM · Bug Report
epriestley added a comment to T10896: Changing repository from hosted to fetched fails.

The heuristic only triggers if the repository was previously empty. So it might possibly get a false positive on the very first pull request to a new empty repository, but should be fine after that.

Apr 29 2016, 3:04 PM · Bug Report
swisspol created T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.
Apr 29 2016, 2:36 PM · Design, Bug Report
fooishbar added a comment to T10896: Changing repository from hosted to fetched fails.

@epriestley Is there a way to disable T9554's heuristics? With patchsets of 30+ patches which get pushed in a single atomic bundle, we don't want to go back to import mode and lose all notifications.

Apr 29 2016, 2:21 PM · Bug Report
cburroughs moved T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 29 2016, 2:16 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
cburroughs added a project to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Restricted Project.
Apr 29 2016, 2:15 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
fooishbar added a comment to T10896: Changing repository from hosted to fetched fails.

@epriestley Thanks for the thorough response. I guess it's probably been fixed in intermediate revisions, and as you say, it is all changing pretty dramatically anyway, so no big deal: as it was a newly-created repository, I just scrapped it and created anew.

Apr 29 2016, 2:06 PM · Bug Report
epriestley renamed T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD` from easy browsing of revision of current branch to Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
Apr 29 2016, 1:53 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a comment to T10896: Changing repository from hosted to fetched fails.

Note that when you do this, you may generate a large amount of email you don't want, because you're adding commits to a repository which was previously marked as fully imported (it "completed" the import process when it was an empty, hosted repository). You may want to disable publishing in "Publish/Notify". See also T9554.

Apr 29 2016, 1:52 PM · Bug Report
epriestley added a comment to T10896: Changing repository from hosted to fetched fails.

I can't reproduce this. Here's what I tried. First, I created a new, empty, hosted Git repository:

Apr 29 2016, 1:49 PM · Bug Report
epriestley closed T10897: Recovering a lost room in Conpherence as Resolved.

If you know the ID/monogram of the room (should be in the subject of any email you received, looks like Z123), I think you can also bin/policy unlock Zxxx it, which should make it public. Then you should be able to rejoin it.

Apr 29 2016, 1:39 PM · Conpherence, Bug Report
epriestley added a comment to T10898: testing.

@benjumanji, I added you to Community so you should have some new powers to abuse.

Apr 29 2016, 1:33 PM · Feature Request
epriestley added a member for Community: benjumanji.
Apr 29 2016, 1:32 PM
epriestley closed T10898: testing as Spite.
Apr 29 2016, 1:32 PM · Feature Request
monsdar added a comment to T10662: Cycle redirect at first connection.

Hm, Problem solved:
In my case there has been ServerName FooAddress defined in the default-server.conf while my vhost for Phabricator was configured to ServerName FooAddress.FullAddress.com. It seems as if Phabricator then was jumping between those two addresses?

Apr 29 2016, 11:59 AM · Bug Report
monsdar added a comment to T10662: Cycle redirect at first connection.

I'm sorry for bringing this up again - I've got the exact same problem and there's nowhere else to discuss the issue.

Apr 29 2016, 10:53 AM · Bug Report
Chiel92 added a comment to T10893: repo update fails for repos with 1000s of closing branches.

@avivey Turning off the autoclose feature, fixed the error. I'm fine with this. Thanks for the pointer!

Apr 29 2016, 9:22 AM · Diffusion, Bug Report
benjumanji added a comment to T10898: testing.

Right at the top of the home page...

Apr 29 2016, 8:59 AM · Feature Request
• vicngtor added a comment to T10898: testing.

Can someone please help me delete this?

Apr 29 2016, 8:19 AM · Feature Request
• vicngtor created T10898: testing.
Apr 29 2016, 8:18 AM · Feature Request
eadler added a comment to T10897: Recovering a lost room in Conpherence.

you can likely manually modify the conference_participant table in ${NAMESPACE}_conpherence. The structure is straightforward.
This is likely not a good idea to do on a regular basis.

Apr 29 2016, 7:16 AM · Conpherence, Bug Report
frederic.marbach created T10897: Recovering a lost room in Conpherence.
Apr 29 2016, 6:55 AM · Conpherence, Bug Report
fooishbar created T10896: Changing repository from hosted to fetched fails.
Apr 29 2016, 6:51 AM · Bug Report
eadler added a revision to T10038: Plan the mid-term pathway for unit-test/linter bindings: Unknown Object (Differential Revision).
Apr 29 2016, 4:57 AM · Lint, Arcanist
eadler added a revision to T10892: Recommend pip instead of easy_install for Python linters: Unknown Object (Differential Revision).
Apr 29 2016, 4:57 AM · Lint, Arcanist, Feature Request
eadler claimed T10892: Recommend pip instead of easy_install for Python linters.
Apr 29 2016, 4:55 AM · Lint, Arcanist, Feature Request
jayvdb awarded T10747: Import and export ICS from Calendar a Mountain of Wealth token.
Apr 29 2016, 2:58 AM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7789: Support Git Large File Storage.

Great, I'm glad to hear things are working for you. Thanks for your help testing this out!

Apr 29 2016, 1:14 AM · Customer Impact, Restricted Project, Files, Diffusion

Apr 28 2016

epriestley updated the task description for T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 28 2016, 8:49 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 8:35 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10366: General support for multiple URIs for a repository: Unknown Object (Differential Revision).
Apr 28 2016, 8:35 PM · Diffusion (v3), Restricted Project, Feature Request
avivey added a comment to T10893: repo update fails for repos with 1000s of closing branches.

Interestingly, if I cut and paste the whole command (Over 4200 hashes) on the command line, it works fine (I think my command line limit is at 2MB on Ubuntu 14.4).

Apr 28 2016, 7:49 PM · Diffusion, Bug Report
avivey updated the task description for T10893: repo update fails for repos with 1000s of closing branches.
Apr 28 2016, 7:32 PM · Diffusion, Bug Report
avivey renamed T10893: repo update fails for repos with 1000s of closing branches from Git log command fails on large repository to repo update fails for repos with 1000s of closing branches.
Apr 28 2016, 7:32 PM · Diffusion, Bug Report
chad changed the image for Image Macro "worldburn".
Apr 28 2016, 7:06 PM
scode added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

Ah, sorry about that!

Apr 28 2016, 6:58 PM · Arcanist, Prioritized, Restricted Project, Feature Request
chad added a comment to T10893: repo update fails for repos with 1000s of closing branches.

62812079.jpg (400×400 px, 107 KB)

Apr 28 2016, 6:56 PM · Diffusion, Bug Report
avivey added a comment to T10893: repo update fails for repos with 1000s of closing branches.

OK, I was able to reproduce this; The key is to have 1000s of autoclose branches.

Apr 28 2016, 6:55 PM · Diffusion, Bug Report
epriestley added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

Oh, the actual implementation would be --revision (with a short option), I was just using --the-revision-for for clarity (or extra confusion?) in discussing the meaning/behavior of the flag.

Apr 28 2016, 6:52 PM · Arcanist, Prioritized, Restricted Project, Feature Request
scode added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

My gut feeling is that our users will feel that arc browse --the-revision-for HEAD is too verbose for something that to them is a common and "should be simple" operation. However, if combined with the default behavior as you suggest, such that just arc browse defaults appropriately it would avoid that being a problem while keeping the meaning of the --the-revision-for HEAD option clear.

Apr 28 2016, 6:45 PM · Arcanist, Prioritized, Restricted Project, Feature Request
quiddity awarded T10293: Plan rest of "CoverImage" feature a Love token.
Apr 28 2016, 6:41 PM · Workboards, Projects (v3)
quiddity added a comment to T10293: Plan rest of "CoverImage" feature.

Wooo! I think this completely covers my old request at T9520: Allow Workboards to show a thumbnail image within each card. :-)

Apr 28 2016, 6:41 PM · Workboards, Projects (v3)
epriestley added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

Some earlier discussion in T5781, although I didn't really have a clear way forward at the time and still don't.

Apr 28 2016, 6:38 PM · Arcanist, Prioritized, Restricted Project, Feature Request
avivey added a comment to T10893: repo update fails for repos with 1000s of closing branches.

does ./repository update work for the smaller repo?
I don't think that's an issue with the length of the command (I'd expect a different exit code - 126, and I think our command execution bypasses this limitation). Exit code 127 might mean that when you invoke it in this way, it can't find git.

Apr 28 2016, 6:14 PM · Diffusion, Bug Report
scode moved T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD` from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 28 2016, 6:00 PM · Arcanist, Prioritized, Restricted Project, Feature Request
scode added a project to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`: Restricted Project.
Apr 28 2016, 6:00 PM · Arcanist, Prioritized, Restricted Project, Feature Request
scode updated the task description for T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
Apr 28 2016, 5:58 PM · Arcanist, Prioritized, Restricted Project, Feature Request
scode created T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
Apr 28 2016, 5:58 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 5:45 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged T10894: Arc patch fails when a symlink is replaced with a file into T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Apr 28 2016, 5:43 PM · Arcanist
epriestley merged task T10894: Arc patch fails when a symlink is replaced with a file into T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Apr 28 2016, 5:43 PM · Bug Report
prashantv created T10894: Arc patch fails when a symlink is replaced with a file.
Apr 28 2016, 5:29 PM · Bug Report
chad added a comment to T10349: Projects v3 Errata.

haha, no, i don't like it either, but it is at least intentional. I just didn't have any better ideas (and I think we took two passes on it).

Apr 28 2016, 5:18 PM · Restricted Project, Projects (v3)
fooishbar added a comment to T10349: Projects v3 Errata.

Now, I do agree with you this interaction is imperfect and could be improved, and your feedback is duly noted, but we're a team of 2 here with 1500 tasks open, so some things are just be imperfect until next time we're in the product.

Apr 28 2016, 5:16 PM · Restricted Project, Projects (v3)
chad added a comment to T10349: Projects v3 Errata.

'No points' or simply showing nothing is less information

Apr 28 2016, 5:12 PM · Restricted Project, Projects (v3)
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 28 2016, 4:25 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10366: General support for multiple URIs for a repository: Unknown Object (Differential Revision).
Apr 28 2016, 4:25 PM · Diffusion (v3), Restricted Project, Feature Request
Chiel92 added a comment to T10893: repo update fails for repos with 1000s of closing branches.
$ git branch --list -a | wc -l
4547
$ git tag  --list | wc -l
13189
Apr 28 2016, 3:55 PM · Diffusion, Bug Report
benjumanji added a comment to T7789: Support Git Large File Storage.

Can confirm that on latest stable my lfs-test repository now succeeds with both jars and jpegs. Huzzah!

Apr 28 2016, 3:35 PM · Customer Impact, Restricted Project, Files, Diffusion
fooishbar added a comment to T10349: Projects v3 Errata.

@chad 'No points' or simply showing nothing is less information. An incomplete word isn't a deliberate choice to show less information, it's how it happened to land. Anyway, seems like you consider it a feature, so I'll leave it alo

Apr 28 2016, 3:23 PM · Restricted Project, Projects (v3)
chad added a comment to T10349: Projects v3 Errata.

I believe less information when the user has chosen to collapse the nav is aligned with expectations.

Apr 28 2016, 3:06 PM · Restricted Project, Projects (v3)
hach-que added a comment to T10215: Provide tools to combat and recover from abuse.

I think it would be preferable to keep a log of bulk edits that were performed in a global(?) history, and allow them to be reverted easily? I think that would mitigate the issue described in the comment above, and provide value in the event someone unintentionally bulk edits the incorrect set of tasks / objects.

Apr 28 2016, 3:00 PM · Abuse
avivey added a comment to T10893: repo update fails for repos with 1000s of closing branches.

How many branches/tags in the large repository?

Apr 28 2016, 2:45 PM · Diffusion, Bug Report
fooishbar added a comment to T10349: Projects v3 Errata.

@chad If the verbosity is essential, perhaps it should be word-wrapped in the collapsed case, rather than truncated?

Apr 28 2016, 2:40 PM · Restricted Project, Projects (v3)
chad added a comment to T10349: Projects v3 Errata.

The language is that no tasks have points, 'no tasks' might solve a small edge case, but as soon as the first task appears with no points, the longer text is more correct. We tend to lean towards over explaining cases as to limit upstream support time.

Apr 28 2016, 2:38 PM · Restricted Project, Projects (v3)
fooishbar added a comment to T10890: Less chatty Maniphest feed rendering.

@chad OK, fair enough; I guess just close this and I'll build something locally.

Apr 28 2016, 2:31 PM · Maniphest, Feature Request
chad added a comment to T10890: Less chatty Maniphest feed rendering.

My overall concern here is it's a coinflip as to whether that information is useful or not. Mentions nearly always are and while probably not subscriptions, designing a complicated, magical display around thin edge cases doesn't seem like a good use of upstream time. It's unclear that other installs see the same problem (we tend to have tasks that are of high interest for years).

Apr 28 2016, 2:23 PM · Maniphest, Feature Request
chad added a comment to T10890: Less chatty Maniphest feed rendering.

See Contributing Feature Requests for what information we look for in feature requests. This feels more like design feedback (which we don't take as tasks).

Apr 28 2016, 2:18 PM · Maniphest, Feature Request
fooishbar added a comment to T10349: Projects v3 Errata.

From T10891:
When you have the side project profile panels collapsed, then go to create a new milestone, it will have no tasks. The profile panel then shows 'This milestone has no tasks yet', but brutally cut off to 'This mileston-' in the collapsed view.

Apr 28 2016, 2:12 PM · Restricted Project, Projects (v3)