Description

For CORGI, some parts of the site are built in Remarkup, which defaults to target="_blank" or similar on links. We should have some way to turn this off.

Possibly similar/related/adjacent:

T6299, link generation on Phame blogs on a custom CNAME'd domain.
T10381 is a similar "rules should be a little different for using Remarkup in interfaces" task.

Revisions and Commits

rPHU libphutil
	D16006	rPHU2c47bbeaf753 Make remarkup link generation rules more flexible and consistent

Related Objects

Mentioned In: T11076: Ship CORGI
Mentioned Here: D16006: Make remarkup link generation rules more flexible and consistent
T6299: Remarkup links to objects in Phame break if a CNAME is set
T10381: Tweak linebreak preservation behavior of PHUIRemarkupView

Event Timeline

epriestley created this task.Apr 29 2016, 5:26 PM

Herald added a subscriber: eadler. · View Herald TranscriptApr 29 2016, 5:26 PM

joshuaspence added a subscriber: joshuaspence.May 9 2016, 9:50 PM

I made some headway on this but I'm feeling really icky about it and I think I may want to try making PHUIRemarkupView more powerful and moving away from PhabricatorMarkupInterface first.

epriestley mentioned this in T11076: Ship CORGI.Jun 2 2016, 1:31 AM

epriestley added a revision: D16006: Make remarkup link generation rules more flexible and consistent.Jun 2 2016, 1:44 AM

D16006 is the main fix; CORGI is resolved in secret at https://meta.phacility.com/D84.

Herald added a subscriber: faulconbridge. · View Herald TranscriptJun 2 2016, 2:08 AM

epriestley added a commit: rPHU2c47bbeaf753: Make remarkup link generation rules more flexible and consistent.Jun 2 2016, 1:27 PM

Customize "open in new window" link behavior for RemarkupEngineClosed, ResolvedPublicActions

Description

Revisions and Commits

Related Objects

Event Timeline

Customize "open in new window" link behavior for RemarkupEngine
Closed, ResolvedPublic
Actions