Page MenuHomePhabricator
Create Task
Maniphest T10903

Customize "open in new window" link behavior for RemarkupEngine
Closed, ResolvedPublic
Actions

Description

For CORGI, some parts of the site are built in Remarkup, which defaults to target="_blank" or similar on links. We should have some way to turn this off.

Possibly similar/related/adjacent:

  • T6299, link generation on Phame blogs on a custom CNAME'd domain.
  • T10381 is a similar "rules should be a little different for using Remarkup in interfaces" task.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

epriestley created this task.Apr 29 2016, 5:26 PM
Herald added a subscriber: eadler. · View Herald TranscriptApr 29 2016, 5:26 PM
joshuaspence added a subscriber: joshuaspence.May 9 2016, 9:50 PM
epriestley added a comment.May 22 2016, 4:13 PM

I made some headway on this but I'm feeling really icky about it and I think I may want to try making PHUIRemarkupView more powerful and moving away from PhabricatorMarkupInterface first.

epriestley mentioned this in T11076: Ship CORGI.Jun 2 2016, 1:31 AM
epriestley added a revision: Restricted Differential Revision.Jun 2 2016, 1:44 AM
epriestley closed this task as Resolved.Jun 2 2016, 2:08 AM

D16006 is the main fix; CORGI is resolved in secret at https://meta.phacility.com/D84.

Herald added a subscriber: faulconbridge. · View Herald TranscriptJun 2 2016, 2:08 AM
epriestley added a commit: Restricted Diffusion Commit.Jun 2 2016, 1:27 PM
Phabricator · Built by Phacility