Page MenuHomePhabricator

Support third-party package definitions in Celerity, or remember how it works if I already built it
Closed, ResolvedPublic

Description

For CORGI, we should be able to package Corp/Org resources. Generally, third-party applications can already define third-party resource maps, should be able to package third-party resources as well.

It gets tricky if we're trying to bundle them into first-party packages, or, say, bundle several small extension packages into a single package-of-packages, but we don't need to deal with that for now.

It's possible that this already works and I just forgot how it works, in which case I just need to remember how it works. But I think I didn't implement it since we didn't have much need for it at the time.

Related Objects

Event Timeline

I don't believe it was implemented; the third party Celerity stuff only supports individual files as far as I remember.

Fix for this is on meta, but the short version is that it works fine as-is.

I think the limitation I was remembering is that you can't add new stuff to core packages, but I think that's a reasonable limitation for the foreseeable future.

-return array();
+return array(
+  'corgi.pkg.css' => array(
+    'bootstrap-theme-css',
+    'bootstrap-css',
+    'corgi-page-home-css',
+    'corgi-page-main-css',
+    'cs-footer-css',
+    'cs-hero-css',
+    'cs-info-list-css',
+    'cs-main-css',
+    'cs-nav-css',
+    'cs-pinboard-list-css',
+    'cs-social-proof-css',
+  ),
+);