Page MenuHomePhabricator

Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color
Closed, ResolvedPublic


I am colorblind and it is very difficult for me to tell these diff rejection icons apart:

Screen Shot 2016-04-29 at 4.29.23 PM.png (82×42 px, 5 KB)

Some suggestions:

  • make the red one a light red
  • change the shape slightly
  • introduce stripes or other pattern to the background of one of the icons

Event Timeline

Can you point us at where in the UI these are used, exactly? Just want to make sure we're fixing the right thing.

I can't think of where these are used without text or tooltip.

I think it's maybe in the PHUIStatusView here?

Screen Shot 2016-04-29 at 5.47.50 PM.png (207×340 px, 16 KB)

I think we use for "rejected", and for "rejected older diff".

Likewise, we use for "accepted" and for "accepted older diff".

They have tooltips and the distinction isn't particularly important, but maybe an easy fix is to just use and for the "older" variants (without the background)?

They're used in a diff. Red means someone has rejected my most recent diff. Black means they rejected an older version but haven't seen my newest revision.

@chad I can differentiate by hovering with a mouse over the icon. But that is cumbersome and undesirable.

Yeah that's all I could come up with as a possibility too.

@epriestley Inverting the "old" (greyscale) icons would resolve my issue.

epriestley renamed this task from Can't differentiate diff rejection icons to Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color.Apr 30 2016, 12:57 AM

for current and for previous?

current reject
previous reject
current accept
previous accept

At least circle and circle-o are similar enough that it doesn't feel out of place.