I am colorblind and it is very difficult for me to tell these diff rejection icons apart:
Some suggestions:
- make the red one a light red
- change the shape slightly
- introduce stripes or other pattern to the background of one of the icons
getaaron | |
Apr 29 2016, 11:31 PM |
F1251496: Screen Shot 2016-04-29 at 5.47.50 PM.png | |
Apr 30 2016, 12:51 AM |
F1251421: Screen Shot 2016-04-29 at 4.29.23 PM.png | |
Apr 29 2016, 11:31 PM |
I am colorblind and it is very difficult for me to tell these diff rejection icons apart:
Some suggestions:
Can you point us at where in the UI these are used, exactly? Just want to make sure we're fixing the right thing.
I think it's maybe in the PHUIStatusView here?
I think we use for "rejected", and for "rejected older diff".
Likewise, we use for "accepted" and for "accepted older diff".
They have tooltips and the distinction isn't particularly important, but maybe an easy fix is to just use and for the "older" variants (without the background)?
They're used in a diff. Red means someone has rejected my most recent diff. Black means they rejected an older version but haven't seen my newest revision.
@chad I can differentiate by hovering with a mouse over the icon. But that is cumbersome and undesirable.
for current and for previous?
current reject
previous reject
current accept
previous accept
At least circle and circle-o are similar enough that it doesn't feel out of place.