Page MenuHomePhabricator
Feed Advanced Search

Jul 7 2017

epriestley merged T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard into T10333: Add groups to workboard columns.
Jul 7 2017, 11:26 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley merged task T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard into T10333: Add groups to workboard columns.
Jul 7 2017, 11:26 PM · Workboards, Feature Request
epriestley added a comment to T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard.

This is either T10333 or T4863. I'd guess the former will happen first. Filter is probably the best workaround until then. See also T12374 maybe, although I think that task involved a lot of meandering.

Jul 7 2017, 11:26 PM · Workboards, Feature Request
epriestley created T12904: Support Pact Errata.
Jul 7 2017, 11:21 PM · Phacility, Support
epriestley added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

Notes for myself about billing:

Jul 7 2017, 8:18 PM · Guides, Phacility
epriestley added a revision to T12681: Upcoming Support Product / End of Paid Prioritization: Unknown Object (Differential Revision).
Jul 7 2017, 6:27 PM · Guides, Phacility
joshuaspence added a comment to T7858: Typeahead/Tokenizer Errata.

Is there a way to exclude users/projects from a query? A user on our install has asked for a way to search for Differential revisions with Project X as a reviewer where the author is not a member of Project X.

Jul 7 2017, 6:47 AM · Restricted Project, Typeahead

Jul 6 2017

epriestley awarded Contributor to recipient: stefren.
Jul 6 2017, 11:11 PM
epriestley added a member for Blessed Committers: stefren.
Jul 6 2017, 11:10 PM
epriestley added a member for Community: stefren.
Jul 6 2017, 11:10 PM
epriestley added a comment to T12901: Support access policies for saved queries.

Have you actually tested this scenario yourself?

Jul 6 2017, 4:24 PM · Feature Request
epriestley added a comment to T10005: Implement an ApplicationEditor-based Bulk Editor.

See Consulting if you'd like immediate help with this issue.

Jul 6 2017, 4:04 PM · ApplicationEditor
epriestley closed T12901: Support access policies for saved queries as Wontfix.

Edit the Saved Query to contain something sensitive

Jul 6 2017, 3:59 PM · Feature Request
epriestley added a comment to T12896: It isn’t obvious when repository observation breaks.

From elsewhere:

Jul 6 2017, 3:19 PM · Diffusion, Feature Request
epriestley added a comment to T12901: Support access policies for saved queries.

A user might have a saved query which contains sensitive information no one else should know about.

Jul 6 2017, 3:17 PM · Feature Request
epriestley closed T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors as Resolved.

That use case doesn't strike me as compelling enough to justify a separate field or a behavioral change so I don't plan to adjust our behavior here.

Jul 6 2017, 3:15 PM · Phame, Policy, Bug Report
jcarrillo7 awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Jul 6 2017, 6:48 AM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley added a revision to T12681: Upcoming Support Product / End of Paid Prioritization: Unknown Object (Differential Revision).
Jul 6 2017, 12:25 AM · Guides, Phacility

Jul 5 2017

epriestley added a revision to T12681: Upcoming Support Product / End of Paid Prioritization: Unknown Object (Differential Revision).
Jul 5 2017, 10:49 PM · Guides, Phacility
epriestley added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

You must be able to view a post's blog to view the post, so the rule is effectively "view and edit".

Jul 5 2017, 10:09 PM · Phame, Policy, Bug Report
epriestley added a project to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors: Phame.
Jul 5 2017, 4:59 PM · Phame, Policy, Bug Report
epriestley renamed T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors from Phame blog draft posts are visible to all to Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.
Jul 5 2017, 4:59 PM · Phame, Policy, Bug Report
epriestley added a revision to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors: Unknown Object (Differential Revision).
Jul 5 2017, 4:55 PM · Phame, Policy, Bug Report
epriestley added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

Historically, Phame originally used the claimed rule ("only the author"), introduced in or around D3694.

Jul 5 2017, 4:47 PM · Phame, Policy, Bug Report
epriestley added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

The rule we implement seems to work properly, but the UI tells you a different rule.

Jul 5 2017, 4:32 PM · Phame, Policy, Bug Report
epriestley claimed T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

The language here is inconsistent with the rule we attempt to implement. Let me make sure the rule we attempt to implement actually works and that this is just a language issue.

Jul 5 2017, 4:27 PM · Phame, Policy, Bug Report

Jul 3 2017

epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

Synchronously in the request. I'll look at adding logging.

Jul 3 2017, 11:31 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley closed T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first) as Resolved by committing Restricted Diffusion Commit.
Jul 3 2017, 4:28 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley renamed T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first) from Install reporting an "exact match" issue with global search typeahead to Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 3:02 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a revision to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first): Unknown Object (Differential Revision).
Jul 3 2017, 2:27 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).

This is an issue specific to the repository names containing hyphens. The code is already calling calling the correct sort functions.

Jul 3 2017, 2:25 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).

I created these repositories:

Jul 3 2017, 2:14 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley placed T9084: Use a typeaheads for querying Object Types in Flags up for grabs.
Jul 3 2017, 2:13 PM · Contributor Onboarding, Flags
epriestley updated the task description for T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 1:21 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley created T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 1:21 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

So I'm not immediately able to reproduce this. Some possible questions:

Jul 3 2017, 1:14 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

I used this parameter bundle to create a repository:

Jul 3 2017, 1:10 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

I'm attempting to reproduce this from the web UI first. I created a new repository, and get 0 versions as expected:

Jul 3 2017, 12:34 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley created T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.
Jul 3 2017, 12:25 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I am unable to reproduce this problem given the instructions provided:

Jul 3 2017, 12:17 PM · Bug Report
epriestley added a parent task for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Jul 3 2017, 10:48 AM · Arcanist, Bug Report
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 10:48 AM · Arcanist, Differential
epriestley renamed T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from ArcanistDiffParser fails to parse filenames to Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 10:48 AM · Arcanist, Bug Report
epriestley triaged T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs as Wishlist priority.

That change fixed a lot of bugs, so we aren't going to revert it: reverting it would break all the things it fixed and added test cases for. --no-index --no-prefix diffs have never been part of the test suite and it is just coincidence that it worked before that change.

Jul 3 2017, 10:47 AM · Arcanist, Bug Report

Jul 2 2017

isfs awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jul 2 2017, 9:52 PM · Workboards (v3), Restricted Project
epriestley merged task T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Feature Request
epriestley merged T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

I'm writing a Mercurial extension to send changesets to Differential like hg email provided by patchbomb extension.

Jul 2 2017, 6:51 PM · Feature Request
MissyTS awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Burninate token.
Jul 2 2017, 5:40 PM · Workboards (v3), Restricted Project

Jul 1 2017

epriestley edited the content of Changelog.
Jul 1 2017, 12:16 AM
epriestley created 2017 Week 26 (Very Late June).
Jul 1 2017, 12:15 AM

Jun 30 2017

epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Also we aren't the only ones to be surprised by the AWS NAT junk:

Jun 30 2017, 10:55 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

It looks like Terraform probably can add a listener without destroying the LB (since it's a separate resource type? But the "changing the size of a volume destroys the instance" case suggests maybe it doesn't work like this, if that's how that works), but if you want to enable access logging on your LBs hope you didn't need 'em for anything important? I could probably just install it and figure this out / nuke production forever.

Jun 30 2017, 10:19 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

If PHP just injects that information into the templates during generation, we might not need to feed anything back into Almanac.

Jun 30 2017, 9:02 PM · Ops, Phacility
epriestley closed T12887: Can't add members to "parent project" when all subprojects are archived as Invalid.

Yes, this is expected. The process of converting a project to become a parent project can not be undone:

Jun 30 2017, 7:31 PM · Bug Report
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Terraform also seems to have terraform taint (mark a resource for destruction) but no, e.g., terraform freeze (mark a resource for preservation). This is sort of philosophically bewildering to me. Is the modern approach to ops just like "data isn't important"? Is everyone just really, really careful when they type commands into their fully-automatic resource destruction rifles loaded with high-explosive foot-seeking shells?

Jun 30 2017, 7:27 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

How does the weekly deployment to all clusters work?

Jun 30 2017, 6:39 PM · Ops, Phacility
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

I guess everyone uses GMail nowadays anyway (as mandated by international galactic law) so my paranoia is probably mostly moot because they can undetectably read all email communication anyway.

Jun 30 2017, 5:14 PM · Feature Request
epriestley closed T12880: Expose the ability to add some JS to every page as Wontfix.

I think you probably won't be able to answer most of those questions with Google Analytics. For example, bots will never hit client-side analytics, so any question about bots probably can't be served by GA. Likewise, GA can't see Conduit/API activity.

Jun 30 2017, 2:45 PM · Feature Request
epriestley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

(Both adjust and doc/symbol documentation affect an entire service tier rather than particular servers, too -- we only need to generate docs or make schema adjustments once, no matter how many hosts are in the secure or admin tiers.)

Jun 30 2017, 2:25 PM · Phacility, Ops
epriestley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

My recollection is a little fuzzy, but I think admin may have once had a hacky crontab for backups that I replaced with a normal backup trigger at some point when the infrastructure matured a little.

Jun 30 2017, 2:23 PM · Phacility, Ops
epriestley awarded Bug Meister to recipient: ephemeris.
Jun 30 2017, 2:13 PM
epriestley awarded Bug Meister to recipient: mplough.
Jun 30 2017, 2:13 PM
epriestley added a comment to T12883: Harbormaster build completion information displays build start time.

I believe your analysis and proposed change are correct. D18177 brings that change upstream. It is now available in master, and should promote to stable later today (within about 12 hours).

Jun 30 2017, 2:13 PM · Bug Report
epriestley closed T12883: Harbormaster build completion information displays build start time as Resolved by committing Restricted Diffusion Commit.
Jun 30 2017, 2:11 PM · Bug Report
epriestley added a comment to T12884: Diffusion claims that remote repos' clone URIs are disabled.

This should now be fixed in HEAD of master and promote to stable later today (within about 12 hours). This change hasn't been deployed to secure.phabricator.com yet but will be deployed no later that tomorrow morning (about 24 hours from now), at which point the example link you provided should start working.

Jun 30 2017, 2:11 PM · Diffusion, Bug Report
epriestley closed T12884: Diffusion claims that remote repos' clone URIs are disabled as Resolved by committing Restricted Diffusion Commit.
Jun 30 2017, 2:09 PM · Diffusion, Bug Report
epriestley added a comment to T12885: Warning For Past Events.

I think it's probably reasonable for us to warn about RSVP'ing to an event which has already ended. I'd guess this is usually a mistake, and in cases where it isn't some kind of weird off-label workflow is taking place and the warning is probably fine.

Jun 30 2017, 2:09 PM · Calendar, Feature Request
epriestley added a revision to T12883: Harbormaster build completion information displays build start time: Unknown Object (Differential Revision).
Jun 30 2017, 2:03 PM · Bug Report
epriestley claimed T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 30 2017, 2:01 PM · Diffusion, Bug Report
epriestley added a revision to T12884: Diffusion claims that remote repos' clone URIs are disabled: Unknown Object (Differential Revision).
Jun 30 2017, 2:01 PM · Diffusion, Bug Report

Jun 29 2017

epriestley added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 29 2017, 4:07 PM · Feature Request
Krinkle awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jun 29 2017, 2:59 AM · Prioritized, Restricted Project, Infrastructure

Jun 28 2017

epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

The "consulting firms" use case is explicitly disavowed by, e.g., the Spaces documentation, here:

Jun 28 2017, 7:00 PM · People, Security
epriestley archived Releeph.
Jun 28 2017, 5:13 PM
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:13 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:13 PM · Releeph
epriestley closed T4679: releeph.queryrequests Conduit call doesn't expose enough information as Wontfix.
Jun 28 2017, 5:13 PM · Releeph, Facebook
epriestley closed T4700: Give Releeph more human-readable URIs? as Wontfix.
Jun 28 2017, 5:13 PM · Releeph, Facebook
epriestley closed T4696: Implement an incrementing counter for Releeph templates as Wontfix.
Jun 28 2017, 5:13 PM · Releeph
epriestley closed T4691: Releeph Migration/Update Issues as Wontfix.
Jun 28 2017, 5:12 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:12 PM · Releeph
epriestley closed T2717: Fix the giant query in ReleephRequestTypeaheadController, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2752: Releeph shouldn't let you request the same code twice, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2718: Fix the ad-hoc branch contain query in `DifferentialReleephRequestFieldSpecification`, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2718: Fix the ad-hoc branch contain query in `DifferentialReleephRequestFieldSpecification` as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2717: Fix the giant query in ReleephRequestTypeaheadController as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed T2752: Releeph shouldn't let you request the same code twice as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:07 PM · Releeph
epriestley removed a project from T9530: Release Server / Workflow app / Future of Releeph : Releeph.
Jun 28 2017, 5:06 PM · Restricted Project, Harbormaster