Page MenuHomePhabricator

Releeph Migration/Update Issues
Closed, WontfixPublic

Description

This task is to keep track of Releeph things we know will need some adjustment (like URL or API changes), so we have one list which should cover most of the issues created as stuff lands in the upstream.

Workflow / User Experience Changes

  • "Release Projects" are being renamed to "Release Products", to reduce confusion between "Projects", "Arcanist Projects", and "Releeph Projects". See T3549. Anything outside of Phabricator should update to the new terminology.
  • In D8628, we removed the "Release Counter" field. See T3658 for discussion. This field didn't make sense as implemented and didn't seem to work anyway. T4696 tracks implementing this in a more usable way in the future (the counter would increment automatically).
  • In D8630, we removed the different "Author" selection rules. The original revision/commit author is now always selected as the author of picked/pulled changes. Discussion in T3659. The two other rules didn't really have any supporting use cases.
  • The monogram for requests has moved from "RQ" to "Y" (looks like a merge, mnemonic for "yank"?), to remove ambiguity between "RQ", "rQ" and "R2". See T4245. This should be almost exclusively cosmetic, although anything using /RQ... URIs should switch to /Y... URIs.
  • Requests are now rendered using more standard UI elements, instead of the older element with the olive/brown background.

Technical Changes

  • In D8631, we've removed ReleephUserView. Our understanding is that Facebook currently uses this to implement some nice-to-have but noncritical functionality showing additional information about authors and requestors, like push karma. Our intent is to provide this functionality via CustomFields instead when Facebook gets closer to HEAD. We can help with this integration, which should not be particularly complex. See T3738 for further discussion.
  • The API for ReleephFieldSpecification has changed, and custom subclasses require adjustments. The new API is generally very similar, but some methods will need to be renamed (for example, renderValueForHeaderView() is now renderPropertyViewValue()). In most cases, this should be straightforward.
  • The releephwork.getorigcommitmessage method has been removed. Use diffusion.querycommits instead. See D8823.
  • Objects like ReleephRequest, ReleephBranch and ReleephProduct no longer have load...() methods. Data which was previously accessible via load...() methods is often accessible via get...() methods now.

Event Timeline

epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Releeph.
epriestley added subscribers: epriestley, mattlqx, Unknown Object (MLST).
epriestley moved this task from Backlog to Beta on the Releeph board.