Page MenuHomePhabricator
Create Task
Maniphest T12883

Harbormaster build completion information displays build start time
Closed, ResolvedPublic
Actions

Description

Version:

phabricator 5885704800a97aadf47aee5654ff2647b40fb4ad (Fri, Jun 9) (branched from 3400f24c8b53a742b6dd39a9c244f45c51db85ac on origin)
arcanist 0c53a35d30e924f902510eb2e497ae5934209304 (Fri, Jun 9) (branched from c04f141ab0231e593a513356b3832a30f9404627 on origin)
phutil 612619d0040b5e13c4e068dce443217abbc10a00 (Fri, Jun 9) (branched from 74a1350416eb2df825c2315d6519bee03f77bee9 on origin)

Steps to reproduce:

  1. Run a Harbormaster build.
  2. View the completion time in the overview, e.g. When Completed at Wed, Jun 28, 6:09 PM · Built for 8 h, 57 m.

Expected results:
The completion time is shown as the time that the build finished.

Actual results:
The completion time is shown as the time that the build started.

Fix:

diff --git a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
index 7932451d2..5b7171a20 100644
--- a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
@@ -141,7 +141,7 @@ final class HarbormasterBuildViewController
         if ($ended) {
           $when[] = pht(
             'Completed at %s',
-            phabricator_datetime($started, $viewer));
+            phabricator_datetime($ended, $viewer));

           $duration = ($ended - $started);
           if ($duration) {

Revisions and Commits

rP Phabricator
D18177rPeab8d8a22c4f Use the correct "completed" time in Harbormaster display UI

Related Objects

Event Timeline

mplough created this task.Jun 29 2017, 2:31 PM
epriestley added a revision: D18177: Use the correct "completed" time in Harbormaster display UI.Jun 30 2017, 2:03 PM
epriestley closed this task as Resolved by committing rPeab8d8a22c4f: Use the correct "completed" time in Harbormaster display UI.Jun 30 2017, 2:11 PM
epriestley added a commit: rPeab8d8a22c4f: Use the correct "completed" time in Harbormaster display UI.
epriestley added a subscriber: epriestley.Jun 30 2017, 2:13 PM

I believe your analysis and proposed change are correct. D18177 brings that change upstream. It is now available in master, and should promote to stable later today (within about 12 hours).

(This server may not pick it up for about 24 hours, although I think most of the builds that run here are fast enough that it would be hard to tell if the issue was present or not.)

Thanks for taking the time to make such a clear report, it's a big help in fixing things! Let us know if you run into anything else.

mplough added a comment.Jun 30 2017, 4:05 PM

Glad I could help! Thanks for getting the fix in so quickly!

Phabricator · Built by Phacility