Page MenuHomePhabricator
Feed Advanced Search

Jun 28 2017

epriestley closed T2714: Move Releeph to Beta as Wontfix.

See T9530.

Jun 28 2017, 5:02 PM · Releeph
epriestley closed Restricted Maniphest Task, a subtask of T2714: Move Releeph to Beta, as Wontfix.
Jun 28 2017, 5:02 PM · Releeph
epriestley closed T7650: Support Impressum for public policy legal compliance as Invalid.

As is sometimes the case with legal issues, I think this request is based on a misunderstanding of the law. The German "Telemedia Act" establishing this requirement ("Telemediengesetz") does not seem to require the link to appear on every page.

Jun 28 2017, 4:56 PM
epriestley renamed T3967: Build a 2-up preview mode into the fullscreen Remarkup editor from Build a preview mode into the fullscreen Remarkup editor to Build a 2-up preview mode into the fullscreen Remarkup editor.
Jun 28 2017, 4:21 PM · Remarkup
epriestley placed T3967: Build a 2-up preview mode into the fullscreen Remarkup editor up for grabs.
  • Remarkup areas got inline previews in D14855.
  • EditEngine got some extensions to restore similar on-page previews to Maniphest.
Jun 28 2017, 4:21 PM · Remarkup
epriestley added a revision to T12681: Upcoming Support Product / End of Paid Prioritization: Unknown Object (Differential Revision).
Jun 28 2017, 2:00 PM · Guides, Phacility
epriestley added a revision to T12681: Upcoming Support Product / End of Paid Prioritization: Unknown Object (Differential Revision).
Jun 28 2017, 1:06 PM · Guides, Phacility
epriestley added a revision to T12681: Upcoming Support Product / End of Paid Prioritization: Unknown Object (Differential Revision).
Jun 28 2017, 12:21 PM · Guides, Phacility
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

If we put spaces on user accounts, how do I get into a Space you have permission to see so you can add me as a Manager on the payment account for phacility.phacility.com in Phortune using the typeahead?

Jun 28 2017, 12:01 PM · People, Security
epriestley closed T12878: online vicinity alert as Invalid.
Jun 28 2017, 11:47 AM · Bug Report

Jun 27 2017

epriestley added a revision to T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support: Unknown Object (Differential Revision).
Jun 27 2017, 10:38 PM · Nuance
epriestley added a comment to T12840: (maybe) bring back commit graphs in history.

We use (most of) the graph code for drawing the "Task Graph" and the "Revision Graph" so we need to keep it around in the upstream anyway.

Jun 27 2017, 9:43 PM · Design, Diffusion
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

This is fundamentally unfixable

Jun 27 2017, 9:41 PM · People, Security
epriestley added a comment to T12840: (maybe) bring back commit graphs in history.

("Graph" button in upper right.)

Jun 27 2017, 9:39 PM · Design, Diffusion
epriestley added a comment to T12840: (maybe) bring back commit graphs in history.

https://secure.phabricator.com/source/phabricator/history/master/

Jun 27 2017, 9:38 PM · Design, Diffusion
epriestley added a comment to T12840: (maybe) bring back commit graphs in history.

I think that's what D18131 did -- or do you mean something else?

Jun 27 2017, 9:38 PM · Design, Diffusion
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

This is fundamentally unfixable:

Jun 27 2017, 9:31 PM · People, Security
epriestley added a comment to T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support.

I think we're more-or-less at the point where the existing Nuance code is about as internally modernized as it's going to get, so there isn't a great deal of remaining obvious technical debt to pay down.

Jun 27 2017, 8:31 PM · Nuance
epriestley moved T8783: Unprototype Nuance (v1) from Backlog to Now on the Nuance board.
Jun 27 2017, 7:42 PM · Nuance, Restricted Project
epriestley moved T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support from Backlog to Now on the Nuance board.
Jun 27 2017, 7:42 PM · Nuance
epriestley archived Nuance (v1).
Jun 27 2017, 7:41 PM
epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

At HEAD of master:

Jun 27 2017, 7:37 PM · Maniphest, Bug Report
epriestley closed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities, a subtask of T12845: Convert remaining ancient configuration type classes to modern modular type classes, as Resolved.
Jun 27 2017, 7:35 PM · Infrastructure, Config
epriestley closed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities as Resolved by committing Restricted Diffusion Commit.
Jun 27 2017, 7:35 PM · Maniphest, Bug Report
epriestley renamed T12845: Convert remaining ancient configuration type classes to modern modular type classes from Setting and removing a config for maniphest.priorities results in a null config instead of reverting to the default to Convert remaining ancient configuration type classes to modern modular type classes.
Jun 27 2017, 7:12 PM · Infrastructure, Config
epriestley placed T12845: Convert remaining ancient configuration type classes to modern modular type classes up for grabs.

This is "fixed" by the associated series of diffs, in the sense that the actual problem (being unable to delete web UI config) is fixed. This is remaining work:

Jun 27 2017, 7:11 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 27 2017, 5:05 PM · Infrastructure, Config
epriestley closed T12875: How to see all user keys uploaded as Invalid.

See T12874. Your account will be disabled if you continue creating tasks like this. Follow the instructions you were given.

Jun 27 2017, 4:14 PM · Feature Request
epriestley added a revision to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: Unknown Object (Differential Revision).
Jun 27 2017, 3:15 PM · Maniphest, Bug Report
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 27 2017, 3:15 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 27 2017, 1:59 PM · Infrastructure, Config
janitorial awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Burninate token.
Jun 27 2017, 1:21 PM · Workboards (v3), Restricted Project
epriestley added a comment to T4444: "NOT" filter for all applicable lines in a Query.

You can find tasks with no owner by searching for "No Owner", like this:

Jun 27 2017, 11:50 AM · Custom Fields, Projects, Maniphest
vpavlushkov awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jun 27 2017, 8:52 AM · Workboards (v3), Restricted Project

Jun 26 2017

epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

They already --prune when pulling:

Jun 26 2017, 9:26 PM · Restricted Project, Restricted Project, Arcanist
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 5:27 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 5:15 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 4:57 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Restricted Differential Revision.
Jun 26 2017, 4:34 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 4:08 PM · Infrastructure, Config
epriestley added a revision to T12845: Convert remaining ancient configuration type classes to modern modular type classes: Unknown Object (Differential Revision).
Jun 26 2017, 3:52 PM · Infrastructure, Config
epriestley added a subtask for T12845: Convert remaining ancient configuration type classes to modern modular type classes: T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Jun 26 2017, 2:04 PM · Infrastructure, Config
epriestley added a parent task for T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities: T12845: Convert remaining ancient configuration type classes to modern modular type classes.
Jun 26 2017, 2:04 PM · Maniphest, Bug Report
epriestley lowered the priority of T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out from Normal to Low.

For private reasons affecting the reporting install, this no longer has customer impact.

Jun 26 2017, 2:02 PM · Policy, Dashboards, Bug Report

Jun 23 2017

epriestley edited the content of Changelog.
Jun 23 2017, 11:55 PM
epriestley created 2017 Week 25 (Late June).
Jun 23 2017, 11:54 PM
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

That sounds like a bug, but my guess is that the investigation would probably turn up "wow you are dumb at writing software" in about 3 minutes and not really get us much closer to a fix, which is probably "rewrite arc patch to fix 200 problems".

Jun 23 2017, 11:40 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it's currently expected, yes. We don't create branches for dependencies in Git either, currently. I don't think this is terribly unreasonable, but I'm also not sure it's terribly useful (does it just help you keep track of which commits are part of the leaf?) and it makes cleanup more difficult by creating more total branch/bookmark artifacts in the local working copy.

Jun 23 2017, 11:39 PM · Arcanist, Mercurial, Feature Request
epriestley closed T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 7:29 PM · Feed, Bug Report
epriestley triaged T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Normal priority.
Jun 23 2017, 7:16 PM · Policy, Dashboards, Bug Report
epriestley added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

D18152 should improve this: we'll still select the item as the default item, but will now render the navigation normally so the user can click other items:

Jun 23 2017, 7:15 PM · Policy, Dashboards, Bug Report
epriestley added a revision to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out: Unknown Object (Differential Revision).
Jun 23 2017, 7:11 PM · Policy, Dashboards, Bug Report
epriestley claimed T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jun 23 2017, 6:59 PM · Policy, Dashboards, Bug Report
epriestley renamed T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities from Prioritys are wrong to Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.
Jun 23 2017, 6:20 PM · Maniphest, Bug Report
epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

Specifically, the issue is that multiple different priorities used the same keywords ("low", "high").

Jun 23 2017, 6:19 PM · Maniphest, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

(That is, our behavior seems clearly incorrect.)

Jun 23 2017, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.

This just looks unambiguously wrong to me.

Jun 23 2017, 4:50 PM · Arcanist, Mercurial, Bug Report
epriestley added a comment to T12845: Convert remaining ancient configuration type classes to modern modular type classes.

I'm going to modularize this, but not before the release cut.

Jun 23 2017, 4:48 PM · Infrastructure, Config
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

Some of the (3), (2), (1) stuff is that we're trying to pick a single behavior which addresses most use cases reasonably well. For example, if we use "natural" bookmark names that will tend to make things much worse for users in bucket (3).

Jun 23 2017, 4:48 PM · Arcanist, Mercurial, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Thanks, that's much more clear than the original description!

Jun 23 2017, 4:42 PM · Remarkup, Feature Request
epriestley triaged T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField as Low priority.

(I think D18132 should fix this once someone gets a chance to look at it.)

Jun 23 2017, 4:22 PM · Feed, Bug Report
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Unknown Object (Differential Revision).
Jun 23 2017, 4:21 PM · Infrastructure
epriestley triaged T12866: Batch repository editing or repository groups for shared access control settings as Low priority.
Jun 23 2017, 4:18 PM · Diffusion, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Jun 23 2017, 4:18 PM · Remarkup, Feature Request
epriestley added a project to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Infrastructure.
Jun 23 2017, 3:54 PM · Infrastructure
epriestley added a comment to T12867: Youtube remarkup rule fails to parse "ambiguous URI".

This should now be fixed in HEAD of master, and promote to stable within about 12 hours. Thanks for the report! Let us know if you run into anything else.

Jun 23 2017, 3:43 PM · Remarkup, Bug Report
epriestley closed T12867: Youtube remarkup rule fails to parse "ambiguous URI" as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 3:43 PM · Remarkup, Bug Report
epriestley closed T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential as Resolved by committing Restricted Diffusion Commit.
Jun 23 2017, 3:14 PM · Drydock, Differential
epriestley added a revision to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Unknown Object (Differential Revision).
Jun 23 2017, 3:10 PM · Drydock, Differential
epriestley added a revision to T12867: Youtube remarkup rule fails to parse "ambiguous URI": Unknown Object (Differential Revision).
Jun 23 2017, 2:37 PM · Remarkup, Bug Report
epriestley renamed T12867: Youtube remarkup rule fails to parse "ambiguous URI" from Daemon fails to parse "ambiguous URI" to Youtube remarkup rule fails to parse "ambiguous URI".
Jun 23 2017, 2:30 PM · Remarkup, Bug Report
epriestley added projects to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential: Differential, Drydock.
Jun 23 2017, 2:24 PM · Drydock, Differential
epriestley added a project to T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: Customer Impact.

A related issue surfaced recently. Actual use case (forensically reconstructed):

Jun 23 2017, 2:22 PM · Customer Impact, Differential, Maniphest
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

Oh, this is actually the Mercurial flavor of this action. We have this one in the Git flavor, which is why I was surprised:

Jun 23 2017, 2:02 PM · Drydock, Differential
epriestley added a comment to T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.

My expectation is that this action can never appear -- this is the pre-Drydock hacky temporary action -- so something troubling is afoot.

Jun 23 2017, 2:01 PM · Drydock, Differential
epriestley created T12869: Disabled version of "Land to Hosted Repository" has no icon in Differential.
Jun 23 2017, 1:59 PM · Drydock, Differential
epriestley added a comment to T12866: Batch repository editing or repository groups for shared access control settings.

See also T10005 (bulk editors for all applications) and T6722.

Jun 23 2017, 1:38 PM · Diffusion, Feature Request
epriestley claimed T12867: Youtube remarkup rule fails to parse "ambiguous URI".

I think a minimal reproduction case which is typical of this example is:

Jun 23 2017, 1:35 PM · Remarkup, Bug Report

Jun 22 2017

epriestley closed T12859: Some means of updating builtin images without a manual purge as Resolved.

Ah, alright. Yeah, behavior is:

Jun 22 2017, 6:24 PM · Design
epriestley reopened T12859: Some means of updating builtin images without a manual purge as "Open".
Jun 22 2017, 6:20 PM · Design
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Oh, maybe I misunderstood. I thought you wanted an easier way to test changes in a development environment, but it sounds like you actually want end users to immediately get the new images instead of needing to wait 7 days for them?

Jun 22 2017, 6:20 PM · Design
epriestley closed T12859: Some means of updating builtin images without a manual purge as Resolved by committing Restricted Diffusion Commit.
Jun 22 2017, 6:14 PM · Design
epriestley closed T12860: Search by tag does not work in Phriction as Resolved by committing Restricted Diffusion Commit.
Jun 22 2017, 6:01 PM · Phriction, Bug Report
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

A slightly more aggressive fix would be to make these have a 5 second TTL in development or something (or hash the file modification time into the builtin key? But that's a bit tricky...) so you'd never have to purge the cache, but I think this arises rarely enough that it isn't too valuable.

Jun 22 2017, 5:58 PM · Design
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Strictly speaking, you still have to do a "manual purge" (with bin/cache ...) after D18146, but I assume you just didn't want to have to fish around in the DB.

Jun 22 2017, 5:57 PM · Design
epriestley added a revision to T12859: Some means of updating builtin images without a manual purge: Unknown Object (Differential Revision).
Jun 22 2017, 5:56 PM · Design
epriestley added a revision to T12859: Some means of updating builtin images without a manual purge: Unknown Object (Differential Revision).
Jun 22 2017, 5:44 PM · Design
epriestley added a revision to T12860: Search by tag does not work in Phriction: Unknown Object (Differential Revision).
Jun 22 2017, 5:26 PM · Phriction, Bug Report

Jun 21 2017

epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.
$engine = new PhabricatorDestructionEngine();
$engine->destroyObject($file);
Jun 21 2017, 8:13 PM · Design
epriestley added a comment to T12859: Some means of updating builtin images without a manual purge.

Also not sure how to "retire" ones from Projects I don't intend to replace (low value).

Jun 21 2017, 6:57 PM · Design
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

If you want to move forward with that:

Jun 21 2017, 6:35 PM · Diffusion, Ops, Daemons, Phacility
epriestley added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Great! Please mail support at support@phacility.com and identify which instance you're paying us for, then we're happy to help you. We won't help you here, since this isn't the right way for customers to get support.

Jun 21 2017, 6:27 PM · Phacility, Feature Request
epriestley added a comment to T12857: Temporary directory fullness can cause daemon issues?.

Every repo host is equally affected, so I'd like to deploy crontabs as part of the regular deployment process if we use them as part of the approach here. That would require first codifying a handful of custom crontabs, including one on secure which regenerates documentation daily on only one host. This codification should happen anyway eventually, but it's a little bit of work, and wasted effort if we're switching to Chef/Salt/Ansible/etc soon anyway.

Jun 21 2017, 5:57 PM · Diffusion, Ops, Daemons, Phacility
epriestley merged T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Restricted Project, Diffusion, Feature Request
epriestley merged task T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Diffusion, Feature Request
epriestley closed T12861: How to intergrate Infer's analysis result into Phabricator? as Invalid.

If you're a Phacility customer, please mail support at support@phacility.com (and identify your instance).

Jun 21 2017, 5:22 PM · Phacility, Feature Request
epriestley added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

Why is git diff --no-index being used instead of and diff, and why is --no-prefix being used?

Jun 21 2017, 4:59 PM · Arcanist, Bug Report
• tomekj2ee awarded T7924: Unprototype Calendar (v1) a Love token.
Jun 21 2017, 4:14 PM · Restricted Project, Prioritized, Calendar
epriestley closed T12858: test as Invalid.
Jun 21 2017, 10:56 AM

Jun 20 2017

epriestley added a revision to T12124: Counterintuitive priority setting via maniphest.edit conduit call: Restricted Differential Revision.
Jun 20 2017, 10:27 PM · Maniphest, Conduit, Bug Report