Page MenuHomePhabricator

Use a typeaheads for querying Object Types in Flags
Open, LowPublic

Description

When querying for Flags, we use a drop down for "Object Type". This only allows selecting one object type, so it makes sense to change this to be a typeahead instead.

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Flags.
joshuaspence added a subscriber: joshuaspence.
chad triaged this task as Low priority.Aug 5 2015, 9:45 PM
joshuaspence updated the task description. (Show Details)
epriestley moved this task from Backlog to vNext on the Flags board.Jan 6 2016, 3:21 AM

Flags currently has this unwieldy dropdown, which will only get worse over time as more applications and object types are added. It would be better to use a typeahead, like the one in global search:

Rough plan to implement this is:

  • Implement a new datasource similar to PhabricatorSearchDocumentTypeDatasource.
  • Use it in a way that's pretty much the same as PhabricatorSearchDocumentTypeDatasource.

You can't actually use that datasource because "indexable documents" and "flaggable objects" aren't the same set of objects, but your implementation should be pretty similar.

epriestley removed joshuaspence as the assignee of this task.Jul 3 2017, 2:13 PM