Page MenuHomePhabricator
Feed Advanced Search

Apr 5 2016

epriestley updated subscribers of T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.
Apr 5 2016, 5:53 PM · Maniphest
epriestley merged task T10726: task hierarchical view into T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.
Apr 5 2016, 5:53 PM · Feature Request
epriestley added a revision to T7303: Provide OAuth access to Conduit: Restricted Differential Revision.
Apr 5 2016, 5:15 PM · Restricted Project, Conduit, Restricted Project
epriestley added a comment to T10725: Can't access binary files of differential revision.

(That explanation might make approximately zero sense, I am not having a high-brain day today.)

Apr 5 2016, 4:11 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T10725: Can't access binary files of differential revision.

This is probably the "object policy evaluated in the context of a different object" issue we've seen occasionally. If so, setting the visibility policy to any non-object-policy value (e.g., "All Users", or a specific list of users, etc -- anything which does not depend on the revision) should fix the error.

Apr 5 2016, 4:10 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T10719: "status" field should not be copied from template when creating new tasks.

If we did add configuration, I think there are three ways we could do it:

Apr 5 2016, 11:02 AM · Maniphest, Feature Request
epriestley added a comment to T10716: Differential Checklist Feature Request.

A couple of general notes/thoughts:

Apr 5 2016, 10:15 AM · Differential, Feature Request
epriestley added a comment to T10570: Default quote action breaks tables.

Nice catch, thanks! D15619 should fix the docs.

Apr 5 2016, 9:01 AM · Wikimedia, Maniphest, Bug Report
epriestley added a revision to T10570: Default quote action breaks tables: Restricted Differential Revision.
Apr 5 2016, 9:00 AM · Wikimedia, Maniphest, Bug Report

Apr 4 2016

epriestley added a comment to T10722: Communicate drag policies clearly in the workboard/list UIs.
  • I'd currently consider this a user-expectation issue, but we're doing ourselves zero favors by not providing any kinds of hints about what expectation you should have. We should fix this first. I've realigned this task to discuss making the expectations/behavior more clear.
    • I believe the "edit permission is necessary" part of this rule is hard to reasonably get away from in light of column triggers (T5474). Not impossible, but hard.
    • The "edit permission is sufficient" part of this rule is easy to get away from, but we don't actually have use cases for requiring an additional project permission component right now (T6502).
Apr 4 2016, 10:42 PM · Workboards (v3), Bug Report
epriestley renamed T10722: Communicate drag policies clearly in the workboard/list UIs from Users without permission to edit a task can't move tasks on workboards they could edit to Communicate drag policies clearly in the workboard/list UIs.
Apr 4 2016, 10:34 PM · Workboards (v3), Bug Report
epriestley added a comment to T10722: Communicate drag policies clearly in the workboard/list UIs.

My current expectation is that the rule is supposed to be that edit permission on the task is both necessary and sufficient to move it on the workboard, but this is almost certainly not fully reflected in the UI, and possibly not fully reflected in permission checks in some cases (?) although it sounds like we're good from this discussion.

Apr 4 2016, 10:30 PM · Workboards (v3), Bug Report
epriestley added a member for Community: scode.
Apr 4 2016, 10:24 PM
epriestley renamed T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Authenticated proxy for remote URLs to Provide an extension point for HTTP behaviors (proxies, SSL trust).
Apr 4 2016, 9:43 PM · Prioritized, Restricted Project, Feature Request
epriestley added a comment to T10671: Implement `badges.search` and `badges.edit` Conduit API methods.

The new *.edit endpoints can both create and edit, so a badges.create method would be redundant.

Apr 4 2016, 7:20 PM · Restricted Project, Conduit, Badges (v0)
epriestley added a revision to T7303: Provide OAuth access to Conduit: Unknown Object (Differential Revision).
Apr 4 2016, 6:05 PM · Restricted Project, Conduit, Restricted Project
epriestley updated subscribers of T10721: SVN repositories with no callsigns do not route individual commit URLs properly.

@psawant, thanks for the report and for your help building a reproduction case for us on a Phacility instance. It was extremely helpful in identifying and resolving the root cause of this issue.

Apr 4 2016, 4:46 PM · Diffusion (v3)
epriestley closed T10721: SVN repositories with no callsigns do not route individual commit URLs properly, a subtask of T4245: Make repository URIs slightly prettier, as Resolved.
Apr 4 2016, 4:44 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley closed T10721: SVN repositories with no callsigns do not route individual commit URLs properly as Resolved by committing Restricted Diffusion Commit.
Apr 4 2016, 4:44 PM · Diffusion (v3)
epriestley edited this Badge.
Apr 4 2016, 4:44 PM
epriestley added a revision to T10721: SVN repositories with no callsigns do not route individual commit URLs properly: Unknown Object (Differential Revision).
Apr 4 2016, 4:43 PM · Diffusion (v3)
epriestley added a comment to T10721: SVN repositories with no callsigns do not route individual commit URLs properly.

A workaround is to give the repository a callsign Edit Repository → Edit Basic Information → Callsign.

Apr 4 2016, 4:32 PM · Diffusion (v3)
epriestley changed the edit policy for T10721: SVN repositories with no callsigns do not route individual commit URLs properly.
Apr 4 2016, 4:31 PM · Diffusion (v3)
epriestley added a comment to Q354: Svn imported repository diff does not show up.

This is a bug; see T10721 for followup and discussion.

Apr 4 2016, 4:31 PM
epriestley created T10721: SVN repositories with no callsigns do not route individual commit URLs properly.
Apr 4 2016, 4:31 PM · Diffusion (v3)
epriestley added a comment to Q354: Svn imported repository diff does not show up.

Thanks, looking at this now.

Apr 4 2016, 4:25 PM
epriestley added a comment to Q354: Svn imported repository diff does not show up.

I have taken down the public repository for time being.

Apr 4 2016, 4:10 PM
epriestley added a revision to T7303: Provide OAuth access to Conduit: Unknown Object (Differential Revision).
Apr 4 2016, 2:15 PM · Restricted Project, Conduit, Restricted Project
epriestley merged task T10720: Phriction wiki page TOC does not represent the hierarchical structure of the document into T9868: PHUIDocumentViewPro ToC menu improvements.
Apr 4 2016, 1:15 PM · Bug Report
epriestley updated subscribers of T9868: PHUIDocumentViewPro ToC menu improvements.
Apr 4 2016, 1:15 PM · PHUI
epriestley added a comment to T10720: Phriction wiki page TOC does not represent the hierarchical structure of the document.

This report does not describe a bug.

Apr 4 2016, 1:15 PM · Bug Report
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

The staging area is a Git remote that we'll push to, so it should be a valid target for git push <url> ....

Apr 4 2016, 12:04 PM · Restricted Project, Harbormaster
epriestley added a comment to T10719: "status" field should not be copied from template when creating new tasks.

This is intentional, so you can use a task as a template to create other tasks if you have, say, several different "open" statuses. The "Create Subtask" action specifically forces the status to the default open status, but I think the current behavior is correct for bare ?template= which has been entered manually.

Apr 4 2016, 11:59 AM · Maniphest, Feature Request
epriestley closed T10718: Please add an option to arc diff or arc land that can create revisions only and not push as Invalid.

@paladox, you've been warned repeatedly about your consistently low-quality interactions with this upstream.

Apr 4 2016, 11:52 AM · Arcanist, Feature Request
hach-que awarded T10697: Move Aphlict server configuration to a separate configuration file a Like token.
Apr 4 2016, 2:09 AM · Restricted Project, Aphlict

Apr 3 2016

• eduard44 awarded T10538: Bridge GitHub to Phabricator a Love token.
Apr 3 2016, 9:52 PM · Nuance, GitHub
epriestley added a comment to T10717: arc land does not work on windows.

You did not test the patch. As I noted, the patch runs git fetch --queit instead of git fetch --quiet.

Apr 3 2016, 8:26 PM · Windows, Bug Report (Needs Information), Arcanist
epriestley added a comment to T10717: arc land does not work on windows.

@paladox, your interactions with this upstream have consistently wasted our time and energy.

Apr 3 2016, 7:30 PM · Windows, Bug Report (Needs Information), Arcanist
epriestley added a revision to T7303: Provide OAuth access to Conduit: Unknown Object (Differential Revision).
Apr 3 2016, 4:13 PM · Restricted Project, Conduit, Restricted Project
epriestley added a revision to T7673: Make "Log Out" on Phacility instances behave in a way better aligned with user expectation: Unknown Object (Differential Revision).
Apr 3 2016, 4:13 PM · Auth, Phacility
epriestley added a revision to T7303: Provide OAuth access to Conduit: Unknown Object (Differential Revision).
Apr 3 2016, 3:41 PM · Restricted Project, Conduit, Restricted Project
epriestley added a comment to T10716: Differential Checklist Feature Request.

These things seem very general. I would expect them to be, e.g., on a wiki page like "Guidelines for Effective Code Review at <My Organization>". What advantage are you expecting to gain by building these into Differential as a checklist?

Apr 3 2016, 3:11 PM · Differential, Feature Request
epriestley added a revision to T7303: Provide OAuth access to Conduit: Unknown Object (Differential Revision).
Apr 3 2016, 2:27 PM · Restricted Project, Conduit, Restricted Project
epriestley added a comment to T10716: Differential Checklist Feature Request.

Can you give us some examples of the kinds of things you're checking for? Specifically, things where rote human review is the best solution to implementing a check?

Apr 3 2016, 2:15 PM · Differential, Feature Request
epriestley added a comment to T7303: Provide OAuth access to Conduit.

This is the only difficult blocker for T7673, a bad behavior which is annoying and sort of user-hostile, so I'd like to at least plan our way through it.

Apr 3 2016, 1:50 PM · Restricted Project, Conduit, Restricted Project
epriestley added a subtask for T7673: Make "Log Out" on Phacility instances behave in a way better aligned with user expectation: T7303: Provide OAuth access to Conduit.
Apr 3 2016, 1:31 PM · Auth, Phacility
epriestley added a parent task for T7303: Provide OAuth access to Conduit: T7673: Make "Log Out" on Phacility instances behave in a way better aligned with user expectation.
Apr 3 2016, 1:31 PM · Restricted Project, Conduit, Restricted Project
epriestley updated subscribers of T7303: Provide OAuth access to Conduit.
Apr 3 2016, 1:29 PM · Restricted Project, Conduit, Restricted Project
epriestley merged task T5020: Phabricator as a login provider into T7303: Provide OAuth access to Conduit.
Apr 3 2016, 1:29 PM · OAuthServer
epriestley added a comment to T5020: Phabricator as a login provider.

I am going to merge this into T7303, which is a slightly narrower task describing OAuth access to Conduit.

Apr 3 2016, 1:29 PM · OAuthServer
epriestley added a comment to T9512: "Change Password" should prompt users to "Reset Password" if no password has been set.

The workflow to set a password on an account which does not have one is:

Apr 3 2016, 1:20 PM · Restricted Project, Auth
epriestley renamed T9512: "Change Password" should prompt users to "Reset Password" if no password has been set from OAuth created account cannot have a password to "Change Password" should prompt users to "Reset Password" if no password has been set.
Apr 3 2016, 1:15 PM · Restricted Project, Auth
epriestley closed T4593: Mitigate OAuth session theft as Resolved.

I think there's nothing actionable remaining here. Both our and Facebook's modern instructions encourage users to whitelist redirect URIs.

Apr 3 2016, 1:11 PM · Security
epriestley closed T8926: Issues configuring external auth providers as Invalid.

This report doesn't have enough information for us to move forward or resolve it. See Providing Reproduction Steps for help with writing complete, self-contained reproduction steps that we can follow to reproduce an issue.

Apr 3 2016, 1:07 PM · Auth
epriestley moved T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked from Backlog to v0 on the Badges board.
Apr 3 2016, 12:55 PM · Badges (v0)
epriestley added a comment to T10714: Ability to click task number next to maniphest disappeared.

On my mobile device (an iPhone 4S), I think it's slightly faster to tap-wait-tap-copy the URL bar than press-hold-copy a link.

Apr 3 2016, 12:42 AM · Maniphest, Bug Report
epriestley merged task T10713: Changing the remote URI of a repository causes existing Drydock resources to break into T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.
Apr 3 2016, 12:12 AM · Drydock, Bug Report
epriestley merged T10713: Changing the remote URI of a repository causes existing Drydock resources to break into T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.
Apr 3 2016, 12:12 AM · Prioritized, Drydock
epriestley closed T10714: Ability to click task number next to maniphest disappeared as Invalid.

This report doesn't describe a bug.

Apr 3 2016, 12:11 AM · Maniphest, Bug Report

Apr 2 2016

epriestley closed T10709: incoming email handler replies multiple times for a single unrecognized command as Resolved.

This should now be resolved in production.

Apr 2 2016, 6:01 PM · Mail, Bug Report
epriestley added a revision to T10709: incoming email handler replies multiple times for a single unrecognized command: Unknown Object (Differential Revision).
Apr 2 2016, 5:36 PM · Mail, Bug Report
epriestley added a comment to T10709: incoming email handler replies multiple times for a single unrecognized command.

We have an additional safety check which is supposed to prevent this kind of issue: we refuse to process messages with the same "Message-ID" more than once.

Apr 2 2016, 5:25 PM · Mail, Bug Report
epriestley added a comment to T10712: Add support for zuul.

@paladox, we appreciate your enthusiasm but I think you have a very mistaken set of expectations about the kinds of services we provide. See some discussion in Support Resources.

Apr 2 2016, 5:09 PM · Differential, Feature Request
epriestley closed T10712: Add support for zuul as Wontfix.

We don't plan to support this in the upstream. We have a system in a similar role already (Harbormaster) and would prefer to expand it to do more if there is missing functionality.

Apr 2 2016, 4:51 PM · Differential, Feature Request
epriestley added a comment to T10709: incoming email handler replies multiple times for a single unrecognized command.

I think this is happening:

Apr 2 2016, 3:10 PM · Mail, Bug Report
epriestley claimed T10709: incoming email handler replies multiple times for a single unrecognized command.
Apr 2 2016, 3:07 PM · Mail, Bug Report
epriestley closed T10707: arc backout added bonus free "tips" to end of commit message as Resolved by committing Restricted Diffusion Commit.
Apr 2 2016, 2:26 PM · Arcanist, Bug Report
epriestley awarded T10707: arc backout added bonus free "tips" to end of commit message a Pterodactyl token.
Apr 2 2016, 1:32 PM · Arcanist, Bug Report
epriestley added a comment to T10707: arc backout added bonus free "tips" to end of commit message.

Thanks for the report, D15573 should fix this. Sorry about that!

Apr 2 2016, 1:31 PM · Arcanist, Bug Report
epriestley added a revision to T10707: arc backout added bonus free "tips" to end of commit message: Unknown Object (Differential Revision).
Apr 2 2016, 1:29 PM · Arcanist, Bug Report
epriestley renamed T10707: arc backout added bonus free "tips" to end of commit message from arc backout added unwelcome "tips" to end of commit message to arc backout added bonus free "tips" to end of commit message.
Apr 2 2016, 1:26 PM · Arcanist, Bug Report
epriestley updated subscribers of T5813: Countdown should offer sorting by expiration time.
Apr 2 2016, 12:23 PM · Countdown
epriestley merged task T10708: Sort countdowns by expiry time into T5813: Countdown should offer sorting by expiration time.
Apr 2 2016, 12:23 PM · Dashboards, Countdown, Feature Request
epriestley created T10706: Update old badge quality constants in PHUIBadgeExample.
Apr 2 2016, 12:04 AM · Badges (v0)

Apr 1 2016

epriestley edited the content of Changelog.
Apr 1 2016, 11:57 PM
epriestley created 2016 Week 14 (Early April).
Apr 1 2016, 11:57 PM
epriestley added a comment to T10705: You must use withSourcePHIDs() to query edges..

See Support Resources.

Apr 1 2016, 11:40 PM · Bug Report
epriestley added a comment to T8940: Annotate badges with awarder, date.

No, badges themselves don't have an awarder.

Apr 1 2016, 11:33 PM · Badges (v0)
epriestley closed T10705: You must use withSourcePHIDs() to query edges. as Invalid.

I know you guys want reproduction steps

Apr 1 2016, 11:30 PM · Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

jx-tooltip is a free spirit :3

Apr 1 2016, 9:11 PM · PHUI, Bug Report
epriestley added a comment to T10704: Comments on images in Differential (Right Side) cause JS error.

This should now be resolved in HEAD of master. I've deployed the change here, and verified I can interact with the comment in D15565.

Apr 1 2016, 7:58 PM · Differential, Bug Report
epriestley closed T10704: Comments on images in Differential (Right Side) cause JS error as Resolved by committing Restricted Diffusion Commit.
Apr 1 2016, 7:54 PM · Differential, Bug Report
epriestley added a revision to T10704: Comments on images in Differential (Right Side) cause JS error: Unknown Object (Differential Revision).
Apr 1 2016, 7:53 PM · Differential, Bug Report
epriestley added a comment to T10704: Comments on images in Differential (Right Side) cause JS error.

I think a workaround is to swap the particular changeset into unified mode (View Options → View Unified) and then interact with the comment, but the fix seems trivial and straightforward.

Apr 1 2016, 7:51 PM · Differential, Bug Report
epriestley claimed T10704: Comments on images in Differential (Right Side) cause JS error.
Apr 1 2016, 7:48 PM · Differential, Bug Report
epriestley added a comment to T10704: Comments on images in Differential (Right Side) cause JS error.

Thanks, I can reproduce this as well (e.g. D15565).

Apr 1 2016, 7:48 PM · Differential, Bug Report
epriestley removed a reviewer for D15563: This is to test: Blessed Reviewers.
Apr 1 2016, 6:45 PM
epriestley added a comment to T9007: Allow Badges to be ordered by quality.

Too many deck slots, product literally unplayable.

Apr 1 2016, 1:25 PM · Badges (v0)
epriestley renamed T9007: Allow Badges to be ordered by quality from Allow Badges to be ordered by Rarity to Allow Badges to be ordered by quality.
Apr 1 2016, 1:15 PM · Badges (v0)
epriestley added a comment to T9007: Allow Badges to be ordered by quality.

FUN POLICE HERE

Apr 1 2016, 1:15 PM · Badges (v0)
epriestley changed the image for Image Macro "siren".
Apr 1 2016, 1:14 PM
epriestley triaged T10698: Comment previews should display user badges under the author's profile image. as Low priority.

This is fairly messy and probably not worth fixing until the surrounding code is more modernized.

Apr 1 2016, 1:13 PM · Badges
epriestley added a subtask for T10364: Conpherence v4 (UI/UX): T10698: Comment previews should display user badges under the author's profile image..
Apr 1 2016, 1:07 PM · Conpherence (v4)
epriestley added a parent task for T10698: Comment previews should display user badges under the author's profile image.: T10364: Conpherence v4 (UI/UX).
Apr 1 2016, 1:07 PM · Badges
epriestley added a revision to T10698: Comment previews should display user badges under the author's profile image.: Unknown Object (Differential Revision).
Apr 1 2016, 1:06 PM · Badges
epriestley added a comment to T10703: Merge Duplicate Tasks should maybe default to All Open.

T7805 was the "use applicationsearch in the dialog" task.

Apr 1 2016, 12:29 PM · Maniphest, Feature Request
epriestley added a comment to T10703: Merge Duplicate Tasks should maybe default to All Open.

I think this default ("all my open stuff") is probably the right one for "Edit Dependencies" and "Edit Maniphest Tasks" from Differential, and for "Edit Blocking Tasks", "Edit Pholio Mocks" and "Edit Differential Revisions" in Maniphest, although the argument for some of those is a little weaker.

Apr 1 2016, 12:21 PM · Maniphest, Feature Request
epriestley added a comment to T10703: Merge Duplicate Tasks should maybe default to All Open.

In my flow I essentially only ever merge by copying the task ID, so the filter doesn't matter at all. Do you tend to search for the task by name?

Apr 1 2016, 12:19 PM · Maniphest, Feature Request
epriestley closed T5323: Incorrect syntax highlighting for PHP when using <script language='PHP'> as Wontfix.

Ah, interesting. I wasn't aware it was gone in PHP7. Given that, I agree that this probably isn't worth supporting (I've never seen this syntax in the wild myself).

Apr 1 2016, 12:09 PM

Mar 31 2016

epriestley created T10702: "Award Badge" action on user profiles should use a typeahead for badge selection.
Mar 31 2016, 9:11 PM · Badges (v0)