| swisspol | |
| Apr 2 2016, 2:34 AM |
| F1201128: pasted_file | |
| Apr 2 2016, 2:34 AM |
(Latest Phab on Phacility)
I just used arc backout to revert a commit on our Phab hosted Git repo, updated the first line which said something like << replace this with real title >>, and only quickly scanned the remaining lines, which looked fine, before saving and pushing.
The final commit message contains tips at the bottom!
These might have been part of the template, but I didn't notice them.
I can reproduce:
avive@vm:~/devtools/libphutil master$ arc backout @ Starting backout. Backing out commit @ Implement a stream iterator and hashing iterator Double-check the commit and push when ready. avive@vm:~/devtools/libphutil master$ git log -1 commit 3546d1d307b6a3971162ab5e359df909ce84da64 (HEAD -> master) Author: Aviv Eyal <avivey@gmail.com> Date: Fri Apr 1 21:05:33 2016 -0700 <<Replace this line with your Revision Title>> Summary: This reverts commit @. Test Plan: revert-hammer Reviewers: Subscribers: # Tip: In Git and Mercurial, use a branch like "T123" to automatically associate # changes with the corresponding task. avive@vm:~/devtools/libphutil master$
(git 2.6.2)
I'm guessing "git commit -F" doesn't strip # ?
Thanks for the report, D15573 should fix this. Sorry about that!
The change is purely in arc, so you'll need to arc upgrade to pick it up. If you use master, the fix should be available in a few hours once someone looks at it; if you run stable this just missed the release cut so it won't be available until next week (about 7 days from now).