Page MenuHomePhabricator
Create Task
Maniphest T10704

Comments on images in Differential (Right Side) cause JS error
Closed, ResolvedPublic
Actions

Description

steps to reproduce:

  1. git checkout -b cats
  2. git add cat.jpg
  3. git commit -m "cats!"
  4. arc diff master --verbatim
  5. open Revision
  6. add comment to (right side) image
  7. submit
  8. reload Revision
  9. try to mark the comment as Done, click reply, or in any other way interact with the comment

expected result: I expect the comment on the image to function exactly like comments on code files do, as it appears exactly the same

reality: clicks on any part of the comment don't do anything. the Done checkbox gets its "active" state but on release doesn't switch to "selected" state. Javascript console is full of core.pkg.js:2 Uncaught Error: JX.$('C2535NL1') call matched no nodes. errors that get triggered on mouseenter/mouseleave and click events

reproduced on: phacility instance

Revisions and Commits

rP Phabricator
D15566rP61301ead90e4 Fix javascript interaction with right-hand-side images in two-up diff views…

Related Objects

Mentioned Here
D15565: Test

Event Timeline

allixsenos created this task.Apr 1 2016, 7:40 PM
epriestley added a subscriber: epriestley.Apr 1 2016, 7:48 PM

Thanks, I can reproduce this as well (e.g. D15565).

epriestley claimed this task.Apr 1 2016, 7:48 PM
epriestley triaged this task as Normal priority.
chad renamed this task from comments on images in Differential broken to Comments on images in Differential (Right Side).Apr 1 2016, 7:50 PM
chad updated the task description. (Show Details)
chad added a project: Differential.
Herald added a subscriber: eadler. · View Herald TranscriptApr 1 2016, 7:50 PM
chad renamed this task from Comments on images in Differential (Right Side) to Comments on images in Differential (Right Side) cause JS error.Apr 1 2016, 7:50 PM
epriestley added a comment.Apr 1 2016, 7:51 PM

I think a workaround is to swap the particular changeset into unified mode (View Options → View Unified) and then interact with the comment, but the fix seems trivial and straightforward.

epriestley added a revision: D15566: Fix javascript interaction with right-hand-side images in two-up diff views in Differential.Apr 1 2016, 7:53 PM
epriestley closed this task as Resolved by committing rP61301ead90e4: Fix javascript interaction with right-hand-side images in two-up diff views….Apr 1 2016, 7:54 PM
epriestley added a commit: rP61301ead90e4: Fix javascript interaction with right-hand-side images in two-up diff views….
epriestley added a comment.Apr 1 2016, 7:58 PM

This should now be resolved in HEAD of master. I've deployed the change here, and verified I can interact with the comment in D15565.

This should reach Phacility instances on the next deploy, which will happen tomorrow morning (about 18 hours from now). I think the "Unified" workaround should work in the meantime if you have some stuff you really want to mark done or reply to.

Thanks for the report! Your detailed reproduction steps were very helpful in understanding and resolving the issue.

allixsenos added a comment.Apr 1 2016, 8:01 PM

my pleasure! thanks for the swift reaction and resolution, and very clear messaging on when we can expect the fix to be available on the phacility instance.

the issue is not blocking and the workaround is acceptable.

Phabricator · Built by Phacility