Move Aphlict server configuration to a separate configuration file
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Mar 30 2016, 2:09 PM

Description

Aphlict currently has five options which are only useful to the server (log, pidfile, ssl-cert, ssl-key) and should have two additional options (client-port, server-port) that we currently try to infer from client-uri and server-uri, sometimes unsuccessfully.

The set of options for configuring Aphlict is likely to grow in the future (e.g., log verbosity, cluster configuration, address binding). I think there is no value in retaining these in Phabricator configuration and plan to move them to a dedicated Aphlict configuration file.

I think this will make Aphlict easier to configure on the balance (client and server configuration will be more clearly separated and less intertwined) and Phabricator easier to configure (the user will be presented with fewer options).

Part of this change will separate listening ports explicitly, which should resolve difficulty users currently experience when running Aphlict via nginx so the client port and client-listening-port differ.

Revisions and Commits

rP Phabricator
	D15729	rPb2db1ec2ca21 Make `bin/aphlict stop` read new config properly
	D15705	rPd4bf2a147b7a Make paths and Aphlict instance names less ambiguous
	D15703	rP2930733ac99f Complete modernization of Aphlict configuration
	D15702	rPc6b092595497 Move Aphlict logging and PID configuration options to config file
	D15701	rPc84dee522bb4 Move server-related Aphlict options to a configuration file
	D15700	rPe32ce529d73f Begin generalizing Aphlict server to prepare for clustering/sensible config file
	D15698	rPa2588d62e7f6 Minor `bin/aphlict` cleanup

Related Objects
Search...

		Status	Assigned	Task
		Resolved	epriestley	T6915 Allow the Aphlict server to scale across multiple hosts
		Resolved	epriestley	T10697 Move Aphlict server configuration to a separate configuration file

Event Timeline

epriestley created this task.Mar 30 2016, 2:09 PM

epriestley mentioned this in T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict.

epriestley merged a task: T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict.

epriestley added subscribers: beber, eadler, alexandros.tsourakis and 5 others.

epriestley mentioned this in T8169: Intermittent issues with Aphlict / Notifications.Mar 30 2016, 2:13 PM

epriestley mentioned this in T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx).Mar 30 2016, 2:20 PM

epriestley merged a task: T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx).

epriestley added subscribers: • kanarip, chr86, • cvl, tycho.tatitscheff.

eadler added a comment.Mar 30 2016, 5:47 PM

This comment was removed by eadler.

eadler added a project: Restricted Project.Mar 30 2016, 5:49 PM

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Per T9293, client-uri and server-uri should be split into client-port, client-host, admin-port and admin-host.

salvian added a subscriber: salvian.Mar 31 2016, 2:42 AM

hach-que awarded a token.Apr 4 2016, 2:09 AM

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 13 2016, 3:33 AM

epriestley mentioned this in T8180: Notifications UI stuck in "Setting Up Client" after configuring websockets & aphlic.Apr 13 2016, 1:42 PM

epriestley added a parent task: T6915: Allow the Aphlict server to scale across multiple hosts.Apr 13 2016, 1:58 PM

Per T6915, I'm likely to split the Phabricator side config into a list of services. If you run multiple servers, you list all of them and Phabricator can survive the loss of some subset gracefully. This should be easier for everyone to configure, too.