Page MenuHomePhabricator
Feed Advanced Search

Mar 31 2016

epriestley closed T10699: Add staging URLs into `repository.create` endpoint as Resolved.

Sounds good. I added you to Community so you should have sweeping administrative powers now.

Mar 31 2016, 8:47 PM · Feature Request
epriestley added a member for Community: • jshirley.
Mar 31 2016, 8:47 PM
epriestley updated subscribers of T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Mar 31 2016, 8:18 PM · Customer Impact, Restricted Project, Mail
epriestley merged task T10701: Allow emails only for @mentions into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Mar 31 2016, 8:18 PM · Feature Request
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

The more modern, slightly more concise process is:

Mar 31 2016, 7:35 PM · Phacility
epriestley renamed T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from Aphlict slowly grows to use an uncomfortably large amount of memory to Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.
Mar 31 2016, 6:44 PM · Aphlict, Phacility, Ops
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm thinking for my case, there's not really a lot of value in keeping the tags around after the diff has been closed. Maybe that's something to consider?

Mar 31 2016, 5:52 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

I probably wouldn't show them in the UI for now, although I don't think adding an "Other Refs" table underneath tags/branches on the main screen with, say, 5 entries and a "See All" button would necessarily be terrible if anyone can come up with a reason that users might ever care about it.

Mar 31 2016, 5:45 PM · Wikimedia, Restricted Project, Diffusion
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

User profile images should be getting cached. For example, your profile image here:

Mar 31 2016, 5:28 PM · Restricted Project, Restricted Project, Wikimedia, Files
jdiepenmaat awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Mar 31 2016, 2:16 PM · Calendar
epriestley closed T10700: Disable a Username change for the Registration via a Provider as Resolved.

Sounds good. Let us know if you run into anything else.

Mar 31 2016, 1:46 PM · Auth, Feature Request
epriestley added a comment to T10700: Disable a Username change for the Registration via a Provider.

You can register an event listener for the TYPE_AUTH_WILLREGISTERUSER event. We are generally moving away from this system, but it works today and I don't have any near-term plans to replace it in this case. This is the documentation:

Mar 31 2016, 1:35 PM · Auth, Feature Request
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

I haven't been successful locally in getting a GC'd node to reach an appreciable level of memory consumption, and the production servers are currently at ~1.5GB.

Mar 31 2016, 12:52 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

I think the ~1.5GB node instance size is also expected.

Mar 31 2016, 12:38 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

This is useful, but are there any plans to add this functionality to the GUI? Would be nice to have for when we're doing some housekeeping

Mar 31 2016, 3:31 AM · Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

See T10350.

Mar 31 2016, 1:33 AM · Restricted Project, Projects (v3)
epriestley added a comment to T10698: Comment previews should display user badges under the author's profile image..

Sorry, Vehicle VIN Identification Numbers.

Mar 31 2016, 1:26 AM · Badges
epriestley added a comment to T10698: Comment previews should display user badges under the author's profile image..

(It mostly has reference stuff like our vehicle VIN numbers, our PG&E account number and credentials, etc. If you hack it, you can pay our electric bill!)

Mar 31 2016, 1:26 AM · Badges
epriestley added a comment to T10698: Comment previews should display user badges under the author's profile image..

There is, but we don't use it very much.

Mar 31 2016, 1:22 AM · Badges
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

At least locally, I can't manage to get node to not leak:

Mar 31 2016, 12:02 AM · Aphlict, Phacility, Ops

Mar 30 2016

epriestley added a comment to T10699: Add staging URLs into `repository.create` endpoint.

Oh, and as an unusual special case I'll upstream anything you want to do to PhabricatorRepositoryManagementEditWorkflow and we'll keep it not-broken until T10337, although I promise to break it after that. This workflow has special favor and exists outside the normal rules of usptreaming hacks.

Mar 30 2016, 10:42 PM · Feature Request
epriestley added a comment to T10699: Add staging URLs into `repository.create` endpoint.

You can also just update the JSON value in the details column in phabricator_repository.repository directly. This won't generate a proper transaction in the edit record, but will work correctly (that column is authoritative, and not cached by anything).

Mar 30 2016, 10:39 PM · Feature Request
epriestley added a comment to T10699: Add staging URLs into `repository.create` endpoint.

This would be strictly obsoleted by T10337 and not help us build toward it, so we'd prefer not to pursue it in the upstream.

Mar 30 2016, 10:08 PM · Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

To actually do forking, the pathway is roughly:

Mar 30 2016, 9:41 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

We can do "private branches", but you can already do something like this:

Mar 30 2016, 9:27 PM · Restricted Project, Diffusion, Feature Request
epriestley renamed T10691: Support GitHub-like forking of repositories from Provide a way for users to publish rebased or otherwise "rewritten" branches without generating a ton of email to Support GitHub-like forking of repositories.
Mar 30 2016, 9:22 PM · Restricted Project, Diffusion, Feature Request
epriestley added Q353: How do I get a non-block-based custom remarkup rule to work fine in phabricator? (Answer 353).
Mar 30 2016, 8:41 PM
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

We're seeing a lot of connections stick in "R" ("Reading Request") for a long time, but the client is the load balancer and the request hasn't been read yet so it's not clear exactly what's going on with these. I think they may be crawlers, since pretty much every search engine loves indexing everything on this install hundreds of times an hour.

Mar 30 2016, 6:35 PM · Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

I'm fiddling with LB health checks, so it's my fault if the server vanishes.

Mar 30 2016, 6:22 PM · Phacility, Ops
epriestley added a comment to T10697: Move Aphlict server configuration to a separate configuration file.

Per T9293, client-uri and server-uri should be split into client-port, client-host, admin-port and admin-host.

Mar 30 2016, 6:03 PM · Restricted Project, Aphlict
epriestley added a comment to T9293: WebSockets access problems with reverse SSL proxy .

I'll make a note on T10697 to split these options into explicit host and port options. The use of uri options which combined hosts and ports was intended to make specifying hosts and ports more convenient, but I think it's clear that it was a grievous error.

Mar 30 2016, 6:02 PM · Restricted Project, Aphlict
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

MaxRequestWorkers 24 appears to be creating some issues. This host only serves about 5 requests/second, but I can hit delays with concurrency of 10 (e.g., ab -n100 -c10):

Mar 30 2016, 5:13 PM · Phacility, Ops
epriestley added a comment to T9293: WebSockets access problems with reverse SSL proxy .

Using client-uri will cause us to use wss:// on pages which are http:// on the client. This seems very confusing/unexpected to me. Although this is probably fine usually, it defies user intent and may not work if, for example, the server certificate is self-signed and the user is using http specifically because their client does not recognize the CA. Such a user would be confused: "I'm connecting with HTTP and it says HTTP in my browser, but I'm getting an SSL certificate error. I specifically switched to HTTP because I know that this client can not trust the certificate."

Mar 30 2016, 3:03 PM · Restricted Project, Aphlict
epriestley added a comment to T9293: WebSockets access problems with reverse SSL proxy .

$_SERVER['HTTPS'] should always reflect the SSL-ness of the original connection. If it does not, it is misconfigured.

Mar 30 2016, 3:00 PM · Restricted Project, Aphlict
epriestley added a comment to T10349: Projects v3 Errata.

See T10326.

Mar 30 2016, 2:26 PM · Restricted Project, Projects (v3)
epriestley updated subscribers of T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:20 PM · Restricted Project, Aphlict
epriestley merged task T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx) into T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:20 PM · Restricted Project, Aphlict
epriestley added a comment to T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx).

I plan to make these options explicit instead. This tangled maze of inferring things from various values is a bad state of affairs. See T10697.

Mar 30 2016, 2:20 PM · Restricted Project, Aphlict
epriestley closed T9293: WebSockets access problems with reverse SSL proxy as Wontfix.

To resolve this, configure your server so that $_SERVER['HTTPS'] is set correctly. This impacts other checks, so it is much better to fix it than try to guess our way around it by examining aphlict.client-uri.

Mar 30 2016, 2:18 PM · Restricted Project, Aphlict
epriestley closed T8169: Intermittent issues with Aphlict / Notifications as Invalid.

This doesn't describe a reproducible problem. See Providing Reproduction Steps.

Mar 30 2016, 2:13 PM · Aphlict
epriestley updated subscribers of T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:10 PM · Restricted Project, Aphlict
epriestley merged task T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict into T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:10 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley added a comment to T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict.

I plan to separate this configuration and make these options all explicit, see T10697.

Mar 30 2016, 2:10 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley created T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:09 PM · Restricted Project, Aphlict
epriestley moved T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley moved T8169: Intermittent issues with Aphlict / Notifications from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Aphlict
epriestley moved T9293: WebSockets access problems with reverse SSL proxy from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Restricted Project, Aphlict
epriestley moved T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx) from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Restricted Project, Aphlict
epriestley moved T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

The Aphlict logs don't reveal anything useful, and could use some attention: they're heavily geared toward setup/debugging, not maintenance/operations.

Mar 30 2016, 1:16 PM · Aphlict, Phacility, Ops
epriestley added a project to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full: Aphlict.
Mar 30 2016, 1:14 PM · Aphlict, Phacility, Ops
epriestley created T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.
Mar 30 2016, 1:10 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

I've deployed a MaxRequestWorkers 24 change to this server and wasn't able to get it to burst over 24 workers with ab, so that seems to be working. I'll keep an eye on it for the rest of the week, and the 48 limit will go out to the cluster later this week if no problems turn up.

Mar 30 2016, 12:57 PM · Phacility, Ops
epriestley renamed T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers from OOM killer nuked `mysql` on `secure.phabricator.com` after numerous simultaneous macro thumbnailing requests (?) forced into a low-memory condition to OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.
Mar 30 2016, 12:37 PM · Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

To prevent this, I plan to:

Mar 30 2016, 12:37 PM · Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

Here's the smoking gun from /var/log/syslog:

Mar 30 2016, 12:33 PM · Phacility, Ops
epriestley created T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.
Mar 30 2016, 5:49 AM · Phacility, Ops
epriestley created T10694: Improve behavior of context for inline comments in mail.
Mar 30 2016, 1:49 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

See also T5701 for bonus complexity.

Mar 30 2016, 12:09 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley renamed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments from HTML email doesn't syntax highlight code blocks to HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Mar 30 2016, 12:09 AM · Prioritized, Restricted Project, Remarkup, Mail
epriestley closed T10693: Allow setting --plan-changes in Differential UI as Resolved.
Mar 30 2016, 12:02 AM · Feature Request

Mar 29 2016

epriestley added a comment to T10693: Allow setting --plan-changes in Differential UI.

This option should already be available from the UI. Here's a screenshot?

Mar 29 2016, 11:47 PM · Feature Request
epriestley updated subscribers of T4190: Rebuild remarkup image proxying.

@jshirley, here's the issue we spoke about earlier.

Mar 29 2016, 11:26 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

Anyway, assuming this is a "freedom and flexibility" issue over a "perform only reasonable operations" issue, we're definitely open to implementing forking, but this is probably in the realm of prioritization with a nontrivial set of infrastructure and product blockers.

Mar 29 2016, 11:11 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

I think I'm still missing something here -- are users doing this?

Mar 29 2016, 10:52 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

In this case, does the branch contain reviewed changes, or just draft changes by multiple different authors?

Mar 29 2016, 5:54 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10688: Badge translation error.

I think these steps should reproduce the issue:

Mar 29 2016, 5:22 PM · Badges, Bug Report
epriestley updated subscribers of T10574: A pathway toward "All Reviewers Must Accept".
Mar 29 2016, 3:26 PM · FreeBSD, Restricted Project, Differential
epriestley merged task T10689: Display slightly more information about status of revision from main page. into T10574: A pathway toward "All Reviewers Must Accept".
Mar 29 2016, 3:26 PM · Feature Request (Needs Information)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

Root problem: To ensure quality software, I want to make sure that all reviewers accept a change.

Mar 29 2016, 3:26 PM · Feature Request (Needs Information)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

I think that's just a rewording of the original description, and doesn't provide any new insight or context. It still focuses on a very narrow symptom problem (not being able to see individual reviewer status from the revision list), not the root problem.

Mar 29 2016, 2:30 PM · Feature Request (Needs Information)
epriestley created T10690: Allow badges to be searched by name.
Mar 29 2016, 2:24 PM · Badges (v0)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 29 2016, 2:18 PM · Nuance (v1)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

T1279 is talking about the reviewer list on the detail page (/Dxxx), not the list page (/differential/). This was implemented years ago, so I suspect it isn't a duplicate, unless you're years out of date.

Mar 29 2016, 2:04 PM · Feature Request (Needs Information)
epriestley moved T10689: Display slightly more information about status of revision from main page. from Backlog to Needs Information on the Feature Request board.
Mar 29 2016, 1:51 PM · Feature Request (Needs Information)
epriestley added a comment to T10689: Display slightly more information about status of revision from main page..

Thanks for the request!

Mar 29 2016, 1:43 PM · Feature Request (Needs Information)
epriestley assigned T10688: Badge translation error to lpriestley.

D15545 should fix the infrastructure part of this, and make this error more clear by returning an explicit diagnostic error rather than a mostly-working string and a log.

Mar 29 2016, 12:33 PM · Badges, Bug Report
epriestley added a revision to T10688: Badge translation error: Unknown Object (Differential Revision).
Mar 29 2016, 12:31 PM · Badges, Bug Report
epriestley added a comment to T10688: Badge translation error.

Oh, I believe the actual issue is that the translations are variant on the wrong parameter. I think this is the correct fix (adding an extra array()):

Mar 29 2016, 12:10 PM · Badges, Bug Report
epriestley added a comment to T10688: Badge translation error.

D15544 (changing %s to %d) shouldn't be the fix for this -- %s is correct, because we want to render "1,234,567" if the number is large:

Mar 29 2016, 12:08 PM · Badges, Bug Report

Mar 28 2016

epriestley added a revision to T10537: Nuance Infrastructure: Restricted Differential Revision.
Mar 28 2016, 7:46 PM · Nuance (v1)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Restricted Differential Revision.
Mar 28 2016, 7:46 PM · Nuance, GitHub
epriestley assigned T6526: Implement "Badges" or "Medals", for annotating special users to lpriestley.
Mar 28 2016, 7:36 PM · Restricted Project, Badges (v0), People
epriestley assigned T8940: Annotate badges with awarder, date to lpriestley.
Mar 28 2016, 7:36 PM · Badges (v0)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 28 2016, 6:44 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 28 2016, 6:35 PM · Nuance (v1)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 28 2016, 6:00 PM · Nuance (v1)
epriestley updated subscribers of T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines.

D15535 should completely fix this in all cases

Mar 28 2016, 5:36 PM · Remarkup, Bug Report
epriestley added a revision to T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines: Unknown Object (Differential Revision).
Mar 28 2016, 5:24 PM · Remarkup, Bug Report
epriestley closed T10686: Remarkup: Unable to use italics on a quoted header line as Resolved by committing Restricted Diffusion Commit.
Mar 28 2016, 4:12 PM · Remarkup, Bug Report
epriestley added a revision to T10686: Remarkup: Unable to use italics on a quoted header line: Unknown Object (Differential Revision).
Mar 28 2016, 4:11 PM · Remarkup, Bug Report
epriestley claimed T10686: Remarkup: Unable to use italics on a quoted header line.

u wot m8? havin' a go? havin' a little laff?

Mar 28 2016, 4:09 PM · Remarkup, Bug Report
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

Specifically, the issue here is that we fetch and import branch heads, but not other refs, including tags. We also aren't totally consistent about which refs we import across hosted/imported repositories.

Mar 28 2016, 3:35 PM · Wikimedia, Restricted Project, Diffusion

Mar 27 2016

epriestley added a subtask for T10364: Conpherence v4 (UI/UX): T10683: New Conpherence participant makes the conversation unread but does not update subtitle.
Mar 27 2016, 7:34 PM · Conpherence (v4)
epriestley added a parent task for T10683: New Conpherence participant makes the conversation unread but does not update subtitle: T10364: Conpherence v4 (UI/UX).
Mar 27 2016, 7:34 PM · Conpherence (v4), Bug Report
epriestley added a comment to T10682: Applications have no profile photos when they author transactions.

At a minimum, Herald, Harbormaster, Nuance, Phortune and Differential can author stories today, although not all of these stories currently render with photos. We should probably assume any application may author stories.

Mar 27 2016, 7:00 PM · Restricted Project, Harbormaster, Bug Report
epriestley renamed T10682: Applications have no profile photos when they author transactions from Harbormaster has no "user photo" in feed to Applications have no profile photos when they author transactions.
Mar 27 2016, 6:58 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T10682: Applications have no profile photos when they author transactions.

See also vaguely-related T8952.

Mar 27 2016, 5:33 PM · Restricted Project, Harbormaster, Bug Report
epriestley created T10681: Add Phurl Conduit API methods .
Mar 27 2016, 5:04 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley renamed T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion from Audit form in Diffusion should be optional to Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
Mar 27 2016, 5:02 PM · Audit, Diffusion, Wikimedia