Page MenuHomePhabricator
Feed Advanced Search

May 30 2017

NDKilla added a comment to T12755: Aphlict doesn't work with the latest version of `ws`.

This is kind of time-specific since it has a version number, but I got Aphlict working on my server by navigating to phabricator/support/aphlict/server and running npm install ws@2.X (literal X) as root. This installed version 2.3.1 (im assuming the latest stable 2.X version). Upon restarting aphlict, the notifications work without raising exceptions.

May 30 2017, 2:50 PM · Aphlict, Bug Report
epriestley merged task T12774: No margin after inline comment reply button into T12688: Inline Comment Design Opportunities for Improvement.
May 30 2017, 12:32 PM · Bug Report
epriestley merged T12774: No margin after inline comment reply button into T12688: Inline Comment Design Opportunities for Improvement.
May 30 2017, 12:32 PM · Design, Differential, Inline Comments
epriestley added a comment to T12774: No margin after inline comment reply button.

See T12688#223690.

May 30 2017, 12:31 PM · Bug Report
epriestley added a comment to T12775: InvalidArgumentException in PhabricatorStandardPageView after setting unexpected JSON in ui.footer-items.

You should be able to use bin/config delete ui.footer-items --database to fix things.

May 30 2017, 12:31 PM · Bug Report
JeanFred created T12775: InvalidArgumentException in PhabricatorStandardPageView after setting unexpected JSON in ui.footer-items.
May 30 2017, 11:19 AM · Bug Report
aik099 created T12774: No margin after inline comment reply button.
May 30 2017, 7:26 AM · Bug Report
joshuaspence added a comment to Q622: It is still a requirement that only one repo pull daemon runs without `--no-discovery` (Answer 548).

Thanks for the very detailed response.

May 30 2017, 1:52 AM

May 29 2017

joshuaspence abandoned D18040: Maintain POST requests when following redirects.

Yep, that's a better solution. In the mean time, we just updated all of our .arcconfig files.

May 29 2017, 11:31 PM
• sshannin added a comment to T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration.

I had indeed implemented precisely that herald rule once I realized that these diffs were being created without repository info attached. I also added repository.callsign to /etc/arcconfig to eliminate the problem going forward.

May 29 2017, 5:05 PM · Arcanist, Customer Impact, Differential, Spaces, Feature Request
epriestley closed T12662: Validation error on accepting a revision on behalf of a project that had already accepted it as Resolved.
May 29 2017, 4:14 PM · Differential, Bug Report
epriestley added a comment to D18040: Maintain POST requests when following redirects.

I think we should probably not follow redirects from arc at all.

May 29 2017, 4:11 PM
isfs added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

We could change the behavior to "tap and hold to begin a range + drag".

May 29 2017, 3:33 PM · Inline Comments, Installing & Upgrading, Differential
epriestley renamed T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration from differential items with no repository attached cannot be hidden from spaces to Users can mistakenly create revisions with no repository through confusion or misconfiguration.
May 29 2017, 2:42 PM · Arcanist, Customer Impact, Differential, Spaces, Feature Request
epriestley added a project to T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration: Customer Impact.

We've seen a couple of flavors of this from @swisspol, too. Although the symptom there is a little different (not a policy issue, exactly), the root cause is mostly similar. In particular, we saw:

May 29 2017, 2:41 PM · Arcanist, Customer Impact, Differential, Spaces, Feature Request
epriestley added a comment to T12766: Can't use `differential.createcomment` with message and action.

(In this case, our behavior was strictly wrong, completely accidental, and trivial to fix -- but sooner or later we may make some kind of change which isn't very compatible with this older style of integration in a more fundamental way. When we do, a blog post from 2013 suggesting a set of workarounds at the time won't hold back the tides of change.)

May 29 2017, 2:19 PM · Differential, Conduit, Bug Report
epriestley added a comment to T12766: Can't use `differential.createcomment` with message and action.

The general story on Build/CI is this:

May 29 2017, 2:14 PM · Differential, Conduit, Bug Report
epriestley closed T12770: The "need" saved query of Diffusion not upgraded as Resolved.

I think I didn't migrate this since there was no direct analog -- my memory's a little fuzzy, but I think the old query had some bugs / weird behaviors / general differences and there's no exact way to represent it after the change (and even if there was, the newer version -- with bucketing -- is probably way better for most users, so it's good to upgrade anyway). I figured it was better to just break it in an obvious way than subtly change it, which could be more confusing, I think.

May 29 2017, 2:00 PM · Dashboards, Audit, Bug Report
chad merged T12772: Editing tabbed panel on dashboard removes tabs on save into T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.
May 29 2017, 1:56 PM · Dashboards, Bug Report
chad merged task T12772: Editing tabbed panel on dashboard removes tabs on save into T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.
May 29 2017, 1:56 PM · Bug Report
chad edited projects for T12773: User image is found broken on migrating to the latest version of Phabricator., added: Bug Report (Needs Information); removed Bug Report.
May 29 2017, 1:53 PM · Bug Report (Needs Information)
chad added a comment to T12773: User image is found broken on migrating to the latest version of Phabricator..

There isn't enough information here to reproduce the issue as described. Do you have additional steps I can follow and see the issue locally?

May 29 2017, 1:52 PM · Bug Report (Needs Information)
ivo added a comment to T12662: Validation error on accepting a revision on behalf of a project that had already accepted it.

I'm not allowed to close this, but it was fixed by T12757

May 29 2017, 12:05 PM · Differential, Bug Report
ivo added a revision to T12662: Validation error on accepting a revision on behalf of a project that had already accepted it: Unknown Object (Differential Revision).
May 29 2017, 12:03 PM · Differential, Bug Report
Nirjhar created T12773: User image is found broken on migrating to the latest version of Phabricator..
May 29 2017, 10:23 AM · Bug Report (Needs Information)
atul.agrawal9911 added a comment to T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).

Now i have changed that

May 29 2017, 9:02 AM · Setup
michelkaeser added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

In case anyone is still looking for a Trac Wiki -> Phabricator Phriction importer, we have an ugly but mainly functional script I pasted here: P2056. Code blocks are not always converted correctly, but for us that script was enough.

May 29 2017, 9:01 AM · Guides, Doorkeeper
michelkaeser created P2056 Trac Wiki Import Script.
May 29 2017, 8:59 AM · Phriction
jjooss added a comment to T12766: Can't use `differential.createcomment` with message and action.

Also, test agents probably shouldn't be accepting revisions at all. But ¯\_(ツ)_/¯

May 29 2017, 8:43 AM · Differential, Conduit, Bug Report
aik099 created T12772: Editing tabbed panel on dashboard removes tabs on save.
May 29 2017, 8:14 AM · Bug Report
bbrdaric asked Q624: How to rename files in Files app?.
May 29 2017, 8:03 AM · Files
• sshannin created T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration.
May 29 2017, 12:57 AM · Arcanist, Customer Impact, Differential, Spaces, Feature Request

May 28 2017

joshuaspence added a comment to D18040: Maintain POST requests when following redirects.

@epriestley, if you had any thoughts on this it would be appreciated as this issue is heavily affecting our users. There is a workaround (update our .arcconfig files to point to the new domain), but we have a lot of repositories...

May 28 2017, 11:04 PM
joshuaspence created D18040: Maintain POST requests when following redirects.
May 28 2017, 11:03 PM
amckinley created P2055 migration.php.
May 28 2017, 10:51 PM
chad added projects to T12770: The "need" saved query of Diffusion not upgraded : Audit, Dashboards.
May 28 2017, 8:22 PM · Dashboards, Audit, Bug Report
chad added a comment to T12770: The "need" saved query of Diffusion not upgraded .

Thanks! We'll keep this around and see if a migration is needed. Sounds like mostly a dashboards issue.

May 28 2017, 8:22 PM · Dashboards, Audit, Bug Report
chad added a comment to T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.

@exp10r3r you still need to provide reproduction steps. Based on the ones provided, I cannot reproduce any issue using a new/clean install on Phacility or locally. That doesn't mean there isn't a bug to fix, but without the specifics needed to observe and troubleshoot the issue, we have no idea where to start or what to look for. Because we provide support for free, it's on report submitters to fill in all the details needed here. We can't assist with that. No other install is reporting this issue, so it's unlikely due to any change from the upstream.

May 28 2017, 7:46 PM · Bug Report (Needs Information)
exp10r3r updated the task description for T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.
May 28 2017, 5:54 PM · Bug Report (Needs Information)
aik099 added a comment to T12770: The "need" saved query of Diffusion not upgraded .

Can you just pick a new query and fix the panel?

May 28 2017, 5:45 PM · Dashboards, Audit, Bug Report
chad added a comment to T12770: The "need" saved query of Diffusion not upgraded .

Can you just pick a new query and fix the panel? My thought is if only 1 person in 12 months is affected, it's going to be faster for you to fix the panel than for us to find resources to build an old image and test migrations.

May 28 2017, 3:26 PM · Dashboards, Audit, Bug Report
aik099 updated the task description for T12770: The "need" saved query of Diffusion not upgraded .
May 28 2017, 2:58 PM · Dashboards, Audit, Bug Report
aik099 created T12770: The "need" saved query of Diffusion not upgraded .
May 28 2017, 2:58 PM · Dashboards, Audit, Bug Report
LeCoyote added a comment to T7108: high server load due to continuous hg calls.

I can confirm T12129 is indeed related, and the suggested workaround is very effective. Thanks for this!
For the record, our repo has about 60 branches total (about a dozen active only).

May 28 2017, 2:46 PM · Mercurial
cspeckmim awarded M1476: Inline Comment Browse bar a Grey Medal token.
May 28 2017, 1:00 PM
aik099 awarded T10978: Modernize Audit a Like token.
May 28 2017, 8:20 AM · Audit
chad added a comment to M1476: Inline Comment Browse bar.

Took another pass here. I'd still like to figure out a way to get and working, but I could also just design them into the comments like they previously were. I think it's better though to have them in the top bar, since I could click on the and get right to the first bit of work I need to do.

May 28 2017, 4:21 AM
chad updated images of M1476: Inline Comment Browse bar.
May 28 2017, 4:14 AM
chad added a comment to M1476: Inline Comment Browse bar.

(though we could add a mini-minimap to it, just a thought)

May 28 2017, 3:31 AM
chad added a comment to M1476: Inline Comment Browse bar.

(it's probably distracting and pointless though for code review)

May 28 2017, 3:25 AM
chad added a comment to M1476: Inline Comment Browse bar.

To be clear, the "progress bar" background was a simple scroll indicator, nothing related to marking things done. Some blogs use them and I find in ... interesting ... nothing more. It's sort of nice to know how much you have to read through to be finished. It would start at the top of the first file and end when the final comment box appears. You can see one in action here: http://www.avclub.com/article/why-does-superman-keep-getting-turned-dictator-255977

May 28 2017, 3:24 AM
chad merged T12769: Applications page shows Diffusion on admin into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
May 28 2017, 2:58 AM · Audit, Diffusion, Wikimedia
chad merged task T12769: Applications page shows Diffusion on admin into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
May 28 2017, 2:58 AM · Phacility, Bug Report
joshuaspence created T12769: Applications page shows Diffusion on admin.
May 28 2017, 2:26 AM · Phacility, Bug Report

May 27 2017

epriestley merged T12765: Autofixes removing lines render incorrectly in `arc lint` into T9846: Diff on `arc lint` misleading when the replacement has newlines.
May 27 2017, 8:08 PM · Restricted Project, Arcanist, Lint
epriestley merged task T12765: Autofixes removing lines render incorrectly in `arc lint` into T9846: Diff on `arc lint` misleading when the replacement has newlines.
May 27 2017, 8:08 PM · Lint, Arcanist, Bug Report
epriestley added a comment to T12765: Autofixes removing lines render incorrectly in `arc lint`.

I'm going to merge this into T9846 since I think they're the same, yell if it looks like I'm missing anything.

May 27 2017, 8:08 PM · Lint, Arcanist, Bug Report
chad awarded Phabricator Gold to recipient: reed.
May 27 2017, 7:54 PM
reed added a comment to T12766: Can't use `differential.createcomment` with message and action.

Thanks, everybody! Appreciate it, especially on a Friday night. :-)

May 27 2017, 6:36 AM · Differential, Conduit, Bug Report
reed backed I2 Donate to Phacility with $19.78 USD.
May 27 2017, 6:10 AM · Phacility
alexmv closed T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error) as Resolved.

Based on two points of anecdata so far, things indeed seem snappier with D17959.

May 27 2017, 4:32 AM · Restricted Project, Workboards
chad added a comment to T12768: PhabricatorTaskmasterDaemon using fabulous amounts of RAM.

Please read and follow Contributing Bug Reports carefully.

May 27 2017, 4:12 AM · Bug Report
chad closed T12768: PhabricatorTaskmasterDaemon using fabulous amounts of RAM as Invalid.
May 27 2017, 4:09 AM · Bug Report
kcloze created T12768: PhabricatorTaskmasterDaemon using fabulous amounts of RAM.
May 27 2017, 4:08 AM · Bug Report
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

Here's an example of the old style:

May 27 2017, 3:31 AM · Customer Impact, Feature Request
chad claimed T12766: Can't use `differential.createcomment` with message and action.
May 27 2017, 3:26 AM · Differential, Conduit, Bug Report
epriestley added a comment to T12766: Can't use `differential.createcomment` with message and action.

Also, test agents probably shouldn't be accepting revisions at all. But ¯\_(ツ)_/¯

May 27 2017, 3:18 AM · Differential, Conduit, Bug Report
epriestley added a comment to T12766: Can't use `differential.createcomment` with message and action.

Note also that differential.revision.edit accepts IDs and harbormaster.createartifact allows you to create links to build results without needing to gum up the feed with comments. We will eventually remove differential.createcomment so things will need to update sooner or later.

May 27 2017, 3:17 AM · Differential, Conduit, Bug Report
epriestley closed T12766: Can't use `differential.createcomment` with message and action as Resolved.

This should be fixed in HEAD of master and stable. Thanks for the report!

May 27 2017, 3:15 AM · Differential, Conduit, Bug Report
chad added a comment to T12767: Viewing a badge details page should show users that have received it.

Its on another page for scalability, we used to just have a single page.

May 27 2017, 3:06 AM · Badges, Feature Request
amckinley closed T12767: Viewing a badge details page should show users that have received it as Invalid.

Yep, that would be the page. I was expecting to see details ala "Related Objects" in Maniphest and failed to move my eyes sufficiently left.

May 27 2017, 3:05 AM · Badges, Feature Request
chad added a comment to T12767: Viewing a badge details page should show users that have received it.

This page?

May 27 2017, 3:02 AM · Badges, Feature Request
amckinley created T12767: Viewing a badge details page should show users that have received it.
May 27 2017, 2:58 AM · Badges, Feature Request
chad added a revision to T12766: Can't use `differential.createcomment` with message and action: Unknown Object (Differential Revision).
May 27 2017, 1:56 AM · Differential, Conduit, Bug Report
reed added a comment to T12766: Can't use `differential.createcomment` with message and action.

That does indeed work! Thank you so much!

May 27 2017, 1:53 AM · Differential, Conduit, Bug Report
chad added a comment to T12766: Can't use `differential.createcomment` with message and action.

Does this work?

May 27 2017, 1:41 AM · Differential, Conduit, Bug Report
reed added a comment to T12766: Can't use `differential.createcomment` with message and action.

Not easily. :/

May 27 2017, 1:29 AM · Differential, Conduit, Bug Report
amckinley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

From a technical standpoint, we did not record these relationships in a normalized way prior to D16196 (June 2016, about 7 months ago) -- they only existed in the transaction log, and we just wrote a "close", extra_data="as duplicate of X" transaction that can't be queried efficiently.

May 27 2017, 1:17 AM · Customer Impact, Feature Request
amckinley added a revision to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page: Unknown Object (Differential Revision).
May 27 2017, 1:14 AM · Customer Impact, Feature Request
chad added a comment to T12766: Can't use `differential.createcomment` with message and action.

Can you use the modern conduit calls?

May 27 2017, 1:13 AM · Differential, Conduit, Bug Report
amckinley claimed T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.
May 27 2017, 1:05 AM · Customer Impact, Feature Request
reed updated subscribers of T12766: Can't use `differential.createcomment` with message and action.
May 27 2017, 12:57 AM · Differential, Conduit, Bug Report
reed created T12766: Can't use `differential.createcomment` with message and action.
May 27 2017, 12:56 AM · Differential, Conduit, Bug Report

May 26 2017

alexmv created T12765: Autofixes removing lines render incorrectly in `arc lint`.
May 26 2017, 11:20 PM · Lint, Arcanist, Bug Report
chad closed T12185: Action Lists on Repository edit pages don't display on tablet/mobile as Resolved.

This accidentally got fixed this week

May 26 2017, 11:14 PM · Diffusion (v3), Bug Report
epriestley edited the content of Changelog.
May 26 2017, 11:05 PM
epriestley created 2017 Week 21 (Very Late May).
May 26 2017, 11:04 PM
isfs awarded T9868: PHUIDocumentViewPro ToC menu improvements a Party Time token.
May 26 2017, 10:59 PM · PHUI
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

That looks great to me.

May 26 2017, 10:30 PM · Maniphest, Conduit, Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Actual example output:

May 26 2017, 10:30 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Yeah, with whatever wrapping context maniphest.search has, so like:

May 26 2017, 10:28 PM · Maniphest, Conduit, Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

So should the return value for priority.search look something like this?

May 26 2017, 10:22 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

That is, the specific error "use lists" is aimed at preventing is this:

May 26 2017, 9:10 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

The config also looks like this right now:

May 26 2017, 9:07 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

I guess we already have "keywords" and should probably accept any of them, too, so "!priority high" in mail, /priority high in a comment, and "high" in Conduit all work consistently even if the actual key is "elevated".

May 26 2017, 9:02 PM · Maniphest, Conduit, Bug Report
amckinley closed T12104: Clean up remnants of old Differential draft storage as Resolved by committing Restricted Diffusion Commit.
May 26 2017, 8:59 PM · Infrastructure, Differential
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Ideally, we should maybe freeze maniphest.querystatuses (which has a sort of ridiculous output format, I think?) and provide maniphest.status.search and maniphest.priority.search, which return results similar to other modern *.search methods even if they aren't implemented quite the same way (at least make the output format similar enough that a client library with methods like "turn a x.search call into a list of objects" would work on these methods, too).

May 26 2017, 8:57 PM · Maniphest, Conduit, Bug Report
amckinley added a revision to T12104: Clean up remnants of old Differential draft storage: Unknown Object (Differential Revision).
May 26 2017, 8:51 PM · Infrastructure, Differential
amckinley claimed T12124: Counterintuitive priority setting via maniphest.edit conduit call.

It looks like what we really need is a new method like maniphest.querystatuses, called maniphest.querypriorities to avoid anyone trying to hardcode these values.

May 26 2017, 8:43 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12104: Clean up remnants of old Differential draft storage.

That sounds right to me.

May 26 2017, 8:39 PM · Infrastructure, Differential