Page MenuHomePhabricator

Validation error on accepting a revision on behalf of a project that had already accepted it
Closed, ResolvedPublic


It seems like there is a kind of 'race condition' when accepting a revision that was already accepted by one of the projects a user belongs to.

image.png (239×712 px, 73 KB)

  1. Create a project X, add users A and B as members.
  2. Open revision page as user A.
  3. Open revision page as user B (in another browser).
  4. Accept revision as user A on behalf of Project X.
  5. Accept revision as user B on behalf of Project X.
  6. Validation error
phabricator 53bc57ecef8739c29105eb52b1f118c0402e2c6c (Sat, Apr 29) (branched from d2baa88171fcc3f327b157277afb905430b5a918 on origin) 
arcanist ada63de9722e4b60ec9f0900a757b5b3873fc2f7 (Sat, Apr 29) (branched from 27b51e619237116d99e03fc1b3e8cd6399087214 on origin) 
phutil d02cc05931b02c684d4c729510090591ca45f951 (Sat, Apr 29) (branched from a900d7b63e954e221efe140f0f33d3d701524aae on origin)