Multiple reviewers can race one another to accept on behalf of packages and get a poor UX
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	epriestley
	May 25 2017, 7:16 PM

Description

Likely reproduction steps:

Revision R has multiple package reviewers, owned by users A and B, both of whom are non-authors.
Open a window as user A and prepare to accept.
Open a window as user B and prepare to accept.
Submit window A.
Submit window B.

Expected: goes through cleanly.

Actual: Dialog with error: Reviewer "PHID-OPKG-xxx" is not a valid reviewer which you have authority to accept on behalf of.

rP Phabricator
	D18019	rP19572f53fdfe Don't consider accepting on behalf of valid-but-accepted reviewers to be a…

Mentioned In: T12829: Synchronous accepts for the same project produce a misleading error
T12662: Validation error on accepting a revision on behalf of a project that had already accepted it

Yep, those repro steps look right to me.

I think that should fix things, but yell if I missed anything or made it worse or whatever. Thanks for the report!