Page MenuHomePhabricator
Feed Advanced Search

Apr 7 2020

epriestley closed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) as Resolved by committing rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3.
Apr 7 2020, 9:29 PM · XHPAST
epriestley closed T4334: Support PHP5.4+ syntax in XHPAST as Resolved.

Much of this is supported now; T13492 has some general followup.

Apr 7 2020, 9:27 PM · XHPAST
epriestley renamed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) from XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) to XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
Apr 7 2020, 9:03 PM · XHPAST
epriestley added a revision to T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3): D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Apr 7 2020, 9:02 PM · XHPAST
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to Windows on the XHPAST board.
Apr 7 2020, 1:33 PM · Windows, XHPAST
epriestley moved T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings from Backlog to Windows on the XHPAST board.
Apr 7 2020, 1:33 PM · XHPAST
epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Future on the XHPAST board.
Apr 7 2020, 1:32 PM · XHPAST, Arcanist
epriestley closed T7301: XHPAST application is not optimized for mobile as Wontfix.

No current plans to pursue this.

Apr 7 2020, 1:32 PM · XHPAST, Mobile
epriestley moved T10971: php lint: catch `"${var}"` vs `"{$var}"` from Backlog to String Variables on the XHPAST board.
Apr 7 2020, 1:32 PM · XHPAST, Lint, Feature Request
epriestley moved T11081: XHPAST doesn't handle complex embedded variables in strings using the same quoting style from Backlog to String Variables on the XHPAST board.
Apr 7 2020, 1:32 PM · XHPAST, Bug Report
epriestley moved T8049: Improve parsing of variables embedded in strings in XHPAST from Backlog to String Variables on the XHPAST board.
Apr 7 2020, 1:32 PM · XHPAST
epriestley triaged T9286: XHPAST fails to recognize inline HTML starting with "<?php" as Wishlist priority.
Apr 7 2020, 1:31 PM · XHPAST
epriestley moved T9286: XHPAST fails to recognize inline HTML starting with "<?php" from Backlog to Future on the XHPAST board.
Apr 7 2020, 1:31 PM · XHPAST
epriestley renamed T8325: XHPASTLinter does not scope parameters to closures correctly from Treat functions with parameters defined in other functions in XHPASTLinter correctly to XHPASTLinter does not scope parameters to closures correctly.
Apr 7 2020, 1:31 PM · XHPAST, Lint
epriestley moved T8325: XHPASTLinter does not scope parameters to closures correctly from Backlog to Future on the XHPAST board.
Apr 7 2020, 1:30 PM · XHPAST, Lint
epriestley closed T9062: Generalize PHPAST application as Wontfix.

No plans to pursue this.

Apr 7 2020, 1:29 PM · XHPAST
epriestley closed T8534: Need a way to retrieve fully qualified class name as Wontfix.

No longer clear what this accomplishes.

Apr 7 2020, 1:29 PM · XHPAST
epriestley closed T6195: Replace XHPAST with a pure PHP implementation as Wontfix.

I don't currently plan to pursue this.

Apr 7 2020, 1:28 PM · XHPAST
epriestley closed T10257: xhpast does not build on ARM hardware as Wontfix.

This is very old and we have no outstanding customer requests for ARM support.

Apr 7 2020, 1:27 PM · XHPAST, Bug Report

Oct 10 2018

wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19741: Let lint rules support anonymous classes.
Oct 10 2018, 12:04 AM · XHPAST

Oct 9 2018

wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM · XHPAST

Oct 8 2018

wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19736: Add support for anonymous class.
Oct 8 2018, 12:51 AM · XHPAST

Oct 2 2018

epriestley moved T6925: XHPAST is out of date on Windows from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Windows, XHPAST

Sep 24 2018

epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Upstream on the Arcanist board.
Sep 24 2018, 4:25 PM · XHPAST, Arcanist

Nov 13 2017

joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18770: Add support for nullable parameter types.
Nov 13 2017, 4:36 AM · XHPAST

Sep 25 2017

joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18639: Fix node for nullable return value.
Sep 25 2017, 5:32 AM · XHPAST

Sep 18 2017

joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D18621: Add support for nullable return types.
Sep 18 2017, 11:07 AM · XHPAST

Jul 10 2017

chad removed the image for XHPAST.
Jul 10 2017, 2:42 AM

Jul 9 2017

chad set the image for XHPAST to F5039312: profile.
Jul 9 2017, 7:44 PM
chad removed the image for XHPAST.
Jul 9 2017, 7:43 PM

May 19 2017

epriestley created T12734: Detect declared-but-unused variables in PHPAST linters.
May 19 2017, 9:03 PM · XHPAST, Lint

May 3 2017

epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Also, just so I don't completely forget about it:

May 3 2017, 5:25 PM · XHPAST
epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Changes in D17802, D17803, D17816 and D17817 all seem generally fine to me from cursory inspection. If D17819 seems sane for fixing the "huge blobs of unstable JSON" problem, let's stick them all on that, I'll take a closer look at the nodes, and we can get everything in? Good luck racing each other on minor version numbers.

May 3 2017, 5:24 PM · XHPAST
epriestley added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17820: Replace all the PHPAST JSON test data with readable test data.
May 3 2017, 5:09 PM · XHPAST
epriestley added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17819: Make PHPAST parser tests stable and human-readable.
May 3 2017, 5:07 PM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17817: Add support for exponentiation.
May 3 2017, 12:00 PM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17816: Add support for constant scalar expressions.
May 3 2017, 11:42 AM · XHPAST

Apr 28 2017

richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17803: (WIP) Add anonymous classes support to xhpast.
Apr 28 2017, 2:10 PM · XHPAST
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17802: Add nullable type hint support to xhpast.
Apr 28 2017, 8:43 AM · XHPAST

Aug 24 2016

epriestley added a comment to T7301: XHPAST application is not optimized for mobile.

The first page I found on the internet claims the iPhone 7 will be 1920x1080, so my strategy looks like it's paying off!

Aug 24 2016, 11:40 PM · XHPAST, Mobile

Jun 17 2016

richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D16138: Support class const dereferencing in xhpast.
Jun 17 2016, 9:53 AM · XHPAST

Jun 2 2016

asherkin created T11081: XHPAST doesn't handle complex embedded variables in strings using the same quoting style.
Jun 2 2016, 12:15 PM · XHPAST, Bug Report

May 27 2016

epriestley closed T9643: XHPast Parse error when extracting i18n as Resolved by committing rP10cc633b88b2: Warn and continue when failing to extract pht() strings.
May 27 2016, 3:11 AM · XHPAST
epriestley added a revision to T9643: XHPast Parse error when extracting i18n: D15983: Warn and continue when failing to extract pht() strings.
May 27 2016, 3:01 AM · XHPAST
epriestley added a parent task for T9643: XHPast Parse error when extracting i18n: T5267: Localize Phabricator.
May 27 2016, 2:48 AM · XHPAST

May 26 2016

epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

That seems fine to me.

May 26 2016, 12:35 PM · XHPAST
richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

I'm about to start implement full dereferencing support. Cases that are missing now:

($expr)[0];
SomeClass::BRILLIANT_CONSTANT[5];
May 26 2016, 10:13 AM · XHPAST

May 17 2016

joshuaspence added a parent task for T8049: Improve parsing of variables embedded in strings in XHPAST: T10971: php lint: catch `"${var}"` vs `"{$var}"`.
May 17 2016, 9:09 AM · XHPAST
joshuaspence added a subtask for T10971: php lint: catch `"${var}"` vs `"{$var}"`: T8049: Improve parsing of variables embedded in strings in XHPAST.
May 17 2016, 9:09 AM · XHPAST, Lint, Feature Request

May 16 2016

avivey renamed T10971: php lint: catch `"${var}"` vs `"{$var}"` from php lint: catch `"${var}"` vs `"{$var}" to php lint: catch `"${var}"` vs `"{$var}"`.
May 16 2016, 8:23 PM · XHPAST, Lint, Feature Request
avivey created T10971: php lint: catch `"${var}"` vs `"{$var}"`.
May 16 2016, 8:22 PM · XHPAST, Lint, Feature Request

Mar 20 2016

tycho.tatitscheff added a comment to T9643: XHPast Parse error when extracting i18n.

@ofbeaton, if you care also about starting a translation, you can do it for src/applications like this :
./bin/i18n extract src/applications and ./bin/i18n extract src/view and merge the results.

Mar 20 2016, 6:57 PM · XHPAST

Mar 13 2016

epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

I didn't purge the cache here, but here's an updated version of the original diff without the rendering error:

Mar 13 2016, 4:53 PM · XHPAST, Differential, Bug Report
epriestley closed T10576: Wrong highlighting for manually uploaded diff as Resolved.
Mar 13 2016, 4:50 PM · XHPAST, Differential, Bug Report
richardvanvelzen added a comment to T10576: Wrong highlighting for manually uploaded diff.

I wouldn't have expected the issue to be in xhpast at all. Thanks for the quick resolution!

Mar 13 2016, 2:52 PM · XHPAST, Differential, Bug Report
epriestley claimed T10576: Wrong highlighting for manually uploaded diff.
Mar 13 2016, 2:31 PM · XHPAST, Differential, Bug Report

Feb 24 2016

tycho.tatitscheff removed 7 mock(s) for T9175: XHPAST doesn't build automatically: M1433: Global Search, M1443: bob, M1442: "onmouseover="while(1){alert(1)};", M1440: Trying to carry over inline comments to new revision, M1453: <--`<img/src=` onerror=alert(1)> --!>, M1455: Hovercard Explorations, M1460: Project - Grey Background.
Feb 24 2016, 12:33 PM · XHPAST, Arcanist
tycho.tatitscheff removed a subtask for T9175: XHPAST doesn't build automatically: T10437: This Privacy Policy explains our practices regarding the collection, use and disclosure of information that we receive in connection with the phacility.com website or any of the applications, services, or support we make available (collectively, the "Service"). This Privacy Policy applies only to our Service and doesn't apply to any third-party websites, applications, services or tools, even if they are accessible through our Service..
Feb 24 2016, 12:32 PM · XHPAST, Arcanist
Persona added 7 mock(s) for T9175: XHPAST doesn't build automatically: M1460: Project - Grey Background, M1455: Hovercard Explorations, M1453: <--`<img/src=` onerror=alert(1)> --!>, M1440: Trying to carry over inline comments to new revision, M1442: "onmouseover="while(1){alert(1)};", M1443: bob, M1433: Global Search.
Feb 24 2016, 11:10 AM · XHPAST, Arcanist

Feb 17 2016

fanis added a comment to T9230: Libphutil xhpast seems broken.

In my case when attempting to generate symbols (per https://secure.phabricator.com/book/phabricator/article/diffusion_symbols/ ), this error was fixed by running make install in /usr/local/phabricator/libphutil/support/xhpast

Feb 17 2016, 2:43 PM · XHPAST

Feb 1 2016

zumbi added a comment to T10257: xhpast does not build on ARM hardware.

Broadly:

  • You only need to run arc liberate when developing Phabricator itself (e.g., writing Phabricator extensions or otherwise modifying Phabricator).
  • The one ARM system (the Raspberry Pi) we have other direct evidence of users attempting to do installs on is explicitly not supported as a Phabricator host platform -- see Installation Guide. You can try, but you're on your own.
  • If you're using an ARM system that could, in theory, broadly qualify as a "normal computer" to host and/or develop Phabricator this is something we might eventually look at supporting, but we don't currently have any evidence that anyone else is trying to do this. We are vanishingly unlikely to dedicate resources to ARM support for the benefit of only one user (if you are developing on ARM hardware) or one install (if you are hosting on ARM hardware).
  • If you did read the "Installation Guide" and believed ARM hardware to reasonably qualify as "a normal computer", we can add additional language to make it clear that ARM is not included in what we consider "a normal computer".
Feb 1 2016, 6:13 PM · XHPAST, Bug Report
epriestley renamed T10257: xhpast does not build on ARM hardware from arcanist: unable to run arc liberate on armhf hardware to xhpast does not build on ARM hardware.
Feb 1 2016, 5:48 PM · XHPAST, Bug Report

Jan 12 2016

joshuaspence changed the visibility for T1941: Populating Symbol indexes fail.
Jan 12 2016, 3:55 AM · XHPAST

Nov 17 2015

joshuaspence updated the title for P1892 xhpast_tree.php from untitled to xhpast_tree.php.
Nov 17 2015, 8:29 PM · XHPAST
joshuaspence added a comment to T9805: XHProf will not build on PHP7.

Oh sorry... I am dumb.

Nov 17 2015, 7:06 AM · XHProf
joshuaspence added a comment to T9805: XHProf will not build on PHP7.

(Assuming you meant XHPAST rather than XHProf)

Nov 17 2015, 7:06 AM · XHProf
joshuaspence renamed T9805: XHProf will not build on PHP7 from XHPROF will not build on PHP7 to XHPAST will not build on PHP7.
Nov 17 2015, 7:05 AM · XHProf

Nov 12 2015

joshuaspence renamed T9643: XHPast Parse error when extracting i18n from XHPast Parse error when etracting i18n to XHPast Parse error when extracting i18n.
Nov 12 2015, 10:20 AM · XHPAST

Nov 10 2015

joshuaspence claimed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
Nov 10 2015, 7:30 PM · XHPAST
joshuaspence renamed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) from xhpast no longer parses heredocs and can't build on OS X (Bison 2.3) to XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
Nov 10 2015, 7:28 PM · XHPAST
joshuaspence added a project to T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3): XHPAST.
Nov 10 2015, 7:28 PM · XHPAST

Nov 2 2015

joshuaspence closed T9289: Unable to build XHPAST as Resolved by committing rPHU7f4daf71c480: Allow XHPAST to be built without flex and bison.
Nov 2 2015, 8:52 AM · XHPAST

Nov 1 2015

joshuaspence added a revision to T9289: Unable to build XHPAST: D14376: Allow XHPAST to be built without flex and bison.
Nov 1 2015, 8:59 PM · XHPAST

Oct 27 2015

epriestley added a comment to T9643: XHPast Parse error when extracting i18n.

Probably not, but it seems vaguely nice that i18n extract doesn't need to know anything about the directory structure, and that we can put pht() in externals/ as a local patch if we need to clarify some error or something.

Oct 27 2015, 9:07 PM · XHPAST
joshuaspence added a comment to T9643: XHPast Parse error when extracting i18n.

Is there any real news to extract translations from externals/?

Oct 27 2015, 9:04 PM · XHPAST
epriestley triaged T9643: XHPast Parse error when extracting i18n as Wishlist priority.
Oct 27 2015, 4:47 PM · XHPAST
epriestley added a comment to T9643: XHPast Parse error when extracting i18n.

This is because externals/stripe-php/lib/Stripe/ApiRequestor.php has this on line 357:

Oct 27 2015, 4:47 PM · XHPAST
tycho.tatitscheff renamed T9643: XHPast Parse error when extracting i18n from XHPast Parse error on XHPASTTree.php:55 to XHPast Parse error when etracting i18n.
Oct 27 2015, 1:43 PM · XHPAST
tycho.tatitscheff created T9643: XHPast Parse error when extracting i18n.
Oct 27 2015, 1:42 PM · XHPAST

Sep 27 2015

chad added a comment to T9230: Libphutil xhpast seems broken.

See T9175

Sep 27 2015, 7:23 PM · XHPAST
jgable added a comment to T9230: Libphutil xhpast seems broken.

Ran into this today and had to try again for it to work (and upgrade). The error is scary and probably should be addressed.

Sep 27 2015, 7:09 PM · XHPAST

Sep 6 2015

joshuaspence triaged T9062: Generalize PHPAST application as Wishlist priority.
Sep 6 2015, 8:17 AM · XHPAST

Sep 3 2015

chad added a comment to T9289: Unable to build XHPAST.

hit this too.

Sep 3 2015, 12:42 AM · XHPAST

Sep 1 2015

meitros added a comment to T9289: Unable to build XHPAST.

https://secure.phabricator.com/D14031

Sep 1 2015, 3:55 PM · XHPAST
meitros added a comment to T9289: Unable to build XHPAST.

Also unable to build XHPAST, but for a different reason.

Sep 1 2015, 3:36 PM · XHPAST

Aug 31 2015

epriestley added a comment to T9289: Unable to build XHPAST.

We could make make not actually depend on the timestamps on those files, conceivably (only on whether they exist).

Aug 31 2015, 1:08 PM · XHPAST
joshuaspence added a comment to T9289: Unable to build XHPAST.

I think that the issue was that the timestamp on parser.yacc.hpp was older than the timestamp on parser.y. I'm not really sure how git handles timestamps but likely they aren't preserved.

Aug 31 2015, 1:04 PM · XHPAST
epriestley added a comment to T9289: Unable to build XHPAST.

What was getting cached that created an issue?

Aug 31 2015, 12:55 PM · XHPAST
chad changed the visibility for XHPAST.
Aug 31 2015, 3:40 AM

Aug 30 2015

joshuaspence added a comment to T9289: Unable to build XHPAST.

I guess git doesn't preserve timestamps... I just worked around this by running rm support/xhpast/* && git reset --hard HEAD && ./scripts/build_xhpast.php.

Aug 30 2015, 10:23 PM · XHPAST
joshuaspence created T9289: Unable to build XHPAST.
Aug 30 2015, 10:11 PM · XHPAST
joshuaspence created T9286: XHPAST fails to recognize inline HTML starting with "<?php".
Aug 30 2015, 12:09 PM · XHPAST

Aug 23 2015

joshuaspence claimed T4334: Support PHP5.4+ syntax in XHPAST.
Aug 23 2015, 3:00 AM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D13968: Improve XHPAST handling of traits.
Aug 23 2015, 1:55 AM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D13967: Improve handling of PHP 5.4 features.
Aug 23 2015, 1:55 AM · XHPAST

Aug 22 2015

joshuaspence edited projects for T9230: Libphutil xhpast seems broken, added: XHPAST; removed libphutil.
Aug 22 2015, 6:29 AM · XHPAST
joshuaspence updated subscribers of T9175: XHPAST doesn't build automatically.
Aug 22 2015, 4:38 AM · XHPAST, Arcanist
joshuaspence edited projects for T1941: Populating Symbol indexes fail, added: XHPAST; removed Differential.
Aug 22 2015, 2:46 AM · XHPAST

Aug 21 2015

joshuaspence claimed T9175: XHPAST doesn't build automatically.
Aug 21 2015, 11:23 AM · XHPAST, Arcanist
joshuaspence updated the task description for T9175: XHPAST doesn't build automatically.
Aug 21 2015, 11:21 AM · XHPAST, Arcanist