Paths

Table of Contentst

Replace all the PHPAST JSON test data with readable test data
AbandonedPublic
Actions

Authored by epriestley on May 3 2017, 5:09 PM.

Details

Reviewers

chad
joshuaspence
richardvanvelzen

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Summary

Depends on D17819. Ref T4334. This applies the changes from D17819 to the actual test data.

NOTE: This probably identified a bug in php-traits.php.test: we generate a node with type ID 0. I didn't fix it here.

Test Plan

Test pass.

Diff Detail

Repository

rPHU libphutil

Branch

xhp2

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 16774
Build 22381: Run Core Tests
Build 22380: arc lint + arc unit

Event Timeline

epriestley created this revision.May 3 2017, 5:09 PM

Herald added a subscriber: Firehed. · View Herald TranscriptMay 3 2017, 5:09 PM

Harbormaster completed remote builds in B16774: Diff 42848.May 3 2017, 5:09 PM

epriestley added inline comments.May 3 2017, 5:11 PM

src/parser/xhpast/__tests__/data/base-pass.php.test
5–11	WOW AMAZING SO READABLE!

epriestley mentioned this in T4334: Support PHP5.4+ syntax in XHPAST.May 3 2017, 5:25 PM

joshuaspence mentioned this in D17819: Make PHPAST parser tests stable and human-readable.May 3 2017, 9:58 PM

I think this needs to be updated? It fails for me locally.

Yeah, I did all of this manually so I was waiting for D17819 to update it.

I'm just going to trust that you will fix this after D17819 lands.

This revision is now accepted and ready to land.May 3 2017, 11:49 PM

epriestley planned changes to this revision.May 4 2017, 12:01 AM

wjiang added a subscriber: wjiang.May 4 2017, 2:35 AM

Superseded by D21066.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

base-pass.php.test

38 lines

call-time-pass-by-ref.php.test

119 lines

namespace.php.test

487 lines

operator-coalesce.php.test

152 lines

operator-spaceship.php.test

110 lines

php-access-on-instanciation.test

815 lines

php-array-dereference-2.test

219 lines

php-array-dereference-3.test

252 lines

php-array-dereference-4.test

183 lines

php-array-dereference.test

808 lines

php-binary-literal.php.test

63 lines

php-callable-typehint.php.test

183 lines

php-comments.php.test

73 lines

php-empty-heredoc.php.test

110 lines

php-finally.php.test

216 lines

php-literal-index.php.test

197 lines

php-literals.php.test

438 lines

php-only-finally.test

129 lines

php-short-array.php.test

81 lines

14072 lines

264 lines

1157 lines

549 lines

1774 lines

462 lines

894 lines

Diff 42848

View Options

src/parser/xhpast/tests/data/base-pass.php.test

View Options

src/parser/xhpast/tests/data/call-time-pass-by-ref.php.test

View Options

src/parser/xhpast/tests/data/namespace.php.test

View Options

src/parser/xhpast/tests/data/operator-coalesce.php.test

View Options

src/parser/xhpast/tests/data/operator-spaceship.php.test

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-2.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-3.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-4.test

View Options

src/parser/xhpast/tests/data/php-array-dereference.test

View Options

src/parser/xhpast/tests/data/php-binary-literal.php.test

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-comments.php.test

View Options

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

View Options

src/parser/xhpast/tests/data/php-finally.php.test

View Options

src/parser/xhpast/tests/data/php-literal-index.php.test

View Options

src/parser/xhpast/tests/data/php-literals.php.test

View Options

src/parser/xhpast/tests/data/php-only-finally.test

View Options

src/parser/xhpast/tests/data/php-short-array.php.test

View Options

src/parser/xhpast/tests/data/php-syntax.php.test

View Options

src/parser/xhpast/tests/data/php-tags.php.test

View Options

src/parser/xhpast/tests/data/php-traits.php.test

View Options

src/parser/xhpast/tests/data/php-yield.php.test

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/tests/data/use.php.test

View Options

src/parser/xhpast/tests/data/variadic.php.test

Replace all the PHPAST JSON test data with readable test dataAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42848

src/parser/xhpast/__tests__/data/base-pass.php.test

src/parser/xhpast/__tests__/data/call-time-pass-by-ref.php.test

src/parser/xhpast/__tests__/data/namespace.php.test

src/parser/xhpast/__tests__/data/operator-coalesce.php.test

src/parser/xhpast/__tests__/data/operator-spaceship.php.test

src/parser/xhpast/__tests__/data/php-access-on-instanciation.test

src/parser/xhpast/__tests__/data/php-array-dereference-2.test

src/parser/xhpast/__tests__/data/php-array-dereference-3.test

src/parser/xhpast/__tests__/data/php-array-dereference-4.test

src/parser/xhpast/__tests__/data/php-array-dereference.test

src/parser/xhpast/__tests__/data/php-binary-literal.php.test

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-comments.php.test

src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test

src/parser/xhpast/__tests__/data/php-finally.php.test

src/parser/xhpast/__tests__/data/php-literal-index.php.test

src/parser/xhpast/__tests__/data/php-literals.php.test

src/parser/xhpast/__tests__/data/php-only-finally.test

src/parser/xhpast/__tests__/data/php-short-array.php.test

src/parser/xhpast/__tests__/data/php-syntax.php.test

src/parser/xhpast/__tests__/data/php-tags.php.test

src/parser/xhpast/__tests__/data/php-traits.php.test

src/parser/xhpast/__tests__/data/php-yield.php.test

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/__tests__/data/use.php.test

src/parser/xhpast/__tests__/data/variadic.php.test

Replace all the PHPAST JSON test data with readable test data
AbandonedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/base-pass.php.test

src/parser/xhpast/tests/data/call-time-pass-by-ref.php.test

src/parser/xhpast/tests/data/namespace.php.test

src/parser/xhpast/tests/data/operator-coalesce.php.test

src/parser/xhpast/tests/data/operator-spaceship.php.test

src/parser/xhpast/tests/data/php-access-on-instanciation.test

src/parser/xhpast/tests/data/php-array-dereference-2.test

src/parser/xhpast/tests/data/php-array-dereference-3.test

src/parser/xhpast/tests/data/php-array-dereference-4.test

src/parser/xhpast/tests/data/php-array-dereference.test

src/parser/xhpast/tests/data/php-binary-literal.php.test

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-comments.php.test

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

src/parser/xhpast/tests/data/php-finally.php.test

src/parser/xhpast/tests/data/php-literal-index.php.test

src/parser/xhpast/tests/data/php-literals.php.test

src/parser/xhpast/tests/data/php-only-finally.test

src/parser/xhpast/tests/data/php-short-array.php.test

src/parser/xhpast/tests/data/php-syntax.php.test

src/parser/xhpast/tests/data/php-tags.php.test

src/parser/xhpast/tests/data/php-traits.php.test

src/parser/xhpast/tests/data/php-yield.php.test

src/parser/xhpast/tests/data/return-type.php.test

src/parser/xhpast/tests/data/use.php.test

src/parser/xhpast/tests/data/variadic.php.test